mozilla :: #treeherder

19 Apr 2017
00:06herokubotdeployed a3eb8b5 to treeherder-stage
00:06herokubotdeployed a3eb8b5 to treeherder-prototype
00:33herokubotdeployed ac89962 to treeherder-stage
00:33herokubotdeployed ac89962 to treeherder-prototype
11:45herokubotdeployed cb6b111 to treeherder-prototype
11:45herokubotdeployed cb6b111 to treeherder-stage
13:01herokubotdeployed 0494552 to treeherder-prototype
13:02herokubotdeployed 0494552 to treeherder-stage
13:07emorleyjgraham: thank you for the reviews. I think pressing merge leaves the review open - there's a button for review and then an option for "approve" which marks it as reviewed
13:08jgrahamemorley: Oh for some reason I thought that just merging stuff also closed the review
13:08emorleyit may still be worth keeping the workflow of "if author has push access, let them merge after approval, in case not ready etc"
13:09emorleyYeah it's all good, I just thought I'd say before there ended up being lots of open reviews adding noise to your queue :-)
13:09jgrahamemorley: OK, sorry. I was short circuiting a bit since I know this is not running in prod at the moment
13:09emorleyyeah for this it's absolutely fine :-)
13:10jgrahamemorley: It seems that they aren't on my list at https://github.com/pulls/review-requested anymore
13:10emorleyah ok
13:20herokubotdeployed 9dad6fe to treeherder-prototype
13:20herokubotdeployed 9dad6fe to treeherder-stage
16:04jgrahamApparently literally every meeting room in the office is taken and we didn't book one :/
16:05emorleycamd: https://code.facebook.com/posts/1362748677097871/relay-modern-simpler-faster-more-extensible/
16:06camdoops, one sec
16:06jgrahamHmm, not sure I had much for this meeting anyway; OK if I skip it? I've added a room for next time
16:07emorleycamd: https://techcrunch.com/2017/04/18/facebook-announces-react-fiber-a-rewrite-of-its-react-framework/
16:08emorleyjgraham: fine with me :-)
16:54wlachyeah the new react stuff sounds neat
16:55wlachi'm told this video by lin clark is good: https://www.youtube.com/watch?v=ZCuYPiUIONs
17:06rbillingsemorley: thanks for the review- before I get working on it, I was curious: most of your comments seem to be about removing stuff that is needed for Jenkins to run in the new jenkins folder, shouldn't those be kept as-is ?
17:06rbillingsfor example the comments about link & flake8
17:11emorleyrbillings: all files in the treeherder repo are already linted, so there's no need to run another lint run in Jenkins
17:12rbillingsok
17:59herokubotdeployed ac89962 to treeherder-prod
18:10herokubotdeployed 28a6d89 to treeherder-stage
18:10herokubotdeployed 28a6d89 to treeherder-prototype
18:17emorleycamd: https://github.com/garbles/why-did-you-update
18:18camdemorley: haha... That's awesome...
18:18camdAt first I thought it was a joke, but actually looks like it's legit, eh?
20:32camdhttp://www.candycrate.com/robin-eggs-candy.html?utm_source=google&utm_medium=cpc&scid=scplprobin-eggs-candy&sc_intid=robin-eggs-candy&gclid=CPaD79-usdMCFUlqfgodzMwDQQ
20:34AutomatedTesterhttps://duckduckgo.com/?q=minieggs&t=ffab&iax=1&ia=images
20:48jgrahamhttps://cocoarunners.com/explore/taste/
20:49AutomatedTesterjgraham: we were discussing easter over indulgence
21:18herokubotdeployed ac89962 to treeherder-prod
20 Apr 2017
No messages
   
Last message: 9 days and 4 hours ago