mozilla :: #screenshots

17 Apr 2017
01:14clouserwcan see it in tonights nightly though! w00t
01:16GitHub[screenshots] wresuolc opened issue #2694: buildSettings is not defined https://git.io/vSdI0
09:32GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSd41
09:32GitHubscreenshots/master d169267 Baurzhan Muftakhidinov: Pontoon: Update Kazakh (kk) localization of Firefox Screenshots...
11:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSdzI
11:11GitHubscreenshots/master 951cc3c Baurzhan Muftakhidinov: Pontoon: Update Kazakh (kk) localization of Firefox Screenshots...
11:41GitHub[screenshots] tomrittervg commented on issue #2678: This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.... https://git.io/vSdg1
11:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSd2U
11:51GitHubscreenshots/master 197de08 Baurzhan Muftakhidinov: Pontoon: Update Kazakh (kk) localization of Firefox Screenshots...
12:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSd2p
12:11GitHubscreenshots/master 9ce4fb1 Baurzhan Muftakhidinov: Pontoon: Update Kazakh (kk) localization of Firefox Screenshots...
14:50GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSdMB
14:50GitHubscreenshots/master 819c2ff Hrant: Pontoon: Update Armenian (hy-AM) localization of Firefox Screenshots...
14:56circleci-botFixed: mozilla-pontoon's build (#1063; push) in mozilla-services/screenshots (master) -- https://circleci.com/gh/mozilla-services/screenshots/1063?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
15:39rhelmerianbicking: hm. so I actually tested that screenshots was working correctly in my local build before we re-landed it... so that's really strange it's not working on nightly
15:42rhelmerI do see the problem on nightly though. odd.
15:42ianbickingrhelmer: yeah I realize that we made a change from setting things in `window.moduleName = foo` to `this.modueName = foo` except for buildSettings, which is still window.buildSettings = ...
15:43clouserwwe need to land a patch in nightly to fix this?
15:43ianbickingbut that seems like it should be harmless
15:43rhelmerI am going to see if it's happening on nightly.. it's possible we're missing something in a moz.build or jar.mn file or something mundane like that
15:43rhelmerer s/nightly/a local mozilla-central build/
15:44rhelmerI can repro on nightly :)
15:44ianbickingrhelmer: so I *think* buildSettings and log.js are loading okay in the background page, but not the selection content worker
15:44ianbickingyes, Im pretty sure of that
16:03rhelmeryeah this isn't working in mozilla-central build, doesn't look like anything significant changed in the screenshots side... totally possible we broke it in the webextensions impl in firefox in the meantime. hm.
16:03ianbickingrhelmer: I got it failing similarly in dev too
16:04ianbickingrhelmer: one file is executed that sets window||this.buildSettings = {}, and the next file executed cant see it
16:04rhelmerlet me update to an older central and see if that is the case... if so then we can bisect, if not then it's something else
16:04ianbicking(window vs. this doesnt matter)
16:04rhelmerinteresting
16:13_6a68I wonder if something got left out of the moz.build file, Standard8 had to manually insert all the extension files in there for windows builds to work properly
16:14rhelmerdoesn't look like it... I am sure this worked before
16:14ianbickingrhelmer: I set buildSettings just so this one case would work, and then got another error about one module not seeing the other
16:14ianbickingrhelmer: so its not buildSettings-specific, its like each module file is loaded into its own scope
16:14rhelmerI am building mozilla-central from friday when I remember this working to see
16:14rhelmeryeah, there were lots of changes to toolkit/components/webextensions in the meantime
16:15_6a68ianbicking: should buildSettings.js.template be included in the build? I'm thinking maybe not? https://dxr.mozilla.org/mozilla-central/source/browser/extensions/screenshots/moz.build#17
16:16ianbicking_6a68: it shouldnt, no (cleanliness issue though, not this bug)
16:16ianbicking_6a68: I think theres a bug for it
16:16_6a68ah, ok
16:18_6a68I'm doing a full local build of central to try to reproduce / debug
16:25rhelmer_6a68: ianbicking: ok this works on an older rev of m-c
16:26rhelmerit was backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a91f922e14ad
16:26rhelmerif I update to a91f922e14ad and import the csets to land screenshots, it works
16:26rhelmerso somewhere between a91f922e14ad and tip it broke, I'll bisect
16:26ianbickingrhelmer: thank you very much!
16:26_6a68rhelmer: sweet! thank you
16:32GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSdh3
16:32GitHubscreenshots/master ce7203c Andreas Pettersson: Pontoon: Update Swedish (sv-SE) localization of Firefox Screenshots...
16:39circleci-botFailed: mozilla-pontoon's build (#1064; push) in mozilla-services/screenshots (master) -- https://circleci.com/gh/mozilla-services/screenshots/1064?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
16:50GitHub[screenshots] dannycoates closed issue #2306: Implement shooting page https://git.io/vSFez
17:28GitHub[screenshots] wresuolc commented on issue #2694: Being tracked at https://bugzilla.mozilla.org/show_bug.cgi?id=1357137 https://git.io/vSFTh
17:29firebotBug 1357137 NEW, nobody@mozilla.org WebExtension content scripts cannot see globals assigned in each other
17:42GitHub[screenshots] wresuolc closed issue #2694: buildSettings is not defined https://git.io/vSdI0
17:45_6a68https://bugzilla.mozilla.org/show_bug.cgi?id=1355569
17:45firebotBug 1355569 NEW, nobody@mozilla.org [meta] Fix unit tests broken when Screenshots is enabled.
18:04GitHub[screenshots] ianb opened issue #2695: Expand Selenium test https://git.io/vSFmW
18:24pdehaanhey y'all, i'm back... where's the best place to get/install Screenshots? https://screenshots.stage.mozaws.net/homepage/install-test-local.html or should i use dev server? or do we have a working Firefox build yet?
18:28GitHub[screenshots] dannycoates created robots (+1 new commit): https://git.io/vSF3l
18:28GitHubscreenshots/robots 3e3b716 Danny Coates: added robots.txt route
18:29clouserwhi pdehaan we did land in Fx, but it's broken right now; bug 1357137
18:29firebothttps://bugzil.la/1357137 NEW, kmaglione+bmo@mozilla.com WebExtension content scripts cannot see globals assigned in each other
18:30GitHub[screenshots] dannycoates opened pull request #2696: added robots.txt route (master...robots) https://git.io/vSF3i
18:35pdehaanclouserw: but is there still a "next best" place I can install it from so I can do some testing? or is dev/stage servers busted?
18:38clouserwI don't think anything is busted. stage should be good. https://github.com/mozilla-services/screenshots/releases/tag/6.3.0 is the latest tag, scheduled for this week
18:40GitHub[screenshots] dannycoates created txp (+1 new commit): https://git.io/vSFGl
18:40GitHubscreenshots/txp d694a75 Danny Coates: removed Test Pilot reference from /leave
18:41GitHub[screenshots] dannycoates opened pull request #2697: removed Test Pilot reference from /leave (master...txp) https://git.io/vSFGu
18:59ckpriceianbicking: clouserw i feel like we'd be asking a lot to uplift the patches while they're broken on nightly
19:00ckpricemaybe we'll hope for that regression to land in nightly (i'll bug mixedpuppy for a review) today, and push our schedule back 1 day
19:00ianbickingckprice: yeah, thats understandable
19:00clouserwok. whoever gets here first tomorrow morning, let's talk to Mark too
19:06ckpriceianbicking: i think this is another one that wants to get uplifted https://bugzilla.mozilla.org/show_bug.cgi?id=1347482
19:06firebotBug 1347482 FIXED, standard8@mozilla.com Having a System Add-on as a WebExtension with a content script causes mochitest failures in dom/ to
19:33ianbickingckprice: I think that doesnt have to be uplifted, because it was also fixed by having Screenshots disabled during the test runs
19:33ckpricecool
20:15GitHub[screenshots] pdehaan commented on pull request #2693 7990bff: Does this need to be localized, or are we not doing server l10n yet? https://git.io/vSFuB
20:34GitHub[screenshots] dannycoates commented on pull request #2693 7990bff: it will. we haven't started server l10n yet https://git.io/vSFVr
21:12GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vSFXc
21:12GitHubscreenshots/master 14dee78 jlG: Pontoon: Update Spanish (es-ES) localization of Firefox Screenshots...
22:38GitHub[screenshots] pdehaan commented on pull request #2697 d694a75: Not sure if you want to remove the trailing `<br/>` too. https://git.io/vSFNF
23:37rpapapdehaan: running 1 loadtest on stage. should finish in 10 mins
18 Apr 2017
No messages
   
Last message: 36 days and 18 hours ago