mozilla :: #screenshots

14 Jul 2017
00:08GitHub[screenshots] 6a68 commented on issue #3038: Looking a little more closely at the [browser console screenshot](https://github.com/mozilla-services/screenshots/issues/3038#issuecomment-308522707) above, it looks like "Win error 123" is due to illegal characters in the filename.... https://git.io/vQQ60
00:09cloudops-ansiblescreenshots-dev build #165: building mozilla/screenshots:latest
00:11cloudops-ansiblescreenshots-dev build #165: mozilla/screenshots:latest deployed to Dev
00:12GitHub[screenshots] milescrabill tagged 8.2.1 at 8.2.0: https://git.io/vQQ6S
00:32GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQPb
00:32GitHubscreenshots/master 3eda154 YFdyh000: Pontoon: Update Chinese (zh-CN) localization of Firefox Screenshots...
00:46cloudops-ansiblescreenshots-dev build #166: building mozilla/screenshots:latest
00:48cloudops-ansiblescreenshots-dev build #166: mozilla/screenshots:latest deployed to Dev
01:10GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQDk
01:10GitHubscreenshots/master f1a4d47 Kohei Yoshino: Pontoon: Update Japanese (ja) localization of Firefox Screenshots...
01:24cloudops-ansiblescreenshots-dev build #167: building mozilla/screenshots:latest
01:27cloudops-ansiblescreenshots-dev build #167: mozilla/screenshots:latest deployed to Dev
02:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQHP
02:31GitHubscreenshots/master 3953749 Lasse Liehu: Pontoon: Update Finnish (fi) localization of Firefox Screenshots...
02:45cloudops-ansiblescreenshots-dev build #168: building mozilla/screenshots:latest
02:47cloudops-ansiblescreenshots-dev build #168: mozilla/screenshots:latest deployed to Dev
02:50GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQQN
02:50GitHubscreenshots/master 5339fbc Lasse Liehu: Pontoon: Update Finnish (fi) localization of Firefox Screenshots...
03:04cloudops-ansiblescreenshots-dev build #169: building mozilla/screenshots:latest
03:07cloudops-ansiblescreenshots-dev build #169: mozilla/screenshots:latest deployed to Dev
03:50GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQFL
03:50GitHubscreenshots/master 329fa30 nuttapong2539: Pontoon: Update Thai (th) localization of Firefox Screenshots...
04:04cloudops-ansiblescreenshots-dev build #170: building mozilla/screenshots:latest
04:07cloudops-ansiblescreenshots-dev build #170: mozilla/screenshots:latest deployed to Dev
05:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQxN
05:31GitHubscreenshots/master 61ea03c Rok erdin: Pontoon: Update Slovenian (sl) localization of Firefox Screenshots...
05:45cloudops-ansiblescreenshots-dev build #171: building mozilla/screenshots:latest
05:47cloudops-ansiblescreenshots-dev build #171: mozilla/screenshots:latest deployed to Dev
06:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQjU
06:11GitHubscreenshots/master 8882808 avelper: Pontoon: Update Spanish (es-ES) localization of Firefox Screenshots...
06:25cloudops-ansiblescreenshots-dev build #172: building mozilla/screenshots:latest
06:28cloudops-ansiblescreenshots-dev build #172: mozilla/screenshots:latest deployed to Dev
06:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQjh
06:31GitHubscreenshots/master 464dba6 Tho Chevalier: Pontoon: Update French (fr) localization of Firefox Screenshots...
06:45cloudops-ansiblescreenshots-dev build #173: building mozilla/screenshots:latest
06:47cloudops-ansiblescreenshots-dev build #173: mozilla/screenshots:latest deployed to Dev
07:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Tb
07:31GitHubscreenshots/master 1a4f613 Pin-guang Chen: Pontoon: Update Chinese (zh-TW) localization of Firefox Screenshots...
07:44cloudops-ansiblescreenshots-dev build #174: building mozilla/screenshots:latest
07:47cloudops-ansiblescreenshots-dev build #174: mozilla/screenshots:latest deployed to Dev
07:50GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Ik
07:50GitHubscreenshots/master 96a2895 stoyan: Pontoon: Update Bulgarian (bg) localization of Firefox Screenshots...
08:07cloudops-ansiblescreenshots-dev build #175: building mozilla/screenshots:latest
08:09cloudops-ansiblescreenshots-dev build #175: mozilla/screenshots:latest deployed to Dev
08:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7mG
08:51GitHubscreenshots/master 6db9088 Fjoerfoks: Pontoon: Update Frisian (fy-NL) localization of Firefox Screenshots...
09:05cloudops-ansiblescreenshots-dev build #176: building mozilla/screenshots:latest
09:07cloudops-ansiblescreenshots-dev build #176: mozilla/screenshots:latest deployed to Dev
09:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Y6
09:11GitHubscreenshots/master 33b7ba4 Fjoerfoks: Pontoon: Update Frisian (fy-NL) localization of Firefox Screenshots...
09:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Yi
09:11GitHubscreenshots/master 1738892 Balzs Mesk: Pontoon: Update Hungarian (hu) localization of Firefox Screenshots...
09:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7YX
09:11GitHubscreenshots/master dc29bf0 Marko Andreji: Pontoon: Update Serbian (sr) localization of Firefox Screenshots...
09:24cloudops-ansiblescreenshots-dev build #177: building mozilla/screenshots:latest
09:25cloudops-ansiblescreenshots-dev build #178: building mozilla/screenshots:latest
09:25cloudops-ansiblescreenshots-dev build #178: deploy failed /cc relud
09:27cloudops-ansiblescreenshots-dev build #177: mozilla/screenshots:latest deployed to Dev
09:37GitHub[screenshots] youwenliang commented on issue #3080: @niharikak101 Here's the visual updated version:... https://git.io/vQ7sL
09:49GitHub[screenshots] jnachtigall opened issue #3123: Screenshotting http://www.bmvi.de results in broken image and 'Error in promise: TypeError: result is undefined' https://git.io/vQ7GY
09:53GitHub[screenshots] youwenliang commented on issue #3112: @niharikak101 Sounds good!... https://git.io/vQ7GB
10:10GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Zd
10:10GitHubscreenshots/master 5297822 Moend Belqasem: Pontoon: Update Kabyle (kab) localization of Firefox Screenshots...
10:24cloudops-ansiblescreenshots-dev build #179: building mozilla/screenshots:latest
10:27cloudops-ansiblescreenshots-dev build #179: mozilla/screenshots:latest deployed to Dev
10:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Cd
10:51GitHubscreenshots/master d3eab38 Balzs Mesk: Pontoon: Update Hungarian (hu) localization of Firefox Screenshots...
11:03cloudops-ansiblescreenshots-dev build #180: building mozilla/screenshots:latest
11:06cloudops-ansiblescreenshots-dev build #180: mozilla/screenshots:latest deployed to Dev
13:05GitHub[screenshots] crabel opened issue #3124: Content with position:fixed isn't shot properly https://git.io/vQ7ac
13:34GitHub[screenshots] niharikak101 created shot-annotations (+2 new commits): https://git.io/vQ7ra
13:34GitHubscreenshots/shot-annotations f2e72d8 Niharika Khanna: add annotation
13:34GitHubscreenshots/shot-annotations 121bae9 Niharika Khanna: highlighter tool ui
13:36GitHub[screenshots] niharikak101 commented on pull request #3082 4f7a2ac: Done! https://git.io/vQ7rX
13:37GitHub[screenshots] SoftVision-EmilPasca opened issue #3125: A blank space is displayed instead of the "Screenshots" toolbar button https://git.io/vQ7r5
13:42GitHub[screenshots] niharikak101 opened pull request #3126: Shot annotations - WIP (master...shot-annotations) https://git.io/vQ7ou
13:45GitHub[screenshots] niharikak101 force-pushed shot-annotations from 121bae9 to f628bee: https://git.io/vQ7ob
13:45GitHubscreenshots/shot-annotations f628bee Niharika Khanna: highlighter tool ui
13:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7KV
13:51GitHubscreenshots/master b5b92ca Francesco Lodolo: Pontoon: Update Italian (it) localization of Firefox Screenshots...
13:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7Kw
13:51GitHubscreenshots/master 4ee01b3 Bjrn I: Pontoon: Update Norwegian Nynorsk (nn-NO) localization of Firefox Screenshots...
13:55circleci-botFailed: niharikak101's build (#2035; push) in mozilla-services/screenshots (shot-annotations) -- https://circleci.com/gh/mozilla-services/screenshots/2035?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
14:00GitHub[screenshots] SoftVision-PaulOiegas opened issue #3127: [Windows] "Screenshots went haywire" error message displayed for any screenshot taken and the overlay wrongly remains displayed on root page https://git.io/vQ76a
14:04cloudops-ansiblescreenshots-dev build #181: building mozilla/screenshots:latest
14:07cloudops-ansiblescreenshots-dev build #181: mozilla/screenshots:latest deployed to Dev
14:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7iX
14:11GitHubscreenshots/master 6bfec51 Jim Spentzos: Pontoon: Update Greek (el) localization of Firefox Screenshots...
14:16GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3127: @ianb Filed this issue also in Bugzilla and NI Kris Maglione on it, since it seems that his changes generated this behavior. https://git.io/vQ7Pg
14:17GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3127: @ianb Filed this issue also in Bugzilla [(1381023)](https://bugzilla.mozilla.org/show_bug.cgi?id=1381023) and NI Kris Maglione on it, since it seems that his changes generated this behavior. https://git.io/vQ7Pg
14:17firebotBug 1381023 NEW, nobody@mozilla.org [Windows] "Screenshots went haywire" error message displayed for any screenshot taken and the Screen
14:24cloudops-ansiblescreenshots-dev build #182: building mozilla/screenshots:latest
14:27cloudops-ansiblescreenshots-dev build #182: mozilla/screenshots:latest deployed to Dev
14:32GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ71D
14:32GitHubscreenshots/master 8c9ba3c Amin Mahmudian: Pontoon: Update Persian (fa) localization of Firefox Screenshots...
14:43clouserwianbicking: how do we normally push stage these days? (re: email from last night)
14:46cloudops-ansiblescreenshots-dev build #183: building mozilla/screenshots:latest
14:48cloudops-ansiblescreenshots-dev build #183: mozilla/screenshots:latest deployed to Dev
14:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ7yB
14:51GitHubscreenshots/master 265f503 Piotr Drg: Pontoon: Update Polish (pl) localization of Firefox Screenshots...
15:04cloudops-ansiblescreenshots-dev build #184: building mozilla/screenshots:latest
15:06cloudops-ansiblescreenshots-dev build #184: mozilla/screenshots:latest deployed to Dev
15:08GitHub[screenshots] ianb opened issue #3128: Create addon-export branch and production-server https://git.io/vQ7Hu
15:18GitHub[screenshots] ianb opened issue #3129: Some users aren't appearing as logged-in on their own shots https://git.io/vQ7Qr
15:46_6a68I've gotta walk the dog, will be back around 915
15:46_6a68we can double check that the deployment process is documented, once we figure it out :-)
15:50GitHub[screenshots] SoftVision-CarmenFat opened issue #3130: Saved shot preview link is not copied to clipboard on Beta https://git.io/vQ7Fa
15:59clouserwit looks like circleci is set up to only build PRs
15:59clouserwso it doesn't build the stable branch
16:00ianbickingclouserw: yeah, thats why I suggested making a PR
16:00clouserwianbicking: how about just having it build branches?
16:00ianbickingclouserw: if thats a way you can configure it, that would be much better
16:01clouserwyeah. the default is to build everything. someone changed it to only build PRs
16:01ianbickingI guess we do that for master already?
16:01ianbickingdcoates set it up, I think
16:01clouserwthat guy....
16:02clouserwj/k dcoates <3
16:02clouserwok, I flipped it to build everything
16:07GitHub[screenshots] ianb commented on issue #3125: I think I might have built the add-on incorrectly (without bootstrap.js), leading to the error in the console. That wouldn&#39;t explain the icon problem though.... https://git.io/vQ7No
16:09GitHub[screenshots] clouserw pushed 1 new commit to stable: https://git.io/vQ7Np
16:09GitHubscreenshots/stable e19b7a3 Wil Clouser: need a new build for ops
17:19thekyriarchyso just to determine if those shots are weird in a recoverable or non recoverable way?
17:19ianbickingthekyriarchy: if you visit one of your shots (e.g., find a URL from history) it should be fine
17:20thekyriarchyonly the ones that were spared after i realized i was overwriting them
17:20ianbickingthekyriarchy: if you can visit the broken one (probably the image wont load on the page) you could try to delete it
17:20thekyriarchyi don&#39;t want to lose my shots
17:20thekyriarchyi was looking for something in them and i refer back to them a lot
17:20ianbickingI also dont want you to lose your shots!
17:20_6a68ianbicking: it looks like your last push to try only included osx, but the ts_paint regressions were on windows, so you definitely want to include &#39;win32&#39; and &#39;win64&#39; in the push with the updated commit
17:21ianbicking_6a68: I was only thinking about the icon regression, but it might only be Windows anyway
17:21ianbickingso yeah
17:21_6a68also be sure you do 5 or 10 retries with talos, in case there&#39;s some intermittent error that breaks some of them
17:21thekyriarchydeleting them = losing them doesn&#39;t it?
17:22_6a68ianbicking: it also wouldn&#39;t hurt to roll back by one commit, and push your m-c base commit to Try with a ton of Talos retries, to be doubly sure
17:22_6a68it&#39;s nice to have a reference point with enough retries to be statistically reliable
17:29GitHub[screenshots] ianb created fix-null-clip (+1 new commit): https://git.io/vQ5I8
17:29GitHubscreenshots/fix-null-clip e0f4010 Ian Bicking: Fix #3131, do not let a shot without clips break My Shots
17:29GitHub[screenshots] ianb opened pull request #3133: Fix #3131, do not let a shot without clips break My Shots (master...fix-null-clip) https://git.io/vQ5IB
17:30ianbickingthekyriarchy: _6a68 ^^ that will fix the problem, but well have to get it deployed before it will actually help
17:30thekyriarchyokay cool
17:30thekyriarchythat was so fast!
17:30thekyriarchyi&#39;ll be able to see the weird shots again, too?
17:30ianbickingwell, you came to the source!
17:30ianbickingthat change will just cause the weird shot to be hidden
17:31ianbickingIm not sure when well do our next deploy either
17:31_6a68ianbicking: I&#39;m not sure how to test this, I guess I can just cross fingers and merge it
17:31_6a68or is the bug that revisiting the /creating link in history leads to a busted shots page
17:31ianbicking_6a68: yeah, I tested it locally by running some SQL to mess up a shot
17:31_6a68lol, ok
17:31ianbicking_6a68: I havent looked into the /creating thing
17:31GitHub[screenshots] 6a68 closed issue #3131: Error: TypeError: Cannot read property &#39;_image&#39; of null https://git.io/vQ7jP
17:32GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ5Io
17:32GitHubscreenshots/master 6be9d14 Elisa X: Pontoon: Update Spanish (es-MX) localization of Firefox Screenshots...
17:32_6a68the /creating thing is weird. shouldn&#39;t we be able to avoid creating a history entry for that page?
17:32ianbicking_6a68: I dont know, its a nuisance but Ive only thought about it a little
17:32thekyriarchyah, okay
17:32ianbicking_6a68: its not easy to remove something from history really
17:33_6a68hmm, it seems like we should be able to do somethign from bootstrap
17:33ianbickingbut it shouldnt break anything, the page itself doesnt do anything, its just a placeholder and the add-on manages everything else
17:33_6a68if not via the History API
17:33_6a68oh, interesting
17:33_6a68I haven&#39;t looked at that part of the server code, really
17:33GitHub[screenshots] 6a68 deleted fix-null-clip at e0f4010: https://git.io/vQ5IS
17:33ianbickingonce the add-on uploads, the add-on navigates you to the right page
17:34thekyriarchyshouldn&#39;t it just be impossible to overwrite/corrupt a clib or clips page by revisiting the create url?
17:34ianbicking_6a68: A more complete try build in progress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f81729b54d5f2c848a53bbef5b5c2060f94ad6a
17:34GitHub[screenshots] wresuolc commented on issue #3061: Hi, thanks for filing. It&#39;s best to keep issues filed separately so they are easy to work with. I&#39;ll comment inline on these though.... https://git.io/vQ5IF
17:34GitHub[screenshots] wresuolc closed issue #3061: Screenshots aren&#39;t very privacy friendly https://git.io/vQ3O5
17:34ianbickingthekyriarchy: it should be impossible right now, which is why Im confused what happened
17:35_6a68ianbicking: oh, don&#39;t use artifact builds! you should kill that and repush
17:35_6a68artifact builds can be weird
17:35ianbickingoh, yeah
17:35_6a68if you have artifact builds in your .mozconfig, you can pass --no-artifact
17:36ianbickingOK, second try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1dcbee16778de83508b3409fadacff41e968db3
17:38_6a68LGTM
17:38thekyriarchyianbicking: right now as in it used to be possible but was fixed, or was never possible?
17:41_6a68ianbicking: I canceled your earlier try jobs to shorten the queue a bit
17:41_6a68(you&#39;ll probably get an email about it)
17:43ianbickingthekyriarchy: I dont think it was ever possible, that page is really simple: https://github.com/mozilla-services/screenshots/blob/master/server/src/pages/creating/server.js
17:43ianbicking_6a68: cool, I wasnt sure how to cancel
17:44ianbicking_6a68: clouserw: we have an r+ on 10.5.0, but I think we should look at these Try builds before asking for checkin
17:44_6a68ianbicking: there&#39;s a little X icon in the treeherder build row, on the right side: https://irccloud.mozilla.com/file/pYU3ZjvD/Screen%20Shot%202017-07-14%20at%2010.44.09%20AM.png
17:44ianbicking_6a68: clouserw: and Im not sure what to do about the clipboard issue in our security patch, pauloiegasSV has been getting mixed reports about it working on Windows
17:45_6a68ianbicking: I&#39;m going to look at that now on my windows machine
17:45ianbickingawesome, thanks
17:45_6a68np
17:45cloudops-ansiblescreenshots-dev build #187: building mozilla/screenshots:latest
17:46cloudops-ansiblescreenshots-dev build #188: building mozilla/screenshots:latest
17:47clouserwthanks _6a68
17:47_6a68ianbicking: I agree, we should wait to request landing until the Try jobs are done (especially making sure ts_paint doesn&#39;t crash). we can set checkin-needed at any point and the sheriffs will find the commit, so we can wait till later today to set that
17:47clouserwianbicking: makes sense to me. maybe it&#39;s easier to just do 10.6 for uplift?
17:48clouserwer, s/uplift/landing/
17:48cloudops-ansiblescreenshots-dev build #188: deploy failed /cc relud
17:48cloudops-ansiblescreenshots-dev build #187: mozilla/screenshots:latest deployed to Dev
17:50thekyriarchyianbicking: huh, so what should happen when revisiting a /create/ url?
17:51ianbickingthekyriarchy: it should just show you the information from then, but not do anything or navigate away
17:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ5tM
17:51GitHubscreenshots/master fcf0787 Michael Khler: Pontoon: Update German (de) localization of Firefox Screenshots...
17:52_6a68ianbicking: what if you used window.history.replacestate here instead of pushstate? https://github.com/mozilla-services/screenshots/blob/master/server/src/pages/creating/controller.js#L9
17:53ianbicking_6a68: maybe?
17:58thekyriarchyon all the broken image clip pages, each time i view them it says &quot;[url] Just Now [expiration time] even though they&#39;re no longer create links
17:58thekyriarchy&quot;just now
17:58thekyriarchy&quot; is the creation time, but i didn&#39;t just create it
18:04cloudops-ansiblescreenshots-dev build #189: building mozilla/screenshots:latest
18:05GitHub[screenshots] 6a68 commented on issue #3132: @thekyriarchy Thanks for filing this bug! Sorry you ran into that issue. We&#39;ll look into a workaround to get your shots back.... https://git.io/vQ5mP
18:06_6a68thekyriarchy: could you paste one of the broken image clip page links into IRC here?
18:06* thekyriarchy is nervous not knowing what&#39;s inside
18:06thekyriarchycan i DM one? haha
18:07_6a68of course :-)
18:07cloudops-ansiblescreenshots-dev build #189: mozilla/screenshots:latest deployed to Dev
18:07_6a68I can also just try to reproduce the issue myself
18:07thekyriarchyah, yeah, would you mind? if you are unable i can send a link
18:07_6a68sure
18:11GitHub[screenshots] 6a68 commented on issue #3132: I&#39;m not able to reproduce this using Screenshots:... https://git.io/vQ5Yz
18:11_6a68thekyriarchy: which channel firefox do you generally use? the regular release channel, beta, or nightly?
18:12GitHub[screenshots] 6a68 commented on issue #3132: Doh! We graduated page shot, so I can&#39;t install the xpi any longer :-\... https://git.io/vQ5YS
18:12_6a68thekyriarchy: I ask because I can&#39;t repro this using Screenshots, and there is a migration path from Page Shot (the test pilot experiment) to Screenshots (same thing, but baked into Firefox)
18:12thekyriarchystable (i&#39;d use beta but no reliable repo for that on fedora)
18:13thekyriarchyand i use nightly on my phone
18:13_6a68oh, I see
18:13thekyriarchyis screenshots only in beta right now?
18:13_6a68yeah, it&#39;s targeting 55, which hits release later in the summer
18:13_6a68it&#39;s also in nightly
18:14_6a68I don&#39;t know that it&#39;ll fix your issue, because I don&#39;t know what the issue is...maybe not worth it
18:14_6a68nightly can be a bumpy ride compared to release
18:14_6a68and it&#39;s not generally a good idea to go from nightly back to release in the same profile, backwards-incompatible stuff like IndexedDB can cause profile corruption
18:14_6a68maybe ian has other ideas to recover your shots
18:14thekyriarchyok msg me and i can send a random broken url lol
18:14_6a68fwiw, I&#39;m really sorry this happened :-(
18:15_6a68sure, one sec
18:15ianbickingpageshot.net uses the same code as screenshots.firefox.com, so when we next update the fix should get applied there too
18:15_6a68thekyriarchy: you could try screenshotting something right now, then revisit the creating page, to break a known image
18:20thekyriarchyhm, i guess something has changed since it isn&#39;t doing it anymore but i can send an old mystery link
18:27GitHub[screenshots] 6a68 commented on issue #3132: Interestingly, on one of the affected pages, the `.clip-container` element is missing.... https://git.io/vQ5sk
18:28_6a68thekyriarchy: oh, so you can&#39;t reproduce this bug any longer? do you remember what specific steps you took to create the bug to begin with?
18:29thekyriarchyi am following the same steps to my knowledge, digging in history, clicking the create link, and then getting an image-less page
18:29thekyriarchyi wonder if it&#39;s domain-specific
18:29thekyriarchythat wouldn&#39;t make sense, would it?
18:31_6a68seems unlikely. is it possible some of those old images had expired? do you generally set the expiry time to &#39;indefinitely&#39;?
18:32ianbickingthe problem is in the JSON, not any of the images, so that shouldnt be it
18:32ianbickingthis might be a PageShot-specific problem, where theres something racy so that the shot can be uploaded before the image is captured, and so an imageless shot gets uploaded, which breaks things
18:34thekyriarchyjust tested on some expried images, doesn&#39;t reproduce the issue
18:34thekyriarchybut these ones were almost definitely set to never expire
18:35thekyriarchyno way to look up the files from the url i sent?
18:35thekyriarchyalso, i just found this for moving to beta https://eischmann.wordpress.com/2017/02/15/nightly-and-wayland-builds-of-firefox-for-flatpak/
18:36ianbickingwe dont have direct access to the database (privacy, security), so we cant actually investigate the data directly
18:36thekyriarchyah, that makes sense
18:37thekyriarchyhow are &quot;my shots&quot; saved? do they sync to my firefox account? would the beta channel through flatpak be able to import them?
18:39ianbickingthekyriarchy: the shots are associated with your browser instance, and that isnt syncd through your Firefox Account (though well be adding that option soonish). If you use a Firefox version with Screenshots (Firefox 55) then Screenshots will take your Page Shot account and use that (and after that its important not to use Page Shot again, things
18:39ianbickingmight get weird)
18:40_6a68so right now, that&#39;d either mean beta or nightly, and you might break stuff if you went back to release channel on the same profile
18:40ianbickingit should uninstall Page Shot, even after you go back to release
18:42_6a68right, I was thinking about indexeddb backwards incompatibilities between 55 and 53, I think I saw something about this on dev-platform
18:42ianbickingluckily the authentication is stored somewhere more naive
18:43thekyriarchyi would probably just stick with beta forever haha
18:43_6a68yeah, this is the bug https://bugzilla.mozilla.org/show_bug.cgi?id=1339081
18:43firebotBug 1339081 FIXED, jvarga@mozilla.com QuotaManager: Upgrade storage from 1.0 to 2.0
18:44_6a68and here&#39;s the relevant thread https://groups.google.com/d/topic/mozilla.dev.platform/wt1Jzzd6GdI/discussion
18:44thekyriarchyunrelatedly, was there ever a bug filed/fixed for realllllly long pages that pageshot juts cuts off after a certain length?
18:44thekyriarchyin some circumstances like that i was forced to install other plugins
18:45ianbickingthere is a bug for that, yeah
18:50GitHub[screenshots] thekyriarchy commented on issue #220: It would be nice to let the user choose the format, but perhaps default to an automatic mode that decides what formats are best for what sizes. There are some screenshot tools that can save to SVG, but that&#39;s probably overkill as much as i&#39;d enjoy it https://git.io/vQ5n5
18:59GitHub[screenshots] thekyriarchy commented on issue #2007: What content is missing on Facebook? I&#39;ve noticed the navigation bar will be saved multiple times over a page as the tool scrolls down, which should be fixed. As a workaround to that, I always have to delete the element on my end, but i have no idea what&#39;s going on with the 9gag page https://git.io/vQ5cM
18:59GitHub[screenshots] thekyriarchy commented on issue #1832: So this bug is about the timing of loading not waiting for a complete render? https://git.io/vQ5cD
18:59GitHub[screenshots] thekyriarchy commented on issue #2129: What&#39;s the reason for the limit? Could users at least change a setting to lift it? ... https://git.io/vQ5cy
19:01GitHub[screenshots] thekyriarchy commented on issue #3132: it may have been a problem with an earlier version, as i can no longer reproduce, but my corrupted shots are all still missing. https://git.io/vQ5Ct
19:02thekyriarchysorry for gh spam
19:04_6a68thekyriarchy: no worries! contributor input is always welcome :-)
19:07GitHub[screenshots] 6a68 commented on issue #3130: Hmm.... https://git.io/vQ5C5
19:07clouserwianbicking: can you confirm that https://github.com/mozilla-services/screenshots/blob/master/docs/METRICS.md#opt-out is still accurate?
19:08GitHub[screenshots] ianb commented on issue #3130: I just tested on Windows, with the patched XPI, and it worked for me. I was using Nightly 2017-07-03 (but it looks like I should try with Beta) https://git.io/vQ5Wk
19:09_6a68thekyriarchy: btw, if you want to fix a bug while you&#39;re here...https://github.com/mozilla-services/screenshots/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+bug%22
19:09_6a68;-)
19:09_6a68pull requests welcome
19:09ianbicking_6a68: you tested the icons on 10.5.0 and they seemed okay? If so I want to request autoland
19:09thekyriarchynice tag! any affiliation with openhatch?
19:10thekyriarchyunfortunately the last time i touched code was an intro to CS course half a decade ago
19:12_6a68whoa! I didn&#39;t know openhatch was a thing, that&#39;s awesome
19:13_6a68if you want to get back into hacking, we can guide you through any of those good first bugs as a starting point :-)
19:13_6a68of course, no pressure ^_^
19:15GitHub[screenshots] 6a68 commented on issue #3130: I just retried in beta and nightly, and couldn&#39;t repro the bug on either. Maybe it only affects a fresh profile? (How could that be?) https://git.io/vQ5l8
19:19thekyriarchy_6a68: i do, as soon as i finish school (aug 20th) but i also sort of had my heart set on learning haskell
19:20GitHub[screenshots] ianb commented on issue #3130: I just tried on latest Nightly and Beta (Windows) and it also worked. That said, some but not all SoftVision testers have reliably reproduced this. https://git.io/vQ58e
19:20ianbicking_6a68: clouserw: should we go ahead with 10.6.0 given https://github.com/mozilla-services/screenshots/issues/3130 ?
19:21ianbicking_6a68: also, were icons all working on 10.5.0 ? Did we need to test on beta?
19:21_6a68The icons seemed fine to me, I didn&#39;t notice any weirdness
19:22clouserwianbicking: can we suppress the &quot;link copied&quot; popup if the link doesn&#39;t actually get copied?
19:22GitHub[screenshots] 6a68 commented on issue #3130: I just retried in beta and nightly on windows 10, and couldn&#39;t repro the bug on either. Maybe it only affects a fresh profile? (How could that be?) https://git.io/vQ5l8
19:22ianbickingcheckin-needed added: https://bugzilla.mozilla.org/show_bug.cgi?id=1380817
19:22firebotBug 1380817 NEW, ianb@mozilla.com Update Screenshots to version 10.5.0
19:22ianbickingclouserw: we do, except in this case it always reports the copy succeeds
19:23ianbickingin theory we should be getting exception reports when the copy fails, but Ive never seen one in Sentry
19:23_6a68we can detect if the copy fails by checking if `doc.defaultView.getSelection().toString()` is empty
19:23clouserwyeah, can we check if its empty?
19:23ianbicking_6a68: that just tests the selection though?
19:23_6a68 synergy
19:24ianbicking_6a68: the selection might succeed, but nothing gets into the clipboard
19:24_6a68ianbicking: yup, but the selection is empty when the bug occurs
19:24ianbickingoh, huh
19:24ianbicking_6a68: is that the real bug?
19:24ianbickingi.e., the copy succeeds, but nothing was selected?
19:25_6a68maybe? see my comment in the bug though - el.value looks correct, el.select() doesn&#39;t throw (idk if it would though), but the selection is empty after the execCommand
19:25ianbicking_6a68: did you notice the the textarea was empty, or it wasnt selected?
19:25_6a68kinda seems like a browser bug tbh
19:25_6a68the textarea&#39;s value was the URL
19:26_6a68I didn&#39;t see it in the page to tell if it was selected or not
19:26_6a68I guess we could add an el.focus()?
19:26ianbickingOK youd have to get rid of the teardown code to see
19:26* _6a68 tries to remember arcane DOM APIs
19:26ianbickingwe could, seems very random
19:26ianbickingI wonder if the previous selection or focus affects this?
19:27_6a68maybe? like, the urlbar does grab the focus when a new tab is opened
19:27_6a68but none of this explains why it would suddenly affect beta
19:27_6a68one possibility is that execCommand(&#39;copy&#39;) needs to be in response to a click event, but that doesnt explain why it returns true
19:28ianbickingin theory we have a permission on our webextension that allows us to call that outside a click event
19:28ianbickingI tried messing with focus and selection and it didnt seem to matter
19:29_6a68when I was able to repro the copy bug on shot creation, copying the URL via the share panel &#39;copy&#39; button worked
19:29ianbickingwe do appear to kill the default focus, which is a bit lame of us, but eh
19:30_6a68maybe we should ask SV to repro on earlier betas / try to find a regression window
19:30_6a68this might be a legit browser bug, seems odd that it would crop up this late in the beta cycle
19:30ianbickingPaul was trying a few things, didnt get a repro, but also was pinging other people who were still able to repro
19:30_6a68I guess a bug with webextension execCommand permissions might be more likely, considering that code is changing a lot lately
19:31ianbickingpage interaction also seems possible
19:31ianbickingwell, Im going to put together 10.6.0 anyway
19:33clouserwmaking 10.6.0 anyway is the right thing
19:33clouserwI don&#39;t mean to distract, but did you see my question about our opt-out docs? ^
19:34GitHub[screenshots] 6a68 force-pushed localize-server from f5938db to e97dcb1: https://git.io/v9m2x
19:34GitHubscreenshots/localize-server e97dcb1 Jared Hirsch: localize server...
19:34* clouserw is trying to get ahead of that before it blows up
19:34GitHub[screenshots] dveditz commented on issue #3120: Clearly it would be important to remind users they&#39;re in private mode in case they forgot, but I hope that the functionality is eventually restored. Even the server upload could be appropriate for some use cases: say I&#39;m shopping for rings and don&#39;t want local traces, but want to share a screenshot to get advice. Random link, no history in private mode, and delete the server copy after and it&#39;s
19:50GitHub[screenshots] ianb created iframe-tests (+2 new commits): https://git.io/vQ50j
19:50GitHubscreenshots/iframe-tests 173eda1 Greg Guthe: Validate iframe URLs...
19:50GitHubscreenshots/iframe-tests 0d470b0 Ian Bicking: Put temporary clipboard TEXTAREA in an iframe...
19:51GitHub[screenshots] ianb opened pull request #3134: Iframe tests (v10.4.0-export...iframe-tests) https://git.io/vQ5Et
19:57557A74ERY[screenshots] 6a68 pushed 1 new commit to v10.4.0-export: https://git.io/vQ5uY
19:57557A74ERYscreenshots/v10.4.0-export 5b4609f Ian Bicking: Iframe tests (#3134)...
19:57GitHub[screenshots] 6a68 closed pull request #3134: Iframe tests (v10.4.0-export...iframe-tests) https://git.io/vQ5Et
19:57GitHub[screenshots] 6a68 deleted iframe-tests at 0d470b0: https://git.io/vQ5uO
20:10GitHub[screenshots] ianb pushed 1 new commit to v10.4.0-export: https://git.io/vQ5gU
20:10GitHubscreenshots/v10.4.0-export 9525870 Ian Bicking: Update version to 10.6.0 with changelog
20:10GitHub[screenshots] ianb tagged 10.6.0 at v10.4.0-export: https://git.io/vQ5gT
20:47GitHub[screenshots] wresuolc opened issue #3135: Update screenshots Privacy Notice https://git.io/vQ5wW
21:07GitHub[screenshots] 6a68 commented on issue #3097: I tried adding some console.logs to the start and end of catcher.js and ui.js.... https://git.io/vQ5oX
21:08GitHub[screenshots] 6a68 commented on issue #3097: I tried adding some console.logs to the start and end of catcher.js and ui.js.... https://git.io/vQ5oX
21:09ianbicking_6a68: if you have a chance to check that I got this export right too https://reviewboard.mozilla.org/r/157486/diff/1#index_header
21:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQ5KI
21:11GitHubscreenshots/master ee9b1ee Hvar Henriksen: Pontoon: Update Norwegian Bokml (nb-NO) localization of Firefox Screenshots...
21:15_6a68ianbicking: looks good to me. that was just the iframe PR, right?
21:17GitHub[screenshots] 6a68 commented on issue #3097: The simplest fix here might be to concat all the lazy-loaded scripts in our build process https://git.io/vQ5KF
21:20GitHub[screenshots] ianb commented on issue #3097: If different files are being loaded in non-deterministic order, I can only imagine that&#39;s because selectorLoader.loadModules is running multiple times and the loads are interleaved. I think we could just block loadModules so it can&#39;t be run more than once at a time (taking into account it&#39;s an async function). https://git.io/vQ56k
21:25cloudops-ansiblescreenshots-dev build #190: building mozilla/screenshots:latest
21:27cloudops-ansiblescreenshots-dev build #190: mozilla/screenshots:latest deployed to Dev
21:36ianbickingalright, Im heading out. _6a68 and clouserw: Ill leave it to you to shepherd 10.6.0 into beta!
21:36_6a68cool, I&#39;m sure it&#39;ll go fine
21:36* clouserw knocks on wood
21:36clouserwthanks ianbicking
21:37_6a68Ianbicking did you kick off talos runs for 10.6?
21:37* _6a68 indulges in extreme paranoia
21:37_6a68I can kick off a run if needed, probably wont be necessary
21:38ianbickingoh sure, it is so kicked: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9368759158608927700033a1e818ab5166320209
21:38_6a68sweet! thx
21:39ianbickingnothing can go wrong now, everythings coming up Milhouse
21:44_6a68lol
23:06clouserw_6a68: will autoland pull in that r+&#39;d patch or do we need to do anything else for it?
23:06clouserw(re: https://bugzilla.mozilla.org/show_bug.cgi?id=1381132 )
23:06firebotBug 1381132 NEW, ianb@mozilla.com Update Screenshots to version 10.6.0
23:06_6a68hmm, I think we will need to ask the sheriffs to land it
23:07_6a68I think you need level 3 access for autoland to, uh, autoland your commits
23:09_6a68the test results look ok so far, but Talos tests for windows haven&#39;t run yet
23:11clouserwah, that makes sense
15 Jul 2017
No messages
   
Last message: 6 days and 12 hours ago