mozilla :: #screenshots

13 Jul 2017
02:44GitHub[screenshots] flodolo commented on issue #3068: > @ianb OK, I think this is fully baked. Mind taking a last look before landing?... https://git.io/vQ9GC
03:56GitHub[screenshots] niharikak101 created preview-animations (+1 new commit): https://git.io/vQ9cj
03:56GitHubscreenshots/preview-animations c541637 Niharika Khanna: shot preview animation changes
03:57GitHub[screenshots] niharikak101 opened pull request #3118: shot preview animation changes (master...preview-animations) https://git.io/vQ9Cv
04:20GitHub[screenshots] niharikak101 commented on issue #3080: @youwenliang We are removing the shots associated with the account that don't belong to the device which the user disconnects from the account, but keeping the shots that were taken from that specefic device/profile. Essentially, when a user disconnects they can't access the shots that were taken from other devices associated with the account.... https://git.io/vQ9Cp
10:05GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3100: By ? Was this fixed ? Doesn't looks like on Nightly with "Compact Dark" theme. https://git.io/vQ9Mp
10:05GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3100: By? Was this fixed? Doesn't looks like on Nightly with "Compact Dark" theme. https://git.io/vQ9Mp
14:56GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3100: By? Was this fixed? Doesn't looks like on Nightly with "Compact Dark" theme.... https://git.io/vQ9Mp
14:56GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3100: By? Was this fixed? Doesn't looks like on Nightly with "Compact Dark" theme.... https://git.io/vQ9Mp
14:58GitHub[screenshots] SoftVision-PaulOiegas commented on issue #3100: By? Was this fixed? Doesn't looks like on Nightly with "Compact Dark" theme.... https://git.io/vQ9Mp
15:03GitHub[screenshots] ianb opened issue #3119: Fix bug 1380616 https://git.io/vQHnP
15:03firebotBug https://bugzil.la/1380616 is not accessible
15:16GitHub[screenshots] 6a68 commented on issue #3068: @flodolo Thanks for catching that comment while on PTO! I'll coordinate with @mathjazz before landing https://git.io/vQHWn
15:43ianbickingI have to run, be back in a bit
17:32jgruenianbicking: you're gonna miss the fun
17:32_6a68ianbicking: where you at thug
17:39_6a68https://hg.mozilla.org/releases/mozilla-beta/
17:39_6a68svg bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1379464
17:39firebotBug 1379464 FIXED, jaws@mozilla.com Enable context paint for moz-extension:// images
17:47_6a68https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=73ffdc1b8c09e0ca55050703d96f06209205f3cb&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
17:49GitHub[screenshots] wresuolc commented on issue #2818: Let's just disable ourselves completely in private browsing mode https://git.io/vQHD8
17:50_6a68https://github.com/mozilla-services/screenshots/pull/3079
17:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQHDa
17:51GitHubscreenshots/master fe00be7 Ton: Pontoon: Update Dutch (nl) localization of Firefox Screenshots...
17:54_6a68https://hg.mozilla.org/mozilla-central/rev/73ffdc1b8c09#l1.12
18:03GitHub[screenshots] 6a68 opened issue #3120: Disable in private browsing mode https://git.io/vQHSa
18:05cloudops-ansiblescreenshots-dev build #150: building mozilla/screenshots:latest
18:06GitHub[screenshots] ianb opened issue #3121: Make 10.5.0 release https://git.io/vQHS7
18:08cloudops-ansiblescreenshots-dev build #150: mozilla/screenshots:latest deployed to Dev
18:13_6a68fsevents is a nonstop source of npm install drama
18:14_6a68sweet sweet irony that installation fails on a missing dependency called "dezalgo"
18:14_6a68ianbicking: are you able to npm install on npm5 on master right now?
18:15* _6a68 force-cleans npm cache to try again
18:15ianbicking_6a68: seems to work fine for me
18:16_6a68so weird. twice in a row, I got "npm ERR! enoent ENOENT: no such file or directory, rename '/Users/jhirsch/codez/github/mozilla-services-screenshots/node_modules/.staging/dezalgo-0d75078b' -> '/Users/jhirsch/codez/github/mozilla-services-screenshots/node_modules/npm/node_modules/dezalgo'"
18:16ianbickingbad symlink or something?
18:17_6a68I have no idea. `npm clear cache --force` seems to have fixed it
18:17_6a68npm 5 seems to bump into a lot of these issues
18:20_6a68ianbicking: hmm, I see the error again when I ./bin/run-addon --bootstrap
18:21ianbickingI think its a terrible name for file not found, right?
18:21ianbickingENOENT that is
18:21_6a68heh
18:22_6a68interestingly, without node_modules present, I get another error, "Cannot find module 'raven-js/dist/raven.js'"
18:22ianbickingfinding that module is part of the build step
18:23_6a68for some reason, I thought npm install was part of the run-addon step
18:24ianbickingit is, maybe its not in the right order though?
18:24ianbickingits part of the Makefile
18:24jgruen_6a68: i had to nuke my modules recently
18:25jgruenfor no clear reason
18:25_6a68ianbicking: all this happened when I switched back to npm 5 in order to regenerate the shrinkwrap file as part of finishing the l10n patch
18:25_6a68npm 5 feels PHP-ish in terms of just terrible quality
18:30_6a68jgruen: yeah, that and "npm cache clear --force" have become part of my workflow
18:31_6a68huh. worked on the third try, for no clear reason
18:37GitHub[screenshots] 6a68 commented on issue #3120: turns out incognito manifest key does nothing https://git.io/vQHdQ
18:41GitHub[screenshots] 6a68 commented on issue #3120: lol, browser compatibility table here shows that 'incognito' is not yet supported by firefox https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/incognito... https://git.io/vQHFx
18:50GitHub[screenshots] 6a68 commented on issue #3091: We can get this data from bootstrap. Based on the discussion in https://bugzil.la/988725, looks like Firefox exposes `Services.appinfo.defaultUpdateChannel` ('nightly', 'aurora', 'esr', and 'release'), and `Services.appinfo.version`, which is currently `53.0.3` on release, a little more detailed than the `53.0` provided by `navigator.userAgent`.... https://git.io/vQHNZ
18:50firebotBug 988725 WONTFIX, nobody@mozilla.org Override Firefox UA on *.mozilla.org to include the real version and channel
18:52GitHub[screenshots] 6a68 commented on issue #3120: aha! `tab.incognito` tells us https://git.io/vQHNK
19:01GitHub[screenshots] 6a68 commented on issue #3120: @johngruen Turns out the 'incognito' manifest key only works on chrome, for now.... https://git.io/vQHAH
19:06ianbickingugh, I dont think document.execCommand(copy) works inside an iframe (it appears to work, but doesnt, Im assuming its being silently blocked?)
19:08ianbickingoh wait, just not hidden iframes
19:08ianbickingphew
19:15jgruen_6a68: i'm not sure how we get away with the incognito mode thing w/o a string
19:16jgruenif we push to dev today we can get good coverage through the weekend
19:21GitHub[screenshots] johngruen commented on issue #3097: Ritu mentioned this in the release drivers email list:... https://git.io/vQHhD
19:21GitHub[screenshots] johngruen commented on issue #3097: Ritu mentioned this in the release drivers email list:... https://git.io/vQHhD
19:21GitHub[screenshots] johngruen commented on issue #3097: Ritu mentioned this in the release drivers email list:... https://git.io/vQHhD
19:25GitHub[screenshots] johngruen commented on issue #3120: @_6a68 I don't see how we do this w/o a string...... https://git.io/vQHjt
19:29GitHub[screenshots] johngruen commented on issue #3120: @_6a68 I don't see how we do this w/o a string...... https://git.io/vQHjt
19:41GitHub[screenshots] 6a68 commented on issue #3120: :+1:... https://git.io/vQQff
19:55GitHub[screenshots] ianb commented on issue #3120: Hmm... we haven't updated strings yet in 10.x.0. To get strings in we'll need to figure out how to cherry-pick them all out, or maybe just export this one string? https://git.io/vQQJF
19:56GitHub[screenshots] 6a68 created 3120-disable-private-mode (+1 new commit): https://git.io/vQQJp
19:56GitHubscreenshots/3120-disable-private-mode aefc639 Jared Hirsch: Fix #3120, disable Screenshots in private windows
19:56GitHub[screenshots] 6a68 opened pull request #3122: Fix #3120, disable Screenshots in private windows (master...3120-disable-private-mode) https://git.io/vQQUq
19:58GitHub[screenshots] 6a68 commented on issue #3120: I'll add a list of strings and dates to #3121 and we can see which ones need to land https://git.io/vQQU2
19:58Seburojgruen: Hi. Just heard that screenshots is going to be disabled by private browsing. I guess I will need to do a small edit to the SUMO article. Planning just to make it a one liner, but is there anything else I need to include?
19:58jgruenSeburo: man, you're on top of things!
19:58jgruenno, a one liner should do it
19:58jgruenthanks
20:00Seburojgruen: So just to check the language, screenshots will not be available in private browsing, or will it not work in private browsing?
20:05GitHub[screenshots] 6a68 commented on issue #3121: Looks like we haven't had too many string changes in version 10:... https://git.io/vQQkv
20:07_6a68Seburo: the button will be there, but an error will be shown if the button (or context menu item) is clicked
20:07_6a68I guess it will be available but will not work
20:07Seburo_6a68: Ok. Is this a bug or a feature change?
20:08_6a68Probably a bug, since people were surprised to see screenshot downloads from private mode mixed in with regular downloads
20:09Seburo_6a68: Ok, thanks. Will get an edit done to the SUMO article asap.
20:09_6a68awesome! thank you :-)
20:10GitHub[screenshots] pierreneter commented on issue #2818: Why do we have to disable it in incognito mode? I think we should leave it in the download of incognito mode... https://git.io/vQQki
20:10GitHub[screenshots] 6a68 commented on issue #3121: Looks like we haven't had too many string changes in version 10:... https://git.io/vQQkv
20:13GitHub[screenshots] 6a68 commented on issue #2818: @pierreneter Thanks for the feedback. If you save to the cloud, private and non-private screenshots would be mixed. Ditto for downloads. We don't have time to make significant changes for Firefox 55, so this is the best we can come up with. Hopefully we can make private browsing work for a future version https://git.io/vQQIv
20:17GitHub[screenshots] johngruen commented on issue #2818: @6a68 i think the long term solution here is to ONLY allow download in private browsing. The difficulty is managing downloads in the correct context. I may have read the docs for werExt incorrectly, but it seems like we'd need the `"incognito": "split"` api implemented https://git.io/vQQIR
20:20GitHub[screenshots] ianb closed pull request #3122: Fix #3120, disable Screenshots in private windows (master...3120-disable-private-mode) https://git.io/vQQUq
20:20203A9V6GH[screenshots] ianb closed issue #3120: Disable in private browsing mode https://git.io/vQHSa
20:20GitHub[screenshots] johngruen commented on issue #2818: https://bugzilla.mozilla.org/show_bug.cgi?id=1345474 https://git.io/vQQIh
20:20firebotBug 1345474 NEW, nobody@mozilla.org Support incognito permission "not_allowed"
20:21ianbicking_6a68: jgruen: so, re: 10.5.0, I feel like I should make a release, and our new string wont be translated at all
20:21ianbickingand well just follow up
20:22_6a68cool, is there another beta after tuesday's? I bet uplifting strings wouldn't be a big deal
20:22_6a68ianbicking: note that the terms and privacy string change wasn't yet exported though
20:22_6a68we really need to get that in
20:23ianbicking_6a68: I swear that went in?
20:23ianbickingmaybe backdoored?
20:24_6a68ianbicking: oh right! we didn't update the ID, but we did update the string https://dxr.mozilla.org/mozilla-central/source/browser/extensions/screenshots/webextension/_locales/en_US/messages.json#110
20:24_6a68I knew I would forget that we had done that...
20:24GitHub[screenshots] 6a68 commented on issue #3121: Looks like we haven't had too many string changes in version 10:... https://git.io/vQQkv
20:24_6a68So that only leaves the private browsing mode warning
20:27GitHub[screenshots] 6a68 closed pull request #3113: Deploy to stage when merging to stable (master...deploy-to-stage) https://git.io/vQSBr
20:27GitHub[screenshots] 6a68 pushed 1 new commit to master: https://git.io/vQQtf
20:27GitHubscreenshots/master 7d0d112 Ian Bicking: Deploy to stage when merging to stable (#3113)
20:27GitHub[screenshots] 6a68 deleted deploy-to-stage at 2dfacd3: https://git.io/vQQtJ
20:28jgruen_6a68: you gotta update the ids brosnef
20:28jgruenalso ianbicking i'm fine with that
20:28_6a68jgruen: I think we decided it was good enough to update the terms string in english, and catch the other languages in some followup commit
20:28_6a68er, some followup release
20:28jgruenre tagging 1.5 without l10n
20:30jgruenianbicking: beta 10 is not the last uplift
20:34cloudops-ansiblescreenshots-dev build #151: building mozilla/screenshots:latest
20:37cloudops-ansiblescreenshots-dev build #151: mozilla/screenshots:latest deployed to Dev
20:40jgruenFWIW, there's a calendar on rapid release that shows when all of the betas are
20:40jgruenhttps://screenshots.firefox.com/QsXBO4E9rWgCht3r/wiki.mozilla.org
20:40cloudops-ansiblescreenshots-dev build #152: building mozilla/screenshots:latest
20:41jgruenwe have some time if we want to do l10n out of band with 10.5
20:41_6a68cool
20:43cloudops-ansiblescreenshots-dev build #152: mozilla/screenshots:latest deployed to Dev
20:55GitHub[screenshots] johngruen commented on issue #2818: https://bugzilla.mozilla.org/show_bug.cgi?id=1345474 https://git.io/vQQIh
20:55firebotBug 1345474 NEW, nobody@mozilla.org Support incognito permission "not_allowed"
20:55GitHub[screenshots] johngruen commented on issue #2818: Filed a tracking bug for the full webExtension implementation here: https://bugzilla.mozilla.org/show_bug.cgi?id=1380809 https://git.io/vQQOW
20:55firebotBug 1380809 NEW, nobody@mozilla.org Fully Support Incognito Key In WebExtensions
21:02GitHub[screenshots] ianb commented on issue #3099: Well, that didn't go so well, trying again with 10.5.0 in #3121 https://git.io/vQQ3R
21:03GitHub[screenshots] 6a68 created 3091-get-channel-info (+1 new commit): https://git.io/vQQ32
21:03GitHubscreenshots/3091-get-channel-info 32d4f27 Jared Hirsch: Fetch update channel info as part of deviceInfo
21:05GitHub[screenshots] 6a68 commented on issue #3091: @johngruen How do you want to pass the channel to GA? Is there a specific key you'd like to add? https://git.io/vQQ35
21:05Seburo_6a68: jgruen: The edit to the SUMO article has been debated, reviewed and is live. :-)
21:06GitHub[screenshots] ianb pushed 3 new commits to v10.4.0-export: https://git.io/vQQsT
21:06GitHubscreenshots/v10.4.0-export cf3788d Ian Bicking: Fix Bug 1373614, stop the embedded WebExtension unconditionally...
21:06GitHubscreenshots/v10.4.0-export 450dad1 Jared Hirsch: Fix #3120, disable Screenshots in private windows
21:06GitHubscreenshots/v10.4.0-export efb41d0 Ian Bicking: Update version to 10.5.0 with changelog
21:06GitHub[screenshots] ianb tagged 10.5.0 at v10.4.0-export: https://git.io/vQQsI
21:06firebothttps://bugzil.la/1373614 FIXED, ianb@mozilla.com Massive memory leak in Screenshot web extension when Firefox gets shutdown too quickly after startup
21:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQsM
21:11GitHubscreenshots/master 3c6eb6d Michael Wolf: Pontoon: Update Sorbian, Lower (dsb) localization of Firefox Screenshots...
21:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQsD
21:11GitHubscreenshots/master 3a13642 Michael Wolf: Pontoon: Update Sorbian, Upper (hsb) localization of Firefox Screenshots...
21:11GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQsy
21:11GitHubscreenshots/master 6dfbfce jlG: Pontoon: Update Spanish (es-ES) localization of Firefox Screenshots...
21:11ianbickingUpper Sorbian delivers again!
21:20GitHub[screenshots] Caspy7 commented on issue #3120: Why do we need to disable in private mode? We're only sending back data if the user interacts with it, no?... https://git.io/vQQn9
21:24cloudops-ansiblescreenshots-dev build #153: building mozilla/screenshots:latest
21:25cloudops-ansiblescreenshots-dev build #154: building mozilla/screenshots:latest
21:25cloudops-ansiblescreenshots-dev build #154: deploy failed /cc relud
21:27GitHub[screenshots] ianb commented on issue #3121: Happening in [Bug 1380817](https://bugzilla.mozilla.org/show_bug.cgi?id=1380817) https://git.io/vQQCU
21:27cloudops-ansiblescreenshots-dev build #155: building mozilla/screenshots:latest
21:27firebotBug 1380817 NEW, nobody@mozilla.org Update Screenshots to version 10.5.0
21:27cloudops-ansiblescreenshots-dev build #153: mozilla/screenshots:latest deployed to Dev
21:28GitHub[screenshots] Caspy7 commented on issue #3120: I have read the comments in issue #2818 and believe I understand that this may not be a permanent change, but is to protect privacy until a better mitigation is implemented. https://git.io/vQQCg
21:29cloudops-ansiblescreenshots-dev build #155: mozilla/screenshots:latest deployed to Dev
21:29ianbicking10.5.0 bug is filed with patch: https://bugzilla.mozilla.org/show_bug.cgi?id=1380817
21:31jgruenianbicking: \o/
21:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQWB
21:31GitHubscreenshots/master 40fe687 jlG: Pontoon: Update Spanish (es-ES) localization of Firefox Screenshots...
21:35ianbickingIm heading out. _6a68 / clouserw if you notice any activity today on 10.5.0 before you are out, can you follow up?
21:41* clouserw is nervous that 10.5.0 didn't go through QA
21:42jgruenclouserw: paul is working QA for screenshots for the next few days while paul is out
21:42jgruenwe could ping him
21:45cloudops-ansiblescreenshots-dev build #156: building mozilla/screenshots:latest
21:47cloudops-ansiblescreenshots-dev build #156: mozilla/screenshots:latest deployed to Dev
21:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQBG
21:51GitHubscreenshots/master 683ac15 Marco Aurlio: Pontoon: Update Portuguese (pt-BR) localization of Firefox Screenshots...
22:09cloudops-ansiblescreenshots-dev build #157: building mozilla/screenshots:latest
22:11cloudops-ansiblescreenshots-dev build #157: mozilla/screenshots:latest deployed to Dev
22:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQze
22:31GitHubscreenshots/master d1521e4 Rodrigo: Pontoon: Update Portuguese (pt-PT) localization of Firefox Screenshots...
22:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQzv
22:31GitHubscreenshots/master 410bb5c Andreas Pettersson: Pontoon: Update Swedish (sv-SE) localization of Firefox Screenshots...
22:40_6a68looks like the 10.5.0 windows 32 talos run went fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cc44305dea57c893d5b734f1e01b926630a8c6b
22:40_6a68although the OSX build failed for some weird reason. I restarted that build
22:50GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQgQ
22:50GitHubscreenshots/master 8717897 Ton: Pontoon: Update Dutch (nl) localization of Firefox Screenshots...
23:09cloudops-ansiblescreenshots-dev build #158: building mozilla/screenshots:latest
23:09cloudops-ansiblescreenshots-dev build #159: building mozilla/screenshots:latest
23:10cloudops-ansiblescreenshots-dev build #159: deploy failed /cc relud
23:10GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQad
23:10GitHubscreenshots/master dce9744 ravmn: Pontoon: Update Spanish (es-CL) localization of Firefox Screenshots...
23:11cloudops-ansiblescreenshots-dev build #158: mozilla/screenshots:latest deployed to Dev
23:13cloudops-ansiblescreenshots-dev build #160: building mozilla/screenshots:latest
23:15cloudops-ansiblescreenshots-dev build #160: mozilla/screenshots:latest deployed to Dev
23:23cloudops-ansiblescreenshots-dev build #161: building mozilla/screenshots:latest
23:25cloudops-ansiblescreenshots-dev build #161: mozilla/screenshots:latest deployed to Dev
23:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQwz
23:31GitHubscreenshots/master d6107fb Georgianizator: Pontoon: Update Georgian (ka) localization of Firefox Screenshots...
23:31GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQwg
23:31GitHubscreenshots/master 5f244b1 manxmensch: Pontoon: Update Malay (ms) localization of Firefox Screenshots...
23:44_6a68Looks like inbound and autoland are closed because of OSX breakage, so it's not us
23:45cloudops-ansiblescreenshots-dev build #162: building mozilla/screenshots:latest
23:46cloudops-ansiblescreenshots-dev build #163: building mozilla/screenshots:latest
23:47cloudops-ansiblescreenshots-dev build #163: deploy failed /cc relud
23:47cloudops-ansiblescreenshots-dev build #162: mozilla/screenshots:latest deployed to Dev
23:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQo0
23:51GitHubscreenshots/master 3b71344 Georgianizator: Pontoon: Update Georgian (ka) localization of Firefox Screenshots...
23:51GitHub[screenshots] mozilla-pontoon pushed 1 new commit to master: https://git.io/vQQoE
23:51GitHubscreenshots/master ddfc6ad manxmensch: Pontoon: Update Malay (ms) localization of Firefox Screenshots...
14 Jul 2017
No messages
   
Last message: 70 days and 8 hours ago