mozilla :: #perfherder

20 Apr 2017
19:32ShrutiJwlach: Hi! For bug 1352398, should I change https://github.com/mozilla/treeherder/blob/master/ui/partials/perf/bugzilla_talos.tmpl too?
19:32firebothttps://bugzil.la/1352398 NEW, shrutijasoria1996@gmail.com use raw link to revisions instead of a revision number in the talos regression template
19:33wlachShrutiJ: that file should actually be removed, since it's not used for anything
19:33ShrutiJAlso, I think that I am using getPushLogHref correctly as the link in console output seems to be correct. But the changes are not being reflected when I try to file a bug,
19:33ShrutiJShould I remove it?
19:34wlachShrutiJ: I would create a seperate PR for it, but yeah, I'd say remove it
19:34wlachShrutiJ: hmm how do you mean the changes are not being reflected? you're not seeing the right link in bugzilla?
19:35ShrutiJYes, I can't see the link on bugzilla.
19:35ShrutiJOn clicking "File Bug", the following link is generated:
19:35ShrutiJhttps://bugzilla.mozilla.org/enter_bug.cgi?cc=jmaher@mozilla.com,+rwood@mozilla.com,+ionut.goldan@softvision.ro&comment=Talos+has+detected+a+Firefox+performance+regression+from+push+.+As+author+of+one+of+the+patches+included+in+that+push,+we+need+your+help+to+address+this+regression.%0A%0ARegressions:%0A%0A++3%25++bloom_basic+http:+osx-10-10+opt+e10s+++++699
19:35ShrutiJ.26+-%3E+719.61%0A%0A%0AYou+can+find+links+to+graphs+and+comparison+views+for+each+of+the+above+tests+at:+http:%2F%2Flocalhost:5000%2Fperf.html%23%2Falerts%3Fid%3D6115%0A%0AOn+the+page+above+you+can+see+an+alert+for+each+affected+platform+as+well+as+a+link+to+a+graph+showing+the+history+of+scores+for+this+test.+There+is+also+a+link+to+a+treeherder+page+showi
19:35ShrutiJng+the+Talos+jobs+in+a+pushlog+format.%0A%0ATo+learn+more+about+the+regressing+test(s),+please+see:+https:%2F%2Fwiki.mozilla.org%2FBuildbot%2FTalos%2FTests%0A%0AFor+information+on+reproducing+and+debugging+the+regression,+either+on+try+or+locally,+see:+https:%2F%2Fwiki.mozilla.org%2FBuildbot%2FTalos%2FRunning%0A%0A***+Please+let+us+know+your+plans+within+3+b
19:35ShrutiJusiness+days,+or+the+offending+patch(es)+will+be+backed+out!+***%0A%0AOur+wiki+page+outlines+the+common+responses+and+expectations:+https:%2F%2Fwiki.mozilla.org%2FBuildbot%2FTalos%2FRegressionBugsHandling%0A&component=Untriaged&keywords=perf,+regression,+talos-regression&product=Firefox&short_desc=2.91%25+bloom_basic+http:+(osx-10-10)+regression+on+push+83f6
19:35ShrutiJ0253d9654b3305f2c33061f301fe30addee8+(Thu+Apr+20+2017)&status_whiteboard=
19:36ShrutiJDidn't realise that the link was so long. Sorry for spamming :(
19:37rwoodnp
19:37ShrutiJThe link to revision is not there in the text. Can be seen from the above link
19:44wlachShrutiJ: ok, let me take a quick look
19:44ShrutiJwlach, rwood : I have updated the PR. Do I need to make changes in the backend? If changes have to made in the frontend, I'll try to work it out on my own
19:44ShrutiJokay
19:44wlachShrutiJ: almost certainly a frontend problem
19:44ShrutiJwlach: I'll take another look then
19:45wlachShrutiJ: check the browser console for errors
19:45wlachShrutiJ: my suspicion is that we're not getting the repo object for some reason https://github.com/mozilla/treeherder/pull/2337/files#diff-d5c3abf248b638a13014d6259abba31aR10
19:49wlachShrutiJ: anyway, have a look and see if you still can't solve it, ping me
19:49ShrutiJI have a console output, console.log(repo.getPushLogHref(alertSummary.resultSetMetadata.revision));, in my local copy. It is working correctly
19:50ShrutiJwlach: Yes, I'll take another look. Should be some minor nit which I'm overlooking.
19:50wlachoh ok, so we're getting the value, just not passing it down to the template correctly
19:50wlachthat's a relief :)
19:50ShrutiJYes
21 Apr 2017
No messages
   
Last message: 63 days and 11 hours ago