mozilla :: #perfherder

17 Jul 2017
14:59ShrutiJwlach: Hi! I worked a bit on metrics during this weekend. I think min_y_from_data works only for the line graphs.
14:59wlachShrutiJ: oh interesting
14:59ShrutiJhttps://usercontent.irccloud-cdn.com/file/KcB2QqSf/Screenshot%20from%202017-07-17%2017%3A23%3A39.png
15:00ShrutiJwlach: Here's a screenshot. The y-axis is adjusted perfectly in this case
15:00wlachShrutiJ: did you try grepping for min_y_from_data inside metricsgraphics? it might be an easy fix
15:02ShrutiJwlach: I'll try
15:08ShrutiJwlach: I have one doubt. For https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&originalRevision=c0aa502190da23fd52d7a6be358180599457386b&newProject=mozilla-inbound&newRevision=c1185e615e55949151f20c66d55b0e7e62034adb&originalSignature=50280499266defab97a5f150c64a7dc33756d2e5&newSignature=50280499266defab97a5f150c64a7dc33756d2e5&framework=1
15:09ShrutiJFot tablemutation.html, there is no perfherder-data.json.
15:09ShrutiJhttps://treeherder.mozilla.org/api/jobdetail/?job_id=114693774
15:15ShrutiJwlach: ^ for the new revision
15:16wlachShrutiJ: hmm, this might be a good question for rwood|afk
15:16wlachoh wait, he's on pto
15:17wlachShrutiJ: for now I would just show an empty chart saying "replicate data not available" in that case
15:17wlachI'm not sure if table mutation does or should have this data available
15:18ShrutiJwlach: Okay. What confused me was that, if there is a value being compared for the subtest, the replicate data schould exist.
15:18ShrutiJwlach: I'll make the changes
15:19ShrutiJData is available for other table mutation tests
15:19wlachShrutiJ: some talos tests are weird
16:26ShrutiJwlach: Checked the metrics-graphics code. The basic logic of min_y_from_data seems fine to me. I suspect there's something wrong with the way svg is being made.
16:26ShrutiJwlach: I'll try to read a bit about svg and try to fix it
16:31wlachShrutiJ: interesting, I wonder why it works for line charts and not bar charts then...
18 Jul 2017
No messages
   
Last message: 67 days and 11 hours ago