mozilla :: #pdfjs

17 May 2017
14:43github_pdfjs[pdf.js] Snuffleupagus pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/e9cbfbccb471...ca3cf6e744ce
14:43github_pdfjspdf.js/master 2e9ae50 Mark Banner: Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.
14:43github_pdfjspdf.js/master ca3cf6e Jonas Jenwald: Merge pull request #8417 from Standard8/eslint-cleanup-globals...
14:43soakbotPull 8417: Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.. https://github.com/mozilla/pdf.js/pull/8417
15:17github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from 4acae9d to c39ec4f: https://github.com/mozilla/pdf.js/commits/gh-pages
15:17github_pdfjspdf.js/gh-pages c39ec4f pdfjsbot: gh-pages site created via gulpfile.js script...
22:18github_pdfjs[pdf.js] Snuffleupagus pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/ca3cf6e744ce...5958dafd8c5d
22:18github_pdfjspdf.js/master cfc2f36 chris.greening: Adds additional parameter so background color of canvas can be set
22:18github_pdfjspdf.js/master 5958daf Jonas Jenwald: Merge pull request #8413 from MRMBRAND/set-canvas-background-color...
22:18soakbotPull 8413: Adds additional parameter so background color of canvas can be set. https://github.com/mozilla/pdf.js/pull/8413
22:23Snuffleupagusyury: Hi, gentle review ping for PR #8388
22:23soakbotPull 8388: Cache JPEG images, just as we do for other image formats, in `evaluator.js` (issue 8380). https://github.com/mozilla/pdf.js/pull/8388
22:25github_pdfjs[pdf.js] yurydelendik pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/5958dafd8c5d...5dc8dcdc0fd1
22:25github_pdfjspdf.js/master 0c2ebda Jonas Jenwald: Cache JPEG images, just as we do for other image formats, in `evaluator.js` (issue 8380)...
22:25github_pdfjspdf.js/master 5dc8dcd Yury Delendik: Merge pull request #8388 from Snuffleupagus/issue-8380...
22:25soakbotPull 8388: Cache JPEG images, just as we do for other image formats, in `evaluator.js` (issue 8380). https://github.com/mozilla/pdf.js/pull/8388
22:26yurySnuffleupagus: hi
22:26Snuffleupagusyury: Thank you!
22:30yurySnuffleupagus: can you check if I'm missing anything at #8396? I would like to start landing pieces
22:30soakbotPull 8396: Adds streams-lib polyfill and exports ReadableStream from shared/util.. https://github.com/mozilla/pdf.js/pull/8396
22:30github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from c39ec4f to c1e4d2d: https://github.com/mozilla/pdf.js/commits/gh-pages
22:30github_pdfjspdf.js/gh-pages c1e4d2d pdfjsbot: gh-pages site created via gulpfile.js script...
22:38Snuffleupagusyury: I'll have to look later, since it's getting later here.
22:38SnuffleupagusHowever, I suppose that my general question is (not really having looking into the code) if this will automatically fallback to a native browser stream implementation once such a thing exists? Or is that a later thing to implement?
22:38yurySnuffleupagus: not yet, status in FF is under development
22:39yurySnuffleupagus: however chrome already have that
22:40yurynot sure if we are willing to rely on Chrome's implementation though yet
22:41SnuffleupagusAnother question, why is that being added as already transpiled to ES5? Wouldn't it make more sense to let it be ES6 and have the transpilation done with our build scripts? What is it that I'm missing here :-)
22:42yuryI'm good it's being ES5 -- less problems with IE6
22:42* Snuffleupagus CC's himself to bug 1272697
22:42yury:P
22:42yuryor Safari
22:44yuryI'm not planing to looks at this code anyway
22:44SnuffleupagusThat's certainly true!
22:44* yury has his hopes high about streams
22:44Snuffleupagus(I was only thinking that if we could include it as standard ES6 code in e.g. MOZCENTRAL builds, we'd reduce the size impact since it'd be less boilerplate code. But whatever :-)
22:45SnuffleupagusI don't really care too much, as long as it works :P
22:46yuryYou have a point, but I don't think saving will be too big
22:51SnuffleupagusIt's approximately a 8% increase in total size for the mozcentral folder, so probably not too much of an issue then
23:20yurywe will return that by speed of scrolling
23:30github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from c1e4d2d to 58ddc93: https://github.com/mozilla/pdf.js/commits/gh-pages
23:30github_pdfjspdf.js/gh-pages 58ddc93 pdfjsbot: gh-pages site created via gulpfile.js script...
18 May 2017
No messages
   
Last message: 66 days and 21 hours ago