mozilla :: #pdfjs

14 Jul 2017
11:01nish17Hi yury, in this issue #8188, U had mentioned that "We need to add something like PDFSinglePageViewer which will implement interface similar to what PDFViewer has". I'm sorry but I can't find the file named 'PDFViewer'. Are you refering to pageViewer file ?
11:01soakbotIssue 8188: Missing references in internal links in pageviewer example. https://github.com/mozilla/pdf.js/issues/8188
11:32duziyury: Is it true that height >= originalHeight and width >= originalWidth in https://github.com/mozilla/pdf.js/blob/master/src/core/colorspace.js#L116?
11:34github_pdfjs[pdf.js] timvandermeij pushed 3 new commits to master: https://github.com/mozilla/pdf.js/compare/95093a5276d9...d7367f102e00
11:34github_pdfjspdf.js/master cb0009d Jonas Jenwald: Actually reset the `findResultsCount` label, in addition to hiding it, when no matches are found...
11:34github_pdfjspdf.js/master 9c95614 Jonas Jenwald: Ensure that `PDFFindBar._adjustWidth` is called in all situations where the width of the findbar might have changed...
11:34github_pdfjspdf.js/master d7367f1 Tim van der Meij: Merge pull request #8609 from Snuffleupagus/findbar-more-adjustWidth...
11:34soakbotPull 8609: Ensure that `PDFFindBar._adjustWidth` is called in all situations where the width of the findbar might have changed. https://github.com/mozilla/pdf.js/pull/8609
11:46github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from a8bf8de to d75b2d6: https://github.com/mozilla/pdf.js/commits/gh-pages
11:46github_pdfjspdf.js/gh-pages d75b2d6 pdfjsbot: gh-pages site created via gulpfile.js script...
11:53github_pdfjs[pdf.js] timvandermeij pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/d7367f102e00...3e472f179801
11:53github_pdfjspdf.js/master e004b3c Nimesh Solanki: update inconsistent names
11:53github_pdfjspdf.js/master 3e472f1 Tim van der Meij: Merge pull request #8634 from nish17/master...
11:53soakbotPull 8634: Update inconsistent names. https://github.com/mozilla/pdf.js/pull/8634
12:14github_pdfjs[pdf.js] timvandermeij pushed 3 new commits to master: https://github.com/mozilla/pdf.js/compare/3e472f179801...d95022328c7a
12:14github_pdfjspdf.js/master 8391aac Jonas Jenwald: Remove the scale-not-initialized hack from `webViewerResize` (in app.js)...
12:14github_pdfjspdf.js/master c253ee9 Jonas Jenwald: Ensure that the document is rendered on load, no matter what happens, by always calling `PDFViewer.update` *after* the initial position has been set
12:14github_pdfjspdf.js/master d950223 Tim van der Meij: Merge pull request #8618 from Snuffleupagus/webViewerResize-rm-hack...
12:14soakbotPull 8618: Remove the scale-not-initialized hack from `webViewerResize` (in app.js). https://github.com/mozilla/pdf.js/pull/8618
12:17github_pdfjs[pdf.js] timvandermeij pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/d95022328c7a...26be1df5f76b
12:17github_pdfjspdf.js/master 6f3565e Jonas Jenwald: Update ESLint (and eslint-plugin-mozilla) to the latest version
12:17github_pdfjspdf.js/master 26be1df Tim van der Meij: Merge pull request #8641 from Snuffleupagus/eslint-version-4-upgrade...
12:17soakbotPull 8641: Update ESLint (and eslint-plugin-mozilla) to the latest version. https://github.com/mozilla/pdf.js/pull/8641
12:19github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from d75b2d6 to 1dd6689: https://github.com/mozilla/pdf.js/commits/gh-pages
12:19github_pdfjspdf.js/gh-pages 1dd6689 pdfjsbot: gh-pages site created via gulpfile.js script...
12:23github_pdfjs[pdf.js] yurydelendik pushed 6 new commits to master: https://github.com/mozilla/pdf.js/compare/26be1df5f76b...ca3c08f12b1b
12:23github_pdfjspdf.js/master 94f1dde Rob Wu: Move DEFLATE logic in convertImgDataToPng...
12:23github_pdfjspdf.js/master 9caaaf3 Rob Wu: Add setStubs/unsetStubs to domstubs to support testing...
12:23github_pdfjspdf.js/master a488ff4 Rob Wu: Put every test file on a separate lint in jasmine-boot.js
12:53github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from 1dd6689 to ad230c7: https://github.com/mozilla/pdf.js/commits/gh-pages
12:53github_pdfjspdf.js/gh-pages ad230c7 pdfjsbot: gh-pages site created via gulpfile.js script...
13:27github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from ad230c7 to 9e2fb05: https://github.com/mozilla/pdf.js/commits/gh-pages
13:27github_pdfjspdf.js/gh-pages 9e2fb05 pdfjsbot: gh-pages site created via gulpfile.js script...
14:02github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from 9e2fb05 to 8bfa3ab: https://github.com/mozilla/pdf.js/commits/gh-pages
14:02github_pdfjspdf.js/gh-pages 8bfa3ab pdfjsbot: gh-pages site created via gulpfile.js script...
14:52yurybdahl: good morning
14:54bdahlyury: morning
19:46mukulyury: hi, can you please help me here: https://github.com/mozilla/pdf.js/pull/8617#issuecomment-315333412
19:47mukulI am getting "FormatError: bad XRef entry" in console
19:49yuryin IE?
19:49mukulI am getting this error in firefox, but it is very rare. It is printing only the very first time I load the viewer.
19:49mukulNope, I am testing it in firefox.
19:49yurymay it send data out of order?
19:50yuryor wrong data
19:50mukulI think it is from here: https://github.com/mozilla/pdf.js/blob/master/src/core/obj.js#L1280
19:50yuryI know, but it is caused my wrong data
19:50yurybad PDF data
19:51yurymeans to some reason we are getting invalid data via PDFWorkerStream
19:52mukulBut we are not doing anything with PDF data.
19:52mukulmeans any changes
19:53yurywe are sending it
19:53mukulYeah right, but we are not modifying it, I think.
19:54yurylooks like we are
19:54mukulJust wrapping with Uint8Array at some places.
19:56yuryit does not mean it was not modified before it was send or delivered out of order
19:57yurye.g. we wrapped it and enqueue, but something wrote stuff in the buffer
19:57yuryor first enqueue data was delivered (for some reason) after second
20:00yurymukul: you need to intrument chunked_stream to "load" all data and compare instead of ".set"
20:02yuryonce you will know at which .set it's getting corrupted (and where) you will trace your steps back to the main thread
20:02yurymukul: make sense so far?
20:02mukulcompare with what? I am not getting this point.
20:03yurye.g. generate js file with `exports.testPdfData = new Uint8Array([....`
20:04yurythere are many ways though
20:07yuryyou going to load the same pdf, right?
20:07mukulyes
20:07mukulSo, this file will contain pdf data in Uint8Array
20:09mukulBut do we are going to write pdf data into this file, and compare if there is any error or something extra written?
20:12yurycontrol what we are writing via .set
20:12yuryif data is different from what in testPdfData then this operation has a problem
20:14yurythis js file is easy to generate using node.js
20:16mukulyes, I can write pdf data into this file(after this.bytes.set(...) call in chunked_stream) in master branch.
20:16mukulDoes it make sense?
20:17yuryit better to do it before .set
20:17mukulokay
20:17yurythrowing exception might not help, you might use console.log
20:18yurymukul: why on master branch?
20:19mukulBecause it is not creating any bad pdf data.
20:19yuryhow about just fs.readFileSync('file.pdf')?
20:20mukulah, yes. And wrapper of Uint8Array around it like `new Uint8Array(fs.readFileSync('file.pdf'))` ?
20:21yurywhatever generate the file you can import into chunked_stream
20:21yurythis files will be yours only
20:21yurythese
20:22mukulyeah, sure.
23:22github_pdfjs[pdf.js] timvandermeij pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/ca3c08f12b1b...afb1cd7377fb
23:22github_pdfjspdf.js/master 8ba8072 Jonas Jenwald: Convert `PDFLinkService` to an ES6 class
23:22github_pdfjspdf.js/master afb1cd7 Tim van der Meij: Merge pull request #8649 from Snuffleupagus/es6-PDFLinkService-class...
23:22soakbotPull 8649: Convert `PDFLinkService` to an ES6 class. https://github.com/mozilla/pdf.js/pull/8649
23:33github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from 8bfa3ab to 7a60392: https://github.com/mozilla/pdf.js/commits/gh-pages
23:33github_pdfjspdf.js/gh-pages 7a60392 pdfjsbot: gh-pages site created via gulpfile.js script...
15 Jul 2017
No messages
   
Last message: 11 days and 15 hours ago