mozilla :: #pdfjs

13 Jul 2017
14:57hlveyury, is there an ETA when the pre-release version is going to be released officially?
14:57hlve:)
14:58hlve1.8.170 has SO many fixes but we're uneasy about using pre-releases.
15:00yuryhlve: we don't have that on schedule yet, but we will do it as a need arises
15:00hlveThanks.
15:00yuryhlve: why you are uneasy using pre-release
15:01hlvebig customers, big testing effort.
15:01hlvebig company, large testing effort, rather.
15:02hlvethey're always uneasy about updating to a pre-release. Not sure why, as I know you guys do a ton of testing before putting out a pre-release.
15:02yurynot sure I understand, but we perform automated testing with each fix and trying to address regression as soon as possible
15:02hlveit isn't really my decision, so it isn't me you'd have to convince lol
15:02yurythe dev might choose any changeset that works for them
15:03hlvei'm just a lowly developer tasked with updating it in our component :3
15:03yuryokay, you can tell them that we will release it soon
15:03yury:)
15:04hlve=] appreciate it.
15:59mukulyury: hi, I am thinking how we are going to reduce then amount of data send via `GetDocRequest` call. I can't found anything in the `data`, that we don't need at worker side.
16:01yurymukul: that's actually good, I just want to be sure we don't send/save anything we don't need, e.g. http headers
16:02* mukul thinking can we reduce the amount source.data
16:03mukulI think most of the http headers are required at worker in some computation
16:03mukulBut have to cross check first.
16:09mukulI think we can remove `disableRange`.
16:25github_pdfjs[pdf.js] Snuffleupagus pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/2cef24a2adc0...a63015a9a2dc
16:25github_pdfjspdf.js/master f227025 Jonas Jenwald: Add `Number.isNaN` and `Number.isInteger` polyfills in compatibility.js, since the Streams polyfill relies on them...
16:25github_pdfjspdf.js/master a63015a Jonas Jenwald: Merge pull request #8643 from Snuffleupagus/polyfill-Number-isNaN...
16:25soakbotPull 8643: Add `Number.isNaN` and `Number.isInteger` polyfills in compatibility.js, since the Streams polyfill relies on them. https://github.com/mozilla/pdf.js/pull/8643
16:36github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from 4989de9 to c85eb3e: https://github.com/mozilla/pdf.js/commits/gh-pages
16:36github_pdfjspdf.js/gh-pages c85eb3e pdfjsbot: gh-pages site created via gulpfile.js script...
17:33duziyuri: In https://github.com/mozilla/pdf.js/blob/master/src/core/colorspace.js#L263, 'res' is a dictionary object(Resources dictionary), right?
17:34yuryduzi: correct, see if https://github.com/mozilla/pdf.js/blob/master/test/unit/evaluator_spec.js#L23-L44 will help
17:36yury(mock can contain any logic you like thougt, use it as example)
17:36duziyuri: Thanks
17:41duziyuri: I don't think there's need for a ResourcesMock class, since res is a dictionary obj anyway. I can simply write res = new Dict() and then res.set(...) to set the values. What do you say?
17:51mukulyury: can you please explain a bit, what `bound` signifies here: https://github.com/mozilla/pdf.js/pull/8617#discussion_r127268962 ?
17:52mukulI am not getting, what is wrong in `sink.onCancel = _rangeReader.cancel`.
17:55mukulDoes it mean that if we are going to do `sink.onCancel = _rangeReader.cancel`, `this` value of `_rangeReader` will change?
18:34yurymukul: _rangeReader.cancel(...) is shortcut for _rangeReader.cancel.call(_rangeReader, ...)
18:34yuryvar t = _rangeReader.cancel; t(); is not equal to that
18:35yuryto make is equal we need to do var t = _rangeReader.cancel.bind( _rangeReader);
18:35mukulOkay, that mean `this` value of cancel will change.
18:35yuryyeah, it will be null
18:35mukulAs scope changed to global from _rangeReader
18:36yurymukul: we did it for capability resolve/reject because they don't care about this
18:36yury _rangeReader.cancel care about this afaik
18:37mukulyes, right changing scope of _rangeReader.cancel will create issues.
18:37yurysink.onCancel = (r) => { _rangeReader.cancel(r); } is fine with me
18:39mukulOkay, Thanks.
20:20github_pdfjs[pdf.js] yurydelendik pushed 2 new commits to master: https://github.com/mozilla/pdf.js/compare/a63015a9a2dc...c673b6fee15c
20:20github_pdfjspdf.js/master 5246068 Yury Delendik: Fixes pdf.js library source detection.
20:20github_pdfjspdf.js/master c673b6f Yury Delendik: Merge pull request #8646 from yurydelendik/issue-8645...
20:20soakbotPull 8646: Fixes pdf.js library source detection.. https://github.com/mozilla/pdf.js/pull/8646
20:31github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from c85eb3e to e66de02: https://github.com/mozilla/pdf.js/commits/gh-pages
20:31github_pdfjspdf.js/gh-pages e66de02 pdfjsbot: gh-pages site created via gulpfile.js script...
20:48github_pdfjs[pdf.js] brendandahl pushed 1 new commit to master: https://github.com/mozilla/pdf.js/commit/95093a5276d9e627717aa25411284727f312fad5
20:48github_pdfjspdf.js/master 95093a5 Christian Myksvoll: Check for undefined url (#8640)...
21:05github_pdfjs[pdf.js] pdfjsbot force-pushed gh-pages from e66de02 to a8bf8de: https://github.com/mozilla/pdf.js/commits/gh-pages
21:05github_pdfjspdf.js/gh-pages a8bf8de pdfjsbot: gh-pages site created via gulpfile.js script...
22:32duziyury: What does 'actualHeight' in https://github.com/mozilla/pdf.js/blob/master/src/core/colorspace.js#L116 signify?
23:17yuryduzi: sometime image is incomplete so it covers only first actualHeight rows
23:20duziyury: Does it mean actualHeight <= originalHeight?
23:22yuryduzi: looking at https://github.com/mozilla/pdf.js/blob/7b4887dd211c44d5ef852ad019921fb41fa3709b/src/core/image.js#L549, actualHeight <= height
23:41duziyury: So you mean actualHeight is the height of the image after it&#39;s tranformed from image space to user space, right?
23:41yuryyeah
23:42duziWhy would actualHeight be less? Is it because of the decoding?
23:54yuryyes
14 Jul 2017
No messages
   
Last message: 68 days and 11 hours ago