mozilla :: #pageshot

16 Mar 2017
00:02travis-ciThe build was broken.: mozilla-services/pageshot#2691 (enabling-pref - 805baa9 : Jared Hirsch) https://travis-ci.org/mozilla-services/pageshot/builds/211565909
00:04travis-ciThe build is still failing.: mozilla-services/pageshot#2693 (enabling-pref - 066da49 : Jared Hirsch) https://travis-ci.org/mozilla-services/pageshot/builds/211566375
00:16GitHubPS[pageshot] dannycoates closed issue #2379: Review shared/ https://git.io/vy1iQ
00:16GitHubPS[pageshot] dannycoates closed issue #2369: Remove deviceInfo from auth.js https://git.io/vyPCx
00:20GitHubPS[pageshot] dannycoates commented on issue #2368: Since it was easy to add the tab id I went ahead and finished it this way. We can change to an error prompt if this proves too slow, but I think this is a much better UX. @ianb ready for review again. https://git.io/vySLq
00:48GitHubPS[pageshot] dannycoates opened issue #2403: Change "active" icon color https://git.io/vySq0
00:49GitHubPS[pageshot] dannycoates commented on pull request #2389 1f2b083: #2403 https://git.io/vySqu
03:27garbadoshey! i'm trying to tackle this issue https://github.com/mozilla-services/pageshot/issues/2299 but i can't find the file 'webextension/makeUuid.js' in my local clone of pageshot. the webextension folder only has manifest.json and a 'build' folder. also, the folder isn't being tracked in git? idk what in the world i've done but that's the state of things
03:30garbadosoh, it's under addon/webextension :/ idk why the difference though
04:14GitHubPS[pageshot] garbados opened pull request #2404: WIP: use window.crypto.getRandomValues (master...issue-2299) https://git.io/vySle
04:19GitHubPS[pageshot] garbados commented on issue #2404: The pastebin method, though lacking a known author besides "A guest, on December 7, 2017", makes sense to me, and matches the spec as I understand it. Still it irks my paranoia, since we're fundamentally discussing a security issue. https://git.io/vySlZ
04:19GitHubPS[pageshot] garbados commented on issue #2404: The pastebin method, though lacking a known author besides "A guest, on December 7, 2017", makes sense to me, and matches the spec as I understand it. Still it irks my paranoia, since we're fundamentally discussing a security issue. https://git.io/vySlZ
04:31GitHubPS[pageshot] garbados opened issue #2405: Tests take too long on older hardware https://git.io/vySly
04:51GitHubPS[pageshot] garbados opened pull request #2406: extend test timeout (master...issue-2405) https://git.io/vyS4T
10:35pgadigeI'd like to attend (remotely) 'Page Shot Engineering' meeting scheduled today. Is it open to contributors/newbies?
15:02GitHubPS[pageshot] ianb closed pull request #2406: extend test timeout (master...issue-2405) https://git.io/vyS4T
15:02GitHubPS[pageshot] ianb pushed 3 new commits to master: https://git.io/vy9Zd
15:02GitHubPSpageshot/master 057014b Diana Thayer: extend test timeout
15:02GitHubPSpageshot/master 645e552 Diana Thayer: add semicolon
15:02GitHubPSpageshot/master 0ab0362 Ian Bicking: Merge pull request #2406 from garbados/issue-2405...
15:08GitHubPS[pageshot] ianb commented on issue #2404: The function in shot.js may be harder to change that file is used on both the server and client, so `window` shouldn't be used. OTOH, looking at how that function is used there's no real security concern, and Math.random would be fine for that case. Also I notice while the function in shot.js is distractingly called `makeUuid()` it actually returns a random string. I think you could just leav
15:09clouserwpgadige is gone, but that meeting is public and anyone is welcome. that said, I have a conflict today
15:10clouserwcory and john will too
15:10clouserwdo you still want to have it and if so is there a volunteer to run it?
15:11ianbickingI could go either way. We can just talk ONLY ABOUT CODE and no process!
15:11GitHubPS[pageshot] ianb closed pull request #2389: added selector ui toggling (master...toggle-button) https://git.io/vyMRf
15:11GitHubPS[pageshot] ianb pushed 1 new commit to master: https://git.io/vy9cn
15:11GitHubPSpageshot/master 5f89622 Ian Bicking: Merge pull request #2389 from mozilla-services/toggle-button...
15:11GitHubPS[pageshot] ianb deleted toggle-button at 1f2b083: https://git.io/vy9cC
15:22Standard8wow, mercurials bookmarks are weird
15:22* Standard8 heads back to git
15:26Standard8oops, just pushed to try by accident
15:39clouserwwhile we're at it, do we need the 15min ops regroup today?
15:54GitHubPS[pageshot] Standard8 commented on pull request #2393 a8974ef: > This could be $(VENV)/bin/pip install -r bin/require.pip... https://git.io/vy9EL
15:59GitHubPS[pageshot] Standard8 created patch-creation (+2 new commits): https://git.io/vy9ue
15:59GitHubPSpageshot/patch-creation 8a1b5fc Mark Banner: WIP
15:59GitHubPSpageshot/patch-creation 6ee2f3d Mark Banner: chore: Simplify exporting to mozilla-central by adding a script which exports and creates branches and commits.
16:00ianbickingclouserw: I think we can cancel ops regroup, yes
16:02GitHubPS[pageshot] Standard8 force-pushed patch-creation from 6ee2f3d to 1ca2594: https://git.io/vy9uC
16:02GitHubPSpageshot/patch-creation 1ca2594 Mark Banner: chore: Simplify exporting to mozilla-central by adding a script which exports and creates branches and commits.
16:04Standard8ianbicking: fyi Im at a team work week Mon-Wed next week, so I probably wont be doing much
16:06travis-ciThe build passed.: mozilla-services/pageshot#2701 (patch-creation - 6ee2f3d : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211805032
16:06GitHubPS[pageshot] Standard8 opened pull request #2407: chore: Simplify exporting to mozilla-central by adding a script which exports and creates branches and commits. (master...patch-creation) https://git.io/vy9uh
16:08GitHubPS[pageshot] Standard8 commented on issue #2401: CircleCI already has virtualenv installed afaict, travis doesn't which is why it needed it. https://git.io/vy9zR
16:09travis-ciThe build passed.: mozilla-services/pageshot#2702 (patch-creation - 1ca2594 : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211806411
16:11Standard8ianbicking: looks like CircleCI is currently broken...
16:13GitHubPS[pageshot] pdehaan commented on pull request #2407 1ca2594: not sure if it matters, but prod doesnt have a trailing `/`, but the other envs do. https://git.io/vy9gY
16:15Standard8dcoates: can I sneak https://github.com/mozilla-services/pageshot/issues/2354 from you?
16:15GitHubPS[pageshot] ianb commented on pull request #2407 1ca2594: Maybe this should also rm -rf node_modules/ ? But I'm not entirely sure what distclean should do compared to clean https://git.io/vy9g9
16:16dcoatesStandard8: sure
16:19ianbickingI tried bumping that CircleCI build, but same failure
16:20ianbickingoh, my fault: https://115-26788257-gh.circle-artifacts.com/0/tmp/circle-artifacts.rCwpfbJ/stdout_node_22160.txt
16:20circleci-botHello from CircleCI
16:21* ianbicking should have used make clean
16:21circleci-botHello from CircleCI
16:24GitHubPS[pageshot] Standard8 commented on issue #2354: Turned on. To do this/change it in future:... https://git.io/vy9at
16:27GitHubPS[pageshot] Standard8 created circleci-badge (+1 new commit): https://git.io/vy9ay
16:27GitHubPSpageshot/circleci-badge 0c9ea74 Mark Banner: Add a status badge for CircleCI builds.
16:28GitHubPS[pageshot] Standard8 force-pushed circleci-badge from 0c9ea74 to bfd3f4e: https://git.io/vy9VJ
16:28GitHubPSpageshot/circleci-badge bfd3f4e Mark Banner: Add a status badge for CircleCI builds.
16:29GitHubPS[pageshot] Standard8 force-pushed circleci-badge from bfd3f4e to 1a4e416: https://git.io/vy9VJ
16:29GitHubPSpageshot/circleci-badge 1a4e416 Mark Banner: chore: Add a status badge for CircleCI builds.
16:29travis-ciThe build has errored.: mozilla-services/pageshot#2705 (circleci-badge - bfd3f4e : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211816806
16:29GitHubPS[pageshot] Standard8 opened pull request #2408: Add a status badge for CircleCI builds. (master...circleci-badge) https://git.io/vy9Vn
16:33circleci-botFailed: Standard8's build (#116; push) in mozilla-services/pageshot (circleci-badge) -- https://circleci.com/gh/mozilla-services/pageshot/116?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
16:33557A6SW1Q[pageshot] Standard8 commented on issue #2354: And I just confirmed, it seems to be working, yay! https://git.io/vy9VQ
16:33203A6RY6K[pageshot] Standard8 closed issue #2354: Have CircleCI notify IRC https://git.io/vyoeS
16:34circleci-botFailed: Standard8's build (#117; push) in mozilla-services/pageshot (circleci-badge) -- https://circleci.com/gh/mozilla-services/pageshot/117?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
16:34travis-ciThe build passed.: mozilla-services/pageshot#2704 (circleci-badge - 0c9ea74 : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211816145
16:35GitHubPS[pageshot] ianb created fix-server (+1 new commit): https://git.io/vy9we
16:35GitHubPSpageshot/fix-server 8fa0209 Ian Bicking: Restore errors.js that was mistakenly removed in cleanup...
16:35GitHubPS[pageshot] ianb opened pull request #2409: Restore errors.js that was mistakenly removed in cleanup (master...fix-server) https://git.io/vy9wJ
16:39travis-ciThe build passed.: mozilla-services/pageshot#2706 (circleci-badge - 1a4e416 : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211817017
16:42travis-ciThe build passed.: mozilla-services/pageshot#2708 (fix-server - 8fa0209 : Ian Bicking) https://travis-ci.org/mozilla-services/pageshot/builds/211819034
16:47GitHubPS[pageshot] dannycoates closed pull request #2409: Restore errors.js that was mistakenly removed in cleanup (master...fix-server) https://git.io/vy9wJ
16:47GitHubPS[pageshot] dannycoates pushed 1 new commit to master: https://git.io/vy9rA
16:47GitHubPSpageshot/master 867df84 Danny Coates: Merge pull request #2409 from mozilla-services/fix-server...
16:48GitHubPS[pageshot] Standard8 force-pushed patch-creation from 1ca2594 to bd387d8: https://git.io/vy9uC
16:48GitHubPSpageshot/patch-creation bd387d8 Mark Banner: chore: Simplify exporting to mozilla-central by adding a script which exports and creates branches and commits.
16:50GitHubPS[pageshot] Standard8 commented on pull request #2407 bd387d8: Distclean generally gets rid of the support files/dependencies as well as the build stuff. The simple clean is just for the build (or that's how we did it in Loop) https://git.io/vy9ol
16:53GitHubPS[pageshot] Standard8 force-pushed patch-creation from bd387d8 to 43ced6d: https://git.io/vy9uC
16:53GitHubPSpageshot/patch-creation 43ced6d Mark Banner: chore: Simplify exporting to mozilla-central by adding a script which exports and creates branches and commits.
16:53GitHubPS[pageshot] Standard8 force-pushed circleci-badge from 1a4e416 to 53f5205: https://git.io/vy9VJ
16:53GitHubPSpageshot/circleci-badge 53f5205 Mark Banner: chore: Add a status badge for CircleCI builds.
16:53circleci-botFixed: dannycoates's build (#120; push) in mozilla-services/pageshot (master) -- https://circleci.com/gh/mozilla-services/pageshot/120?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
16:53557A6SW9Z[pageshot] ianb commented on issue #2400: Was done in 484343f78743ba2dc34000ad52ad1e4503bdc522 https://git.io/vy9oQ
16:53203A6RZEG[pageshot] ianb closed issue #2400: Remove fixup_panel.py https://git.io/vyyDr
16:54circleci-botFixed: Standard8's build (#121; push) in mozilla-services/pageshot (patch-creation) -- https://circleci.com/gh/mozilla-services/pageshot/121?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
16:59circleci-botFixed: Standard8's build (#123; push) in mozilla-services/pageshot (circleci-badge) -- https://circleci.com/gh/mozilla-services/pageshot/123?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=irc
17:01GitHubPS[pageshot] Standard8 commented on issue #2407: @ianb: Updated for your comments. https://git.io/vy96v
17:03GitHubPS[pageshot] ianb closed pull request #2407: chore: Simplify exporting to mozilla-central by adding a script which exports and creates branches and commits. (master...patch-creation) https://git.io/vy9uh
17:03GitHubPS[pageshot] ianb pushed 1 new commit to master: https://git.io/vy96l
17:03GitHubPSpageshot/master 7c304d8 Ian Bicking: Merge pull request #2407 from mozilla-services/patch-creation...
17:03GitHubPS[pageshot] ianb deleted patch-creation at 43ced6d: https://git.io/vy964
17:04GitHubPS[pageshot] ianb closed pull request #2408: Add a status badge for CircleCI builds. (master...circleci-badge) https://git.io/vy9Vn
17:04GitHubPS[pageshot] ianb deleted circleci-badge at 53f5205: https://git.io/vy962
17:06GitHubPS[pageshot] ianb closed issue #2258: The text from "Expired Shot" pages is very small hardly visible https://git.io/vyZIv
17:06GitHubPS[pageshot] ianb closed pull request #2385: Fix/2258 (master...fix/2258) https://git.io/vyMTz
17:32_6a68this is a meeting, right?
18:03ianbickingBTW, I was thinking of taking this Friday to do the rename
18:04_6a68 sgtm
18:16reludianbicking: we should talk about the details of changing from pageshot.net to pageshot.firefox.com later
18:17ianbickingrelud: sure (screenshots.firefox.com)
18:17relud>_< yeah that
18:17ianbicking_6a68: was there a decision about what repo the strings would go into?
18:30_6a68ianbicking: sorry, I suggested keeping them in the pageshot repo
18:30_6a68missed your ping a bit ago
18:30ianbicking_6a68: no prob, just saw the status and realized I wasnt sure about what we decided
18:30_6a68
19:45GitHubPS[pageshot] garbados commented on issue #2404: Understood. I&#39;ll make those changes. Thanks for the feedback! https://git.io/vyHJ5
20:18GitHubPS[pageshot] ianb opened issue #2410: Design page title https://git.io/vyHt4
20:56rhelmerhm. some extensions folks looked into bug 1347482, going to wait to see what DOM folks think but probably easy to work around in the webext code if they don&#39;t want to change anything.
21:58GitHubPS[pageshot] ianb opened issue #2411: 404 on site: pageshot-icon-32.png https://git.io/vyH4H
17 Mar 2017
No messages
   
Last message: 154 days and 7 hours ago