mozilla :: #pageshot

15 Mar 2017
00:04GitHubPS[pageshot] pdehaan commented on issue #2382: Me thinks this is a dupe of #2215 https://git.io/vyMGF
00:10GitHubPS[pageshot] 6a68 commented on issue #2047: @djmitche Hey, can you still reproduce this issue?... https://git.io/vyMZu
00:13GitHubPS[pageshot] pdehaan opened pull request #2387: Remove xml-stylesheet from SVGs (master...issue-2215) https://git.io/vyMZy
00:18GitHubPS[pageshot] pdehaan opened pull request #2388: Add CONTRIBUTORS.md file (master...issue-2380) https://git.io/vyMnO
00:58GitHubPS[pageshot] djmitche closed issue #2047: Browser hangs when snapshotting signalfx https://git.io/v1iWc
02:18GitHubPS[pageshot] dannycoates created toggle-button (+1 new commit): https://git.io/vyMBD
02:18GitHubPSpageshot/toggle-button edafae6 Danny Coates: WIP on toggle button
02:20GitHubPS[pageshot] dannycoates force-pushed toggle-button from edafae6 to 9bcb45a: https://git.io/vyMB7
02:20GitHubPSpageshot/toggle-button 9bcb45a Danny Coates: added selector ui toggling
02:23GitHubPS[pageshot] dannycoates opened pull request #2389: added selector ui toggling (master...toggle-button) https://git.io/vyMRf
02:24travis-ciThe build passed.: mozilla-services/pageshot#2661 (toggle-button - edafae6 : Danny Coates) https://travis-ci.org/mozilla-services/pageshot/builds/211199320
02:25GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: I found I needed the `tab.id` in the `closeSelector` handler. It's probably generally useful to make this available, and I didn't find a case where it broke anything. https://git.io/vyMRt
02:26travis-ciThe build passed.: mozilla-services/pageshot#2662 (toggle-button - 9bcb45a : Danny Coates) https://travis-ci.org/mozilla-services/pageshot/builds/211199551
02:27GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: I combined the functionality of `loadSelector.js` and `lifecycle.js` into `selectorLoader.js`. It was a bit easier for me to reason through it that way. https://git.io/vyMRC
02:29GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: Changes the icon to green when the selector is visible. @johngruen I know the color is bad, please change it. https://git.io/vyMRM
02:32GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: I needed this to signal that the icon should go back to grey since there's more ways to get out of the selector ui than getting in. Originally this did more but I narrowed it down to this. https://git.io/vyMRp
02:36GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: This replaces the code in `lifecycle.js` that unloaded the previous run. Since the toggle disables on the second press we don't want to load the scripts again after this. https://git.io/vyM0O
02:38GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: I went a little fancier here with the `reduce` but we can go back to the other way if preferred. https://git.io/vyM0B
02:43GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: This deletes everything including catcher (last). I think the unloading is clean enough that its safe to do it. https://git.io/vyM0d
02:44GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: This deletes everything including catcher (last). I think the unloading is clean enough that its safe to do it. https://git.io/vyM0d
02:47GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: `deactivate` calls `selectorLoader.unloadModules` so it needs to wait until after the background call https://git.io/vyMEv
02:47GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: popstate wasn't working so I removed this https://git.io/vyMEU
02:48GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: moved from `uicontrol.deactivate` https://git.io/vyMEk
02:49GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: this wasn't getting removed in `removeHandlers` since the wrapped function isn't the same as `keyupHandler` https://git.io/vyMEY
02:50GitHubPS[pageshot] ianb opened issue #2390: Expose direct link to image https://git.io/vyMEn
02:51GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: called as `unload` by `unloadModules` https://git.io/vyMEl
02:51GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: called on `unload` https://git.io/vyMER
02:55GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: the `popstate` event wasn't being triggered by back/forward buttons. `beforeunload` is the best option I found. `unload` seems to be too late. https://git.io/vyME1
02:56GitHubPS[pageshot] dannycoates commented on pull request #2389 9bcb45a: `shooter.deactivate` was just calling `uicontrol.deactivate` so I removed it https://git.io/vyMEH
04:13GitHubPS[pageshot] dannycoates closed pull request #2384: Optional bootstrap (master...optional-bootstrap) https://git.io/vyMfG
04:16GitHubPS[pageshot] dannycoates force-pushed toggle-button from 9bcb45a to 1ed18e0: https://git.io/vyMB7
04:16GitHubPSpageshot/toggle-button 1ed18e0 Danny Coates: added selector ui toggling
04:19GitHubPS[pageshot] dannycoates pushed 2 new commits to master: https://git.io/vyM25
04:19GitHubPSpageshot/master 06a108e Peter deHaan: Remove xml-stylesheet from SVGs
04:19GitHubPSpageshot/master ec92808 Danny Coates: Merge pull request #2387 from pdehaan/issue-2215...
04:34GitHubPS[pageshot] dannycoates commented on issue #2132: In #2389 I made some changes to the unloading behavior including fixing a `keyup` listener bug. Maybe we should close this until someone can reproduce? https://git.io/vyMa4
04:44GitHubPS[pageshot] wresuolc commented on issue #2332: Sounds good. For the record, once we're done rolling this out (a couple weeks?) we can just remove this pref and the code for it altogether. https://git.io/vyMaA
05:18pgadigeAs I'm trying to install PostgreSQL on Ubuntu 16.04 inside a VM, I see 'Temporary failure resolving us.archive.ubuntu.com' error after having run the command `sudo apt-get install postgresql-9.5`
06:58GitHubPS[pageshot] TLHuang commented on issue #2103: Sorry for the late reply. I've updated the face icon to the [asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), also updated the latest measurement, please refer to [Taking Shot Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0). For the final screens, you can find them [here](https://www.dropbox.com/sh/prnul09pg81gv1f/AA
07:00GitHubPS[pageshot] TLHuang commented on issue #2103: Sorry for the late reply. I've updated the face icon to the [asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), also updated the latest measurement, please refer to [Taking Shot Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0).... https://git.io/vyXZZ
07:03GitHubPS[pageshot] TLHuang commented on issue #2103: Sorry for the late reply. I've updated the face icon to the [asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), also updated the latest measurement, please refer to [Shooting Page Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0).... https://git.io/vyXZZ
07:28GitHubPS[pageshot] TLHuang commented on issue #2103: Sorry for the late reply. I've updated the face icon to the [asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), also updated the latest measurement, please refer to [Shooting Page Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0).... https://git.io/vyXZZ
07:43GitHubPS[pageshot] TLHuang commented on issue #2306: The measurement is ready, please refer to [Shooting Page Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0), and the svg assets are uploaded to [the asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), the face icon is also included. All the screens for Shooting Pages you can find them [here].... https://git.io/vyM1f
07:46GitHubPS[pageshot] TLHuang commented on issue #2306: The measurement is ready, please refer to [Shooting Page Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0), and the svg assets are uploaded to [the asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), the face icon is also included. All the screens for Shooting Pages you can find them [here].... https://git.io/vyM1f
08:22GitHubPS[pageshot] TLHuang commented on issue #2312: For the **Owner** Shot page... https://git.io/vyMDw
08:44GitHubPS[pageshot] TLHuang commented on issue #2239: Here is the current design for notification... https://git.io/vyMSz
08:45GitHubPS[pageshot] TLHuang commented on issue #2239: Here is the current design for notification... https://git.io/vyMSz
08:47GitHubPS[pageshot] Standard8 commented on issue #2365: Ok, I'll bite, we've about 3 projects wanting to use something similar now, so it is time to come up with a better solution.... https://git.io/vyMSA
08:51GitHubPS[pageshot] TLHuang commented on issue #2311: Update the measurement. Let me know if anything else is still needed.... https://git.io/vyM9s
09:01GitHubPS[pageshot] TLHuang commented on issue #2306: The measurement is ready, please refer to [Shooting Page Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0), and the svg assets are uploaded to [the asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), the face icon is also included. If you need to take a look at all screens for Shooting Pages, you can find them [here](http
09:02GitHubPS[pageshot] youwenliang commented on issue #2306: As for the interaction for the eyeballs, check out this example:... https://git.io/vyMHY
09:02GitHubPS[pageshot] TLHuang commented on issue #2306: The measurement is ready, please refer to [Shooting Page Measurement](https://www.dropbox.com/sh/n9zxt0u7y65og5g/AABYBQwURWCUYk3R5542h0tHa?dl=0), and the svg assets are uploaded to [the asset folder](https://www.dropbox.com/sh/ojayi19kll69zam/AAAaqSkjoZ1JOCHU6sP8Lh2pa?dl=0), the face icon is also included. If you need to find all screens for Shooting Pages, you can find them [here](https://www.dr
09:19GitHubPS[pageshot] fangshih commented on issue #2312: For the **Non-Owners** Shot page... https://git.io/vyXtx
09:36GitHubPS[pageshot] SoftVision-CosminMuntean opened issue #2391: "Error: response fail" error appears after trying to save a shot https://git.io/vyM5L
09:53GitHubPS[pageshot] bwinton opened pull request #2392: Use the npm version of pontoon-to-webext. (master...master) https://git.io/vyMdH
10:47GitHubPS[pageshot] Standard8 commented on issue #2348: I've just filed a bug on the main mochitest issues (mainly in dom/) here: https://bugzilla.mozilla.org/show_bug.cgi?id=1347482 https://git.io/vyMhN
12:14GitHubPS[pageshot] Standard8 created enable-flake8 (+1 new commit): https://git.io/vyDYI
12:14GitHubPSpageshot/enable-flake8 1f635cb Mark Banner: (chore): Add Flake8 to lint tests, change some files to have .py extensions and get flake8 passing.
12:18GitHubPS[pageshot] Standard8 force-pushed enable-flake8 from 1f635cb to 1e69605: https://git.io/vyDYZ
12:18GitHubPSpageshot/enable-flake8 1e69605 Mark Banner: (chore): Add Flake8 to lint tests, change some files to have .py extensions and get flake8 passing.
12:18GitHubPS[pageshot] Standard8 opened pull request #2393: Add flake8 lint checking of python files (master...enable-flake8) https://git.io/vyDY8
12:19travis-ciThe build has errored.: mozilla-services/pageshot#2670 (enable-flake8 - 1e69605 : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211324936
12:20GitHubPS[pageshot] Standard8 force-pushed enable-flake8 from 1e69605 to 98e4af9: https://git.io/vyDYZ
12:20GitHubPSpageshot/enable-flake8 98e4af9 Mark Banner: (chore): Add Flake8 to lint tests, change some files to have .py extensions and get flake8 passing.
12:20travis-ciThe build failed.: mozilla-services/pageshot#2669 (enable-flake8 - 1f635cb : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211324059
12:25travis-ciThe build failed.: mozilla-services/pageshot#2672 (enable-flake8 - 98e4af9 : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211325532
12:26GitHubPS[pageshot] Standard8 force-pushed enable-flake8 from 98e4af9 to a8974ef: https://git.io/vyDYZ
12:26GitHubPSpageshot/enable-flake8 a8974ef Mark Banner: (chore): Add Flake8 to lint tests, change some files to have .py extensions and get flake8 passing.
12:33travis-ciThe build was fixed.: mozilla-services/pageshot#2674 (enable-flake8 - a8974ef : Mark Banner) https://travis-ci.org/mozilla-services/pageshot/builds/211327328
16:48GitHubPS[pageshot] pdehaan commented on issue #2378: Also, not sure how other people feel about this, but when we rename IRC channel, not sure if we would maybe also want to add a #screenshots-bots channel where we move all the automated bot chatter.... https://git.io/vyDhh
16:58GitHubPS[pageshot] pdehaan opened issue #2394: Check all shebangs for consistency https://git.io/vyyvC
17:16GitHubPS[pageshot] dannycoates commented on issue #2390: I would prefer this to automatically copying the link on save. I don't appreciate how we currently clobber my clipboard without notice or option not to. Also the notification gets old after the first time. I'd rather copy the link myself. I like how github has a text box and copy button for the clone url. https://git.io/vyyk3
17:23dcoatesianbicking: i have one request regarding PRs from branches instead of forks. I tend to blindly force push to them so a ping if you make changes is appreciated :)
17:40GitHubPS[pageshot] dannycoates commented on issue #2171: We might be able to use the `browser_style` thing for this. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/browser_action https://git.io/vyym0
17:41GitHubPS[pageshot] dannycoates commented on issue #2171: We might be able to use the `browser_style` thing for this. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/browser_action... https://git.io/vyym0
17:53GitHubPS[pageshot] pdehaan commented on issue #2171: I think @ianb added the `browser_style` thing to addon/webextension/manifest.json in [#2377](https://github.com/mozilla-services/pageshot/pull/2377/files#diff-edd690115570044e76445f43adc8ba8bR28):... https://git.io/vyyOM
17:59GitHubPS[pageshot] ianb commented on issue #2171: `browser_style` won't do anything, I'm afraid, it just applies to panels. There isn't a panel, so I added it just to make a warning shut up. ... https://git.io/vyy3g
18:01ckpricedcoates: _6a68 jgruen clouserw standup?
18:01pdehaanaint no party like a pageshot party, because a pageshot party is mandatory.
18:01clouserwoh, wrong room
18:01dcoatesomw
18:01_6a68pdehaan: nicely 30 rocked
18:15GitHubPS[pageshot] ckprice pushed 1 new commit to master: https://git.io/vyyZb
18:15GitHubPSpageshot/master c819d2a Cory Price: Add domain info to acceptance
18:16GitHubPS[pageshot] ianb commented on issue #2391: This might just be a problem with the pageshot.dev server, we should confirm that first before looking locally. https://git.io/vyyZj
18:17GitHubPS[pageshot] 6a68 closed issue #2132: MacBook Pro touchbar escape key doesn't escape anything https://git.io/vMp6X
18:17GitHubPS[pageshot] 6a68 commented on issue #2132: :+1: https://git.io/vyynn
18:20GitHubPS[pageshot] ianb closed issue #2374: Should the addon and website always use the same language? https://git.io/vyP5Y
18:26GitHubPS[pageshot] ianb commented on issue #2361: We'd rather avoid this, but we should ask Release Management https://git.io/vyycD
18:26GitHubPS[pageshot] 6a68 commented on issue #2332: Grabbing a few of these prefs / initialization / disabling bugs https://git.io/vyycy
18:28GitHubPS[pageshot] 6a68 commented on issue #2269: this might also be related to pref-flipping (#2333) https://git.io/vyyCq
18:30GitHubPS[pageshot] ianb commented on issue #2389: There should be a specific event for this, like `addon/cancel-selection/toolbar-pageshot-button`... https://git.io/vyyCC
18:30GitHubPS[pageshot] 6a68 commented on pull request #2392 9774f70: Could this be an exact version number? https://git.io/vyyCl
18:30557A6SJR3[pageshot] ianb closed issue #2267: Decide what Page Shot button should do when Page Shot is active https://git.io/vynlz
18:30203A6RMEY[pageshot] ianb commented on issue #2267: This is being implemented in #2389 https://git.io/vyyC8
18:31GitHubPS[pageshot] 6a68 commented on issue #2392: thanks, @bwinton! looking now https://git.io/vyyCB
18:32GitHubPS[pageshot] 6a68 commented on issue #2392: sweet, the `make addon_locales` command works for me.... https://git.io/vyyCo
18:32GitHubPS[pageshot] pdehaan opened issue #2395: Remove all references to Test Pilot https://git.io/vyyCi
18:36_6a68ianbicking: looks like we have two open PRs from outreachy applicants
18:42GitHubPS[pageshot] pdehaan opened issue #2396: Reconsider use of alert() https://git.io/vyyWp
18:45GitHubPS[pageshot] 6a68 commented on issue #2396: :+1: we could use the notification bar for stuff users really need to see, and the browser console otherwise https://git.io/vyylr
18:49GitHubPS[pageshot] ianb commented on issue #2396: Note the alerts are all used on the web page for request errors. There might be one that is in a stubbed-out add-on function that needs to be made into a non-stub. https://git.io/vyy8G
20:04GitHubPS[pageshot] 6a68 commented on issue #2333: TL;DR: yes, you can shutdown and restart embedded webextensions, but I ... https://git.io/vyyw1
20:04GitHubPS[pageshot] 6a68 commented on issue #2333: TL;DR: yes, you can shutdown and restart embedded webextensions, but I ... https://git.io/vyyw1
20:20GitHubPS[pageshot] ianb created enabling-pref (+1 new commit): https://git.io/vyyKn
20:20GitHubPSpageshot/enabling-pref ae74549 Ian Bicking: WIP, observe prefs and control webextension startup and shutdown via a pref
20:21GitHubPS[pageshot] ianb opened pull request #2397: WIP, observe prefs and control webextension startup and shutdown via a pref (master...enabling-pref) https://git.io/vyyK4
20:21GitHubPS[pageshot] ianb commented on pull request #2397 ae74549: Of course, this is where shutdown should occur https://git.io/vyyKR
20:22GitHubPS[pageshot] ianb commented on pull request #2397 ae74549: I thought about observing the Telemetry pref here, but it's not that easy there's no way to initiate a message from bootstrap.js to the webextension. So I think the current logic for the telemetry pref is good as it is. https://git.io/vyyKg
20:22ianbicking_6a68: for handoff: https://github.com/mozilla-services/pageshot/pull/2397
20:24_6a68thanks
20:27travis-ciThe build passed.: mozilla-services/pageshot#2678 (enabling-pref - ae74549 : Ian Bicking) https://travis-ci.org/mozilla-services/pageshot/builds/211499102
20:27GitHubPS[pageshot] ianb commented on pull request #2392 9774f70: I'm sorting through PRs, I'll just land and update this part https://git.io/vyy6Y
20:28GitHubPS[pageshot] 6a68 commented on pull request #2392 9774f70: :+1: https://git.io/vyy6G
20:29GitHubPS[pageshot] ianb closed pull request #2392: Use the npm version of pontoon-to-webext. (master...master) https://git.io/vyMdH
20:29GitHubPS[pageshot] ianb pushed 3 new commits to master: https://git.io/vyy6E
20:29GitHubPSpageshot/master 9774f70 Blake Winton: Use the npm version of pontoon-to-webext....
20:29GitHubPSpageshot/master 408580f Ian Bicking: Change pontoon-to-webext dependency to exact version
20:29GitHubPSpageshot/master c7b62f1 Ian Bicking: Merge pull request #2392 from bwinton/master...
20:34GitHubPS[pageshot] ianb commented on pull request #2386 87c81d7: FreeBSD should be the same as Linux, which is maybe a good reason to test for Mac and default to Linux. On Windows the development process is probably very broken in ways I haven't even considered! https://git.io/vyyil
20:35GitHubPS[pageshot] ianb commented on issue #2385: @johngruen : does this CSS change look right to you? https://git.io/vyyi1
20:38dcoatesianbicking: should we check the telemetry pref before every sendEvent (seems a lot)? ... i see we check it on each button click but that's it (seems not enough)
20:39ianbickingdcoates: each button click seemed like enough to me then the only case when we send data and we shouldnt is if you start a Page Shot action, change the pref in the middle, and then complete the action
20:39ianbickingwhich seems like an OK corner case
20:39ianbickingdcoates: theres no good way for bootstrap.js to proactively send a message to the WebExtension (at least according to the docs)
20:40dcoatescontext menu ought to get it too i think
20:40ianbickingdcoates: :+1
20:40ianbickingthat was an inferior
20:40dcoates:)
20:41GitHubPS[pageshot] bwinton commented on commit 408580f: :+1: Thanks! https://git.io/vyyPH
20:42GitHubPS[pageshot] ianb commented on issue #2380: Is there any way to map shortlog names to GitHub usernames? It would be nice to link to their accounts. (I unfortunately don't see a way)... https://git.io/vyyPN
20:47GitHubPS[pageshot] ianb commented on pull request #2389 1ed18e0: I think this functionality isn't very important anymore. It used to be that Page Shot could be active on a page without the overlay in place, so you could navigate away and that would cancel the shot. This happened naturally, except on sites like github.com where they use window.history to change the page in-place even when it appears to be a navigation.... https://git.io/vy
21:01GitHubPS[pageshot] ianb commented on pull request #2389 1ed18e0: We'll just have to be sure that we don't have any functions with implicitly optional last arguments. Which, on consideration... we do! `sendEvent` works this way.... https://git.io/vyyMd
21:03GitHubPS[pageshot] wresuolc opened issue #2398: Ensure the website does not send stats if DNT is enabled https://git.io/vyyD3
21:04GitHubPS[pageshot] wresuolc opened issue #2399: Ensure the add-ondoesn't send analytics data if "Share Additional Data (i.e., Telemetry)" option is not checked https://git.io/vyyDu
21:05GitHubPS[pageshot] ianb opened issue #2400: Remove fixup_panel.py https://git.io/vyyDr
21:07GitHubPS[pageshot] ianb commented on pull request #2393 a8974ef: This could be `$(VENV)/bin/pip install -r bin/require.pip` https://git.io/vyyyq
21:07GitHubPS[pageshot] ianb pushed 1 new commit to master: https://git.io/vyyyY
21:07GitHubPSpageshot/master 256d58a Ian Bicking: Merge pull request #2393 from mozilla-services/enable-flake8...
21:08GitHubPS[pageshot] ianb deleted enable-flake8 at a8974ef: https://git.io/vyyyO
21:08GitHubPS[pageshot] garbados commented on issue #2386: Thanks for the feedback! I made changes responding to the review. Anything else to do on my end? https://git.io/vyyyZ
21:09ianbickinghuh, I dont understand this build failure result, is it just wedged? https://circleci.com/gh/mozilla-services/pageshot/100?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
21:11GitHubPS[pageshot] ianb opened issue #2401: Add install step to CircleCI https://git.io/vyyyS
21:12GitHubPS[pageshot] ianb commented on issue #2386: Looks good, thanks! https://git.io/vyySL
21:12557A6SLWS[pageshot] ianb pushed 5 new commits to master: https://git.io/vyySq
21:12557A6SLWSpageshot/master 0b6cd78 Diana Thayer: first commit; 'works on my machine'; needs tests
21:12557A6SLWSpageshot/master 87c81d7 Diana Thayer: cleanup in advance of PR
21:12557A6SLWSpageshot/master ff3f3a0 Diana Thayer: response to review
21:12GitHubPS[pageshot] ianb closed pull request #2386: WIP solution to issue#2315 (master...issue-2315) https://git.io/vyMTd
21:18GitHubPS[pageshot] pdehaan commented on issue #2365: @Standard8: One small question. I seem to be stuck in [eslint-plugin-mozilla/lib/environments/places-overlay.js](http://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/places-overlay.js#20):... https://git.io/vyy97
21:20dcoatesianbicking: i rebuilt, it worked. :shrug:
21:21ianbickingprobably a network problem on npm install then
21:23GitHubPS[pageshot] 6a68 commented on issue #2333: According to kmaglione, we should create a new instance, rather than restart a webextension that's been shutdown.... https://git.io/vyyHo
21:28GitHubPS[pageshot] pdehaan commented on issue #2365: @Standard8: One small question. I seem to be stuck in [eslint-plugin-mozilla/lib/environments/places-overlay.js](http://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/places-overlay.js#20):... https://git.io/vyy97
21:40dcoatesianbicking: all our calls to `communication.register` pass a wrapper function. we could move `sender` to be the *first* argument by convention
21:40ianbickingdcoates: we could. That would be fine I think
21:43GitHubPS[pageshot] pdehaan commented on issue #2365: As close as I can figure, here's the mozilla-central [_.eslintrc.js_ config file](https://hg.mozilla.org/mozilla-central/file/tip/.eslintrc.js):... https://git.io/vyiFG
22:00ckpriceare these instructions still good? https://github.com/mozilla-services/pageshot#installation-and-setup
22:00ckpricewhen i `run add-on`, firefox is started, but the add-on isn't installed
22:00ianbickingckprice: you are doing ./bin/run-addon ? Open the Browser console and see if theres an error?
22:07GitHubPS[pageshot] dannycoates commented on pull request #2389 1ed18e0: I'm gonna move `sender` to be the first argument. The `register`ed callback will change signature to `(sender, ...args)` https://git.io/vyybD
22:25GitHubPS[pageshot] ianb created remove-dead-code (+3 new commits): https://git.io/vyyxT
22:25GitHubPSpageshot/remove-dead-code 4446ad4 Ian Bicking: Fix #2379, review shared/ and remove obsolete module
22:25GitHubPSpageshot/remove-dead-code 484343f Ian Bicking: Remove fixup_panel_js.py, which was a remnant of the SDK and jumping through AMO signing hoops
22:25GitHubPSpageshot/remove-dead-code d50b7aa Ian Bicking: Fix #2369, remove deviceInfo from the stored registration info....
22:25GitHubPS[pageshot] ianb opened pull request #2402: Remove dead/unneeded code (master...remove-dead-code) https://git.io/vyyxt
22:26ianbickingnot a productive day, but had to do *something*
22:30travis-ciThe build passed.: mozilla-services/pageshot#2685 (remove-dead-code - d50b7aa : Ian Bicking) https://travis-ci.org/mozilla-services/pageshot/builds/211540070
23:03GitHubPS[pageshot] 6a68 commented on issue #2333: My approach to building the jar URI seems to be correct, or at least, that same approach is used [in some Firefox tests](https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ExtensionTestCommon.jsm#345). https://git.io/vySeP
23:05GitHubPS[pageshot] 6a68 commented on issue #2333: I think `self.id` could be used in place of the addon's name, which would let this skate around any impending mass name changes. https://git.io/vySe5
23:36dcoatesckprice: i had that problem on nightly. opening once with my default profile, then using ./bin/run-addon worked for me. ymmv
23:52GitHubPS[pageshot] 6a68 pushed 2 new commits to enabling-pref: https://git.io/vyST8
23:52GitHubPSpageshot/enabling-pref 87a73d2 Jared Hirsch: Gecko style nits
23:52GitHubPSpageshot/enabling-pref c0e6eb7 Jared Hirsch: WIP toggle webextension when pref changes
23:52GitHubPS[pageshot] dannycoates pushed 1 new commit to toggle-button: https://git.io/vyST4
23:52GitHubPSpageshot/toggle-button 1f2b083 Danny Coates: addressed PR #2389 comments
23:55GitHubPS[pageshot] dannycoates commented on issue #2389: Thanks @ianb, new commit addresses those changes. https://git.io/vyST9
23:56GitHubPS[pageshot] 6a68 force-pushed enabling-pref from c0e6eb7 to 805baa9: https://git.io/vySTp
23:56GitHubPSpageshot/enabling-pref 805baa9 Jared Hirsch: WIP toggle webextension when pref changes
23:58GitHubPS[pageshot] 6a68 force-pushed enabling-pref from 805baa9 to 066da49: https://git.io/vySTp
23:58GitHubPSpageshot/enabling-pref 066da49 Jared Hirsch: WIP toggle webextension when pref changes
23:58travis-ciThe build was broken.: mozilla-services/pageshot#2687 (enabling-pref - c0e6eb7 : Jared Hirsch) https://travis-ci.org/mozilla-services/pageshot/builds/211564776
16 Mar 2017
No messages
   
Last message: 158 days and 14 hours ago