mozilla :: #mozreview

17 May 2017
01:54glandiumthere's something wrong with autoland:
01:54firebotBug 1365182 NEW, When both clang and gcc are installed via tooltool, pick libstdc++ from gcc
04:31globglandium: there were two requests to land that change
04:32globyou, then nfroyd 22 minutes later (while your request was still in the queue)
04:32globi'll file a bug to detect duplicate requests
04:35globoh, the timings are way off; nfroyd's request was 9 hours before yours, which casts doubt on "duplicate request in flight" theory
04:35mcotethe autoland branch *was* closed for a really long time today
04:36glandiumglob: autoland was closed for a while
04:36globthanks, that makes sense
04:36* glob continues to file
04:37* mcote wonders if this should go into lando-api eventually
04:38globmcote: perhaps eventually. but it's an easy thing to do in autoland, which already knows the state of all the parts
04:39mcoteyeah no objection to doing it now
04:39mcoteI can see two levels of these kinds of checks
04:40globyup; like client/server checks. client-side (lando) to respond immediately and make the ui reflect state, server-side (transplant) to enforce
04:41mcotei'm thinking more in terms of job management
04:41mcotei think that'll be part of lando-api
04:41mcoteso in that sense two jobs doing the same thing should be handled some (user-friendly) way
04:42mcotetransplant can also detect that and deal with the problem in a more abrupt way, just discarding the dupe job and logging an error
04:49globbug 1365487
04:49firebot NEW, detect and reject identical in-flight requests
17:51pulsebotCheck-in: - Gregory Szorc - pash: use shlex.split() for obtaining command arguments (bug 1353499); r=glob
17:51pulsebotCheck-in: - Gregory Szorc - pash: avoid re-assigning args variable (bug 1353499); r=glob
17:51pulsebotCheck-in: - Gregory Szorc - pash: rewrite hg command parsing (bug 1353499); r=glob
17:56mozreview-deploy-botProduction deployment of MozReview initiated from rev 8b32413e03a8
17:58pulsebotCheck-in: - Gregory Szorc - pash: remove unnecessary strip()
17:58pulsebotCheck-in: - Gregory Szorc - pash: more tests with quotes
17:59gpscancelled deploy after reviewboard-hg
18:11pulsebotCheck-in: - Gregory Szorc - ansible/hg-ssh: adjust file permissions in rsync
20:01mystorCan I pull a patch off of reviewboard to rebase it on top of the current trunk?
20:02KWiersomystor: there should be a box with an "import" command available to copy/paste
20:04mystorKWierso: Is there a similar thing for if I'm using cinnabar?
20:04mystorKWierso: Or can I add the reviewboard repo as a cinnabar remote?
20:07* mystor is just super unfamiliar with hg
20:07KWiersoI've never even considered using cinnabar, can't help you there
20:07mystorAt least now I know it's _possible_ and the only challenge is doing it :P
20:08KWiersothe truth/patch is out there
20:09KWiersomaybe with glandium?
21:08glandiummystor: git cinnabar fetch hg::hg-reviewboard-url sha1
21:21mystorglandium: Thanks :)
18 May 2017
No messages
Last message: 93 days and 5 hours ago