mozilla :: #min-vid

13 Jul 2017
09:32GitHub192[min-vid] greenkeeper[bot] created greenkeeper/react-player-0.19.0 (+1 new commit): https://git.io/vQ9Pm
09:32GitHub192min-vid/greenkeeper/react-player-0.19.0 1d1dca3 greenkeeper[bot]: chore(package): update react-player to version 0.19.0...
18:25JSON_voorhees_6a68: Think I just ran into another snag
18:25_6a68o hai
18:25JSON_voorheeswith using fetch in the webextension to hit the youtube api
18:26JSON_voorhees_6a68: how you doing?
18:26JSON_voorheesI should push, lol haven't done that in a while
18:26_6a68aight, screenshots / firefox drama is back at full roar
18:26_6a68this very minor change in how we shut down the extension didn't get included in the last export, and apparently, now that webextensions are out of the main process, we crashed the thread
18:27_6a68instead of "if (webext.started) { shutdown}" it has to be just "shutdown"
18:27_6a68life on the bleeding edge is bloody
18:27GitHub45[min-vid] meandavejustice pushed 1 new commit to sdk-to-webextension: https://git.io/vQHQb
18:27GitHub45min-vid/sdk-to-webextension 163afa9 Dave Justice: moving more stuff into webextension, attempt setup messaging
18:27_6a68so what's wrong with fetch? need it to be cancelable?
18:27JSON_voorheesyikes
18:27JSON_voorheeslooks like a cors issue
18:28JSON_voorheestrying to figure out why soundcloud isn't working either
18:29JSON_voorheesI'm just trying to get it to the point where I can figure out if window messaging will work right, then I'll feel a little less anxious
18:29JSON_voorheesWhat are yall doing about screentshots?
18:43JSON_voorheesOh nice, I miht be able to just replace it with webrequest https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webRequest
19:07JSON_voorheesnm that's not what I thought it was
19:52_6a68hmm, can't you pass CORS headers to fetch?
19:53_6a68mode: 'cors', then put headers in the headers key
19:54_6a68where's the code that's failing?
19:55JSON_voorheeshttps://gist.github.com/meandavejustice/f7498ad5c50fdff79447f2b05ab4c177
19:55JSON_voorheesI'll link u
19:58GitHub141[min-vid] meandavejustice force-pushed sdk-to-webextension from 163afa9 to 1e225c3: https://git.io/vQQUo
19:58GitHub141min-vid/sdk-to-webextension 1e225c3 Dave Justice: moving more stuff into webextension, attempt setup messaging
19:59JSON_voorhees_6a68: https://github.com/meandavejustice/min-vid/blob/sdk-to-webextension/webextension/lib/youtube-helpers.js#L12
20:01_6a68really weird that that's failing now
20:02_6a68JSON_voorhees: wait, "(Reason: CORS header Access-Control-Allow-Origin missing)."
20:02_6a68try adding a headers property to the fetch options with that missing header
20:04_6a68headers: {'Access-Control-Allow-Origin': '*'}?
20:04JSON_voorheesOh okay
20:04JSON_voorheesI was thinking that was in their htaccess
20:05JSON_voorheesI gotta grab some food, I'm starving, I'll be back soon
20:05JSON_voorheesI'll let u know if that works
20:06_6a68cool man
22:16JSON_voorheesneeded to add a permission to manifest
22:16JSON_voorhees<all_urls>
22:16JSON_voorheesthat did the trick :)
22:42GitHub190[min-vid] meandavejustice pushed 1 new commit to sdk-to-webextension: https://git.io/vQQgY
22:42GitHub190min-vid/sdk-to-webextension 9cc77be Dave Justice: youtube and sc requests working again
22:48_6a68ah, right
14 Jul 2017
No messages
   
Last message: 10 days and 18 hours ago