mozilla :: #mdndev

7 Sep 2017
00:09rjohnsonstandups: short meeting w/meta.dave, submitted changes to https://github.com/mozilla/kuma/pull/4401 to make it ready for final review
00:09rjohnsoni'm off to my daughter's back-to-school night, good night everyone!
00:13shobsonI'm off. G'night all.
08:17interactive-examp[interactive-examples] schalkneethling opened pull request #270: Cleans up JS examples HTML by removing class attribute (master...cleanup-js-examples-class) https://git.io/v5wW2
08:17557A8IZXA[interactive-examples] schalkneethling pushed 2 new commits to master: https://git.io/v5wWV
08:17557A8IZXAinteractive-examples/master 8a3c7a5 schalkneethling: Cleans up JS examples HTML by removing class attribute
08:17557A8IZXAinteractive-examples/master 659a08d Schalk Neethling: Merge pull request #270 from schalkneethling/cleanup-js-examples-class...
08:17203BAACMO[interactive-examples] schalkneethling closed pull request #270: Cleans up JS examples HTML by removing class attribute (master...cleanup-js-examples-class) https://git.io/v5wW2
08:19interactive-examp[interactive-examples] schalkneethling force-pushed prod from e84c62f to 2268a26: https://git.io/v7gQT
08:19interactive-exampinteractive-examples/prod 2268a26 schalkneethling: Deploying latest generated pages
13:49jwhitlockgood morning #mdndev
14:18jwhitlockstandups: reviewed PR 4401, adding views for shipped git commit and sitemaps
14:40jwhitlockstandups: quick review of two kumascript PRs, needing some tests and additional work
14:41jwhitlocknow what did I say I'd do yesterday...
14:42* jwhitlock looks at functional tests
15:00interactive-examp[interactive-examples] maboa opened pull request #271: global properties (master...global-property-examples) https://git.io/v5rLF
15:01rjohnsongood morning mdndev!
15:28rjohnsonstandups: submitted organizational changes to https://github.com/mozilla/kuma/pull/4401 per review feedback (waiting for tests to pass before merging)
16:14interactive-examp[interactive-examples] schalkneethling opened pull request #272: Fix issue #119, refactor and code cleanup (master...issue#119-refactoring-cleanup) https://git.io/v5rli
16:14interactive-examp[interactive-examples] schalkneethling pushed 2 new commits to master: https://git.io/v5rl1
16:14interactive-exampinteractive-examples/master d1c71a0 schalkneethling: Fix issue #119, refactor and code cleanup
16:14interactive-exampinteractive-examples/master 41fe666 Schalk Neethling: Merge pull request #272 from schalkneethling/issue#119-refactoring-cleanup...
16:16interactive-examp[interactive-examples] schalkneethling force-pushed prod from 2268a26 to 56ce109: https://git.io/v7gQT
16:16interactive-exampinteractive-examples/prod 56ce109 schalkneethling: Deploying latest generated pages
16:26jwhitlockwow functional tests just stall for no reason
16:29rjohnsonjwhitlock: wow...just a guess, but maybe you don't have the latest chrome driver?
16:29jwhitlockjust downloaded it today
16:53jwhitlockSeems to be more reliable against remote server developer.allizom.org than localhost:8000
16:58fscholzI've published v0.0.5 https://www.npmjs.com/package/mdn-browser-compat-data
16:58jwhitlockfscholz: any other coordination work for the prod push?
16:59fscholzjwhitlock: not this time, just more data and doc fixes :)
17:00fscholzhttps://github.com/mdn/browser-compat-data/compare/v0.0.4...v0.0.5
17:03jwhitlockah and better if I'm not running my single threaded server for debugging :)
17:04rjohnsonah! that makes sense! :)
17:08rjohnsonfor https://github.com/mozilla/kuma/pull/4401 i did some "simple" reorg, and of course nothing is simple, as the tests of the sitemap urls have been failing, i think due to an import order issue which now causes the overridden settings in the tests to be ignored
17:09jwhitlockrjohnson: https://github.com/mozilla/kuma/pull/4401#pullrequestreview-61286682 ?
17:10rjohnsonjwhitlock: i had already fixed that before i saw your note, thanks though...i should commit my latest so you can see
17:12jwhitlockno rush
17:12* jwhitlock goes back to flaky functional tests
17:12sheppyjwhitlock: Getting an error before execution even begins. It's fun! :)
17:13sheppyOne of those annoying TemplateLoadingError messages that means you have a typo somewhere, basically :)
17:13jwhitlock"make lint-macros" may help
17:14sheppyHm, nope.
17:15sheppyhttps://www.irccloud.com/pastebin/lkhHUFev/
17:16jwhitlockin kuma directory, "make build-kumascript"
17:16jwhitlockthen try again
17:16sheppyoh-ho
17:24sheppyHm. If make lint-macros doesn't report errors, but I get a syntax error at runtime, wtf does that mean? :)
17:31jwhitlock\_()_/
17:32jwhitlockoh fun the functional tests are triggering a survey
17:32rjohnsonlol
18:41jwhitlockfinally
18:43jwhitlockrjohnson: I think we have to start the push with what we already have merged
18:44rjohnsonjwhitlock: ok, i may need a rubber ducky later, i'm so frustrated
18:45metadavewhere are the mdn prod mysql creds stored?
18:45TopalI filed bug 1397858. Thanks again, John
18:45firebothttps://bugzil.la/1397858 NEW, nobody@mozilla.org increase siteSpeedSampleRate to 100%
18:45jwhitlockin SCL3? in a local settings file.
18:46metadaveif I wanted to test out a backup against the readonly DB, which creds would I use?
18:46jwhitlockI have specific creds for my user - just a sec
18:50jwhitlockmetadave: there's no mysql account for you at the moment. seeing if I have perms to add one
18:50metadaveok, thankyou jwhitlock
18:53jwhitlocknope, we'll need DB admin to add a user
18:54jwhitlocklet me see if other creds will work for today
18:55metadavejwhitlock: https://bugzilla.mozilla.org/show_bug.cgi?id=1397850 access from developeradm to mdntools-rw-vip.db has been opened up
18:55firebotBug 1397850 NEW, network-operations@mozilla-org.bugs Connectivity to MDN prod database
18:56jwhitlocknice, I can connect to the R/O DB from the admin node. thanks for making that request
18:57metadavethe aws client is installed there as well
18:57metadaveand can access S3
18:57metadave(depending on the account used)
18:57metadaveI'll request a MySQL account. Should I specify an account to base it from?
19:02jwhitlockI'm going to see if I can find the bug where we got an account for Topal, jswisher, etc.
19:04Topaljwhitlock: https://bugzilla.mozilla.org/show_bug.cgi?id=1274277
19:04firebotBug 1274277 FIXED, rwatson@mozilla.com Give MDN team members access to production data
19:04jwhitlockthanks
19:04Topalnp!
19:04jwhitlockmetadave: I think you should open a new bug with your requirements, and reference that one
19:04metadavewill do, thanks so much!
19:05jwhitlockhttps://bugzilla.mozilla.org/show_bug.cgi?id=1274277#c5 is where I said I won't need access from developeradm :/
19:05jwhitlockbugzilla remembers all
19:05metadavehaha
19:08rjohnsonok, going to step away from my @#@$!$@! failing test and get some lunch
19:20jwhitlockstandups: got function tests working in PR 4414
19:48jwhitlockthanks!
19:48mdnstagepushwoot, jwhitlock is pushing mdn-stage a33e8bad0e7941126ac3e74f1303a9c5fc791e6d
19:48mdnstagepushwatching http://developeradm.private.scl3.mozilla.com/chief/developer.stage/logs/a33e8bad0e7941126ac3e74f1303a9c5fc791e6d.1504813714
19:48mdnstagepushhttps://github.com/mozilla/kuma/compare/e669520bc6c4cc7e6659adb300ee87679a9620e9
19:48mdnstagepush...a33e8bad0e7941126ac3e74f1303a9c5fc791e6d
19:50jwhitlockthis push has bug 1395750, bug 1397023, bug 1387252, bug 1370594, and the interactive examples URL stuff (no bug)
19:50firebothttps://bugzil.la/1395750 NEW, rjohnson In Jenkins, for both kuma and kumascript, generate revision hash and store in Docker image (for AWS)
19:50firebothttps://bugzil.la/1397023 FIXED, shobson Add background colour to inline code tags.
19:50firebothttps://bugzil.la/1387252 FIXED, shobson Operators in code sample <pre> blocks have a lighter gray background than all other text
19:50firebothttps://bugzil.la/1370594 FIXED, shobson Update MDN to reflect new Mozilla brand
19:50jwhitlockI&#39;ll be back in 20-30 min for manual testing
19:50mdnstagepushFinished: setup_dependencies (138.835s)
19:50mdnstagepushthe push is now going to the webheads!! (a33e8bad0e7941126ac3e74f1303a9c5fc791e6d jwhitlock)
19:51mdnstagepushFinished: update_info (2.097s), pre_update (145.160s)
19:52mdnstagepushFinished: update_assets (93.288s)
19:52mdnstagepushFinished: update_locales (12.328s), database (2.852s), update (108.469s)
19:52mdnstagepushFinished: rsync_project (4.431s), checkin_changes (4.466s)
19:52mdnstagepushFinished: deploy_app (3.210s), restart_web (1.502s)
19:53mdnstagepushFinished: restart_kumascript (19.295s)
19:53mdnstagepushjwhitlock pushed mdn-stage a33e8bad0e7941126ac3e74f1303a9c5fc791e6d
19:53mdnstagepushFinished: restart_celery (13.165s), ping_newrelic (0.359s), deploy (42.000s)
20:08rjohnsonok, i stopped banging my head against the wall, and decided to walk around it, fix coming for https://github.com/mozilla/kuma/pull/4401 after confirming that all tests run
20:09rjohnsonthe good news is that my afternoon is guaranteed to be better than my morning! :)
20:22metadavecreating an encrypted, gzipped backup in SCL3 took 14 minutes, followed by a 26 second transfer to a private S3 bucket
20:22jwhitlockmetadave: much faster
20:22metadavey
20:22metadaveI&#39;m going to play around with it a bit more
20:22metadaveand document etc
20:23jwhitlockPR 4400 was to fix typography demoed here - https://developer.allizom.org/en-US/docs/User:stephaniehobson:code#This_is_a_heading_with_a_code_tag_in_it_%3Chtml%3E._Lorem_codeipsum_kbd_dollar_sit_amet
20:23jwhitlockand here
20:23jwhitlockhttps://developer.allizom.org/en-US/docs/Learn/JavaScript/Objects/Object_prototypes#A_prototype-based_language
20:24jwhitlocklooks OK to me
20:27jwhitlockalso, no visible impact in NR while taking the backup
20:36metadave
20:36jwhitlockgoing to production
20:37jwhitlockpush song is I Will Survive, (Happy Birthday Gloria Gaynor) https://youtu.be/ZBR2G-iI3-I
20:37mdnprodpushoh cool, jwhitlock is pushing mdn a33e8bad0e7941126ac3e74f1303a9c5fc791e6d
20:37mdnprodpushwatching http://developeradm.private.scl3.mozilla.com/chief/developer.prod/logs/a33e8bad0e7941126ac3e74f1303a9c5fc791e6d.1504816635
20:37mdnprodpushFinished: update_code (13.249s)
20:38rjohnsonjwhitlock: should i hold off on merging https://github.com/mozilla/kuma/pull/4401 until after the push?
20:38jwhitlockno, go ahead
20:39rjohnsonok, thanks
20:40rjohnsonstandups: burned my morning fixing the tests for https://github.com/mozilla/kuma/pull/4401, finally merged
20:42mdnprodpushFinished: setup_dependencies (314.411s)
20:42mdnprodpushthe push is now going to the webheads!! (a33e8bad0e7941126ac3e74f1303a9c5fc791e6d jwhitlock)
20:42mdnprodpushFinished: update_info (5.544s), pre_update (333.205s)
20:44mdnprodpushFinished: update_assets (119.744s)
20:45mdnprodpushFinished: update_locales (11.291s)
20:45mdnprodpushFinished: database (2.987s), update (134.022s)
20:45mdnprodpushFinished: rsync_project (13.849s), checkin_changes (13.881s)
20:45mdnprodpushFinished: deploy_app (17.792s)
20:45mdnprodpushFinished: restart_web (11.460s)
20:45rjohnsonstandups: added comment to and merged https://github.com/mozmeao/infra/pull/455
20:46mdnprodpushFinished: restart_kumascript (18.511s)
20:46mdnprodpushjwhitlock pushed mdn a33e8bad0e7941126ac3e74f1303a9c5fc791e6d
20:46mdnprodpushFinished: restart_celery (13.505s), ping_newrelic (0.329s), deploy (75.480s)
20:48jwhitlockstandups: pushed to production
20:53rjohnsonstandups: reviewed and merged https://github.com/mozilla/kuma/pull/4412
20:54jwhitlockthanks!
20:54rjohnsonjwhitlock: i should have reviewed and merged before your push, sorry! :(
20:54jwhitlockwe&#39;ll get it next time
21:02rjohnsonstabdups: reviewed and merged https://github.com/mozilla/kuma/pull/4413 (thanks for going above and beyond by doing this jwhitlock!)
22:13jwhitlockthat&#39;s it for me today - good night #mdndev
22:13rjohnsongood night!
23:45sheppyrjohnson: Do I remember seeing something about subpagesExpand being broken at some point but now fixed? Is that true and if so that&#39;s landed?
23:45* sheppy is getting unexpected results from it :)
23:47rjohnsonsheppy: yes! it has been released. you&#39;ve probably already done so, but &quot;docker-compose pull&quot; to get latest images
23:47sheppyYeah, I have.
23:47sheppyWhat was the problem?
23:47sheppyWhen did it release, I should ask.
23:47rjohnsonlet me refresh my memory...
23:48sheppyhm
23:48rjohnsoni can barely remember what i did yesterday! :)
23:49sheppyrotfl
23:54rjohnsonsheppy: it looks like it was pushed to master on july 25 (which is all you need for local dev), see https://github.com/mdn/kumascript/pull/241
23:55sheppyHm, okay
23:55rjohnsonsheppy: what problems are you seeing?
23:56sheppyWell, I&#39;m still not entirely sure it&#39;s not my own fault, although I&#39;m starting to run out of things to check. But I&#39;m getting the subpages list for a page on the sample DB and getting fewer pages than it seems like I should be, even with the smaller page set. Pages I expect to be there and know are present aren&#39;t showing up. Not sure why yet.
23:57rjohnsonsheppy: ok, yeah that probably is not related to https://github.com/mdn/kumascript/pull/241
23:58sheppyNope
23:59rjohnsonsheppy: that pr only makes sure you actually hit the internal &quot;api&quot; service, instead of trying to hit http://localhost:8000 and getting no results (because the services within docker-compose don&#39;t know anything about localhost)
8 Sep 2017
No messages
   
Last message: 14 days and 45 minutes ago