mozilla :: #developers

18 Mar 2017
00:02pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/1da903d4071b - Jeff Gilbert - Bug 1347679 - Determine ContextProfile from driver and simplify version parsing. - r=daoshengmu
00:14xidornAryx: I cannot access my laptop at the moment... so probably Manishearth or bholley could help
00:15xidornthat should just be changing some annotations
00:22pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/a8caa66acbfc - Matthew Wein - Bug 1338525 - Add schema validation for webextension themes r=mikedeboer,mossop
00:22pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/0232885afcb2 - Matthew Wein - Bug 1338525 - Add test coverage for theme validation r=mikedeboer
00:31bholleyxidorn: on it
00:31xidornbholley: thanks
00:33pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/42f7c37bd492 - Bobby Holley - Bug 1341102 - Update expectations after merge of #16006. r=me
01:09ewongany sheriffs around by any chance?
01:20pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb3c323635d6 - Ehsan Akhgari - Bug 1347400 - Add telemetry for imgLoader::LoadImage(); r=mystor,francois
01:31heycamhow can I make my NS_ASSERTIONs show symbols instead of addresses? (on linux)
01:45pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b2f781a18186 - Masayuki Nakano - Bug 1348195 nsRange should set mCalledByJS to false before calling Selection::NotifySelectionListners() because non-*JS() methods may be called during a call of it r=smaug
01:46pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/916023361969 - Masayuki Nakano - Bug 1347073 Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this r=smaug
02:02tedheycam: pipe it through one of the fix_stack scripts
02:02ted(that's what the test harnesses do)
02:02tedfitzgen: pong, if you're still around until i wander back off...
02:02heycamted: ah ok. is it just a known problem that we can't get already symbolicated stack traces on linux?
02:02tedheycam: i dunno, it's just Always Been That Way?
02:03heycamok
02:14kentuckyfriedtakaheabr: I heard that
02:52KWierso|afkewong: still need something?
02:52ewongKWierso|afk: just a clarification as to why I'm getting a busted Gecko Decision in https://treeherder.mozilla.org/#/jobs?repo=try&revision=7076d77b452ac5e4d37f2b6cfa2ee2fa6da2e881
02:55KWierso|afkewong: huh. no clue. Maybe ask in #l10n or #releng ?
02:55ewongKWierso|afk: thanks.
02:55KWierso|afkthat log isn't very helpful, either
03:03KWierso|afkewong: #taskcluster is another option, though none of them are great options on a friday night
03:03ewongKWierso|afk: yeah.. kinda thought so. I'm just hoping it's nothing serious.
03:03ewongwill wait and see
03:03ewongKWierso|afk: thanks!
03:50pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/110af17e4c5e - Boris Chiou - Bug 1348322 - Fix the initial values of gVelocityCurveFunction. r=kats
06:02pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3fe293265020 - Bobby Holley - servo: Merge #16015 - Box more specified values to bring SpecifiedValue/PropertyDeclaration sizes down to 24/32 bytes (from bholley:box_more_properties); r=Manishearth
07:59pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/127cb15515fb - Cameron McCormack - Bug 1348493 - Clear ServoElementData from canvas custom content's during-PresShell-destruction clones. r=bholley
08:02pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f85eb6b49794 - Cameron McCormack - Bug 1346623 - Part 1: Prevent canvas custom content from becoming NAC when reframing the root element. r=bholley
08:02pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f5a5a605ae82 - Cameron McCormack - Bug 1346623 - Part 2: Add an API to get computed style values through an AnonymousContent object. r=bholley
08:02pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/cfe58f9ace35 - Cameron McCormack - Bug 1346623 - Part 3: Test. r=bholley
08:20pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/fa214885f96f - Cameron McCormack - Bug 1347838 - stylo: Don't resolve images in nsStyleContentData objects twice. r=manishearth
10:41pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/cf88b5709261 - Cameron McCormack - Bug 1330843 - Allow JS to create NAC pseudo-elements. r=bholley
10:58pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d5f899fa1771 - Federico Padua - Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". r=Dexter
12:00pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/32dbe106b561 - L10n Bumper Bot - Bumping Fennec l10n changesets a=l10n-bump
14:25pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d3b8e1e42ff5 - Emilio Cobos lvarez - servo: Merge #16022 - stylo: Add a build log mechanism (from emilio:stylo-build-log); r=upsuper
14:31acemanhi, when clicking an item in a menupopup, is there a way to prevent closing the menupopup?
14:32acemanthere is a command handler function specified on the parent menulist
14:37acemanI tried event.stopPropagation() and also event.preventDefault() from inside the handler function
14:59pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f08f950287 - Edgar Chen - Bug 1347634 - GetCustomElementData and SetCustomElementData don't need to be virtual; r=smaug
15:00pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/c26ba7b0c8df - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-034 - a=hsts-update
15:00pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/035fb01aae64 - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-034 - a=hpkp-update
15:00pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-aurora/rev/83040ff71fcc - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-023 - a=hsts-update
15:00pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-aurora/rev/9df61b09aa1c - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-023 - a=hpkp-update
15:01pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/e02c7b72a4e9 - Emilio Cobos lvarez - servo: Merge #16023 - style: Fix some nits (from emilio:nits); r=emilio
15:04pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr45/rev/921a04655237 - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-033 - a=hsts-update
15:04pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr45/rev/5c9a98ade5e6 - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-033 - a=hpkp-update
15:07pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/ef4b3a006621 - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-022 - a=hsts-update
15:07pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/22d67a28c77b - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-022 - a=hpkp-update
15:16pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=31516&endID=31517 - 49 changesets - merge autoland to mozilla-central. r=merge a=merge
15:25pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=31517&endID=31518 - 55 changesets - merge mozilla-inbound to mozilla-central. r=merge a=merge
15:27pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=88186&endID=88187 - 53 changesets - merge mozilla-central to mozilla-inbound. r=merge a=merge
15:36pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/pushloghtml?startID=39116&endID=39117 - 59 changesets - merge mozilla-central to autoland. r=merge a=merge
15:55pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/6436030e3e63 - Ehsan Akhgari - Bug 1348452 - Give createImageBitmap() an implicit JSContext*; r=baku
15:55pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/a034f667da3b - Ehsan Akhgari - Bug 1348464 - Avoid two virtual calls in NS_URIChainHasFlags(); r=mcmanus
16:47pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3679b95b3b46 - Jeremy Chen - Bug 1348236 - coding style fixes for nsAutoScrollTimer and its uses in nsSelection. r=heycam
16:47pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/4f1f7620b616 - Jeremy Chen - Bug 1348236 - label nsAutoScrollTimer for nsSelection. r=heycam
17:14pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed933de5aa16 - Ehsan Akhgari - Backout bug 1348464 for leaks
17:44pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/145f874ee97a - Mats Palmgren - Bug 1347979 - Don't call methods that may flush in nsRange::GetInnerTextNoFlush. r=smaug
19:43pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d4b4dfe0de64 - George White - servo: Merge #16024 - Add parsing/serialisation for 'grid-auto-flow' (from Wafflespeanut:gal); r=Wafflespeanut
20:43pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/a60007195df5 - Nihanth Subramanya - Bug 1341742 - Split secondary action for push notification permission prompt into "not now" and "never". r=johannh
21:22pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/b316fdd7d8fc - Timothy Nikkel - Bug 1346121. In ScrollFrameHelper::DecideScrollableLayer we should check for a displayport again after we call MaybeCreateDisplayPort. r=botond
21:25pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/dacb6daafa3a - Nazm Can Altnova - servo: Merge #16028 - Stylo: Add support for -moz-* pseudo-classes for alt text (from canaltinova:pseudos-for-alt); r=Manishearth
22:09pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f34476fa83fa - Nazm Can Altnova - Bug 1341642 - Update test_selectors.html for better test coverage and update test expectations r=Manishearth
22:16hashharI have a question regarding the Bookmark Manager (places.xul) component. Is it appropriate here?
22:19hashharg1
22:34ajaRIP Chuck Berry, and Long Live Rock N Roll
22:35Aryx|mobileyes
22:37hashharOk. So why is the column picker not enabld in the Bookmark Manager (places.xul) by default?
22:37hashharhttp://imgur.com/a/iTDf9
22:38hashharSee the two images. One of them has a thing under my mouse pointer which allows me to select which columns to show. (I had to enable that by changing an attribute in places.xul)
22:40Aryx|mobilei am on mobile and cant check at the moment
22:54bholleyfroydnj: you around?
22:54froydnjbholley: kind of, what's up?
22:54bholleyfroydnj: did you know that PLD hashtable lookups mutate the table?
22:54* bholley had no idea
22:55bholleyhttp://searchfox.org/mozilla-central/rev/c9f5cc6b4593d461e87a6221dc0286b3859fd515/nsprpub/lib/ds/plhash.c#149
22:56bholleyfroydnj: so my main question is whether I'm correct that this is just a little optimization, and if so, whether I can modify that code to check whether we're in the servo traversal, or if touching NSPR in that way is still verboten
22:57froydnjbholley: O.o the XPCOM pldhash?
22:58bholleyfroydnj: oh wait, I guess this is PLHash
22:58froydnjbholley: mutate how?
22:58bholleyfroydnj: it rearranges the table on hit
22:58bholleyfroydnj: see the link above
22:58bholleyfroydnj: as an optimization for lookups, I think
22:59bholleyfroydnj: (but I realize now that PL_Hash is different from PLDHashTable
22:59froydnjbholley: this is causing problems for bhackett's race detector?
22:59bholleyfroydnj: yes
23:00bholleyfroydnj: maybe I should just change the hashtable we use for the undisplayed contents map
23:00bholleyfroydnj: there are better hashtables now, right?
23:00froydnjbholley: who is still using plhash?!
23:00bholleyfroydnj: http://searchfox.org/mozilla-central/rev/c9f5cc6b4593d461e87a6221dc0286b3859fd515/layout/base/nsFrameManager.cpp#700
23:00bholleyfroydnj: nsFrameManagerBase::UndisplayedMap
23:00bholleyfroydnj: dates back to 1999
23:01froydnjbholley: changing it sounds good to me
23:01bholleyfroydnj: ok - to whatever is recommended in https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Guide/Hashtables ?
23:10froydnjbholley: yeah...I think nsDataHashtable is what you want, offhand, just glancing at the code
23:11bholleyfroydnj: hmm, but I need to map to an UndisplayedNode...
23:11bholleyfroydnj: which I&#39;d probably put in a UniquePtr<>
23:11bholleyfroydnj: wouldn&#39;t that be nsClassHashtable?
23:12froydnjbholley: ah, yeah
23:13* bholley ponders whether he should try to knock it out or file a bug
23:14* bholley glances at his endless queue, decides to file a bug
19 Mar 2017
No messages
   
Last message: 153 days and 14 hours ago