mozilla :: #developers

14 May 2017
01:50pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b7e1e89f4dff - Hiroyuki Ikezoe - servo: Merge #16851 - Allow all numeric values for SMIL values (from hiikezoe:allow-all-numeric-values); r=emilio
01:52pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/0daef4212bdf - Hiroyuki Ikezoe - Bug 1357295 - Rename LengthParsingMode to ParsingMode and LengthParsingMode::SVG to PasingMode::AllowUnitlessLength. r=emilio
01:52pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/488ac0d5200c - Hiroyuki Ikezoe - Bug 1357295 - Make ParsingMode bitflags. r=emilio
01:52pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/18ed65b515a4 - Hiroyuki Ikezoe - Bug 1357295 - Add PARSING_MODE_ALLOW_ALL_NUMERIC_VALUES to force to parse negative values. r=emilio
01:52pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/dd580b538f92 - Hiroyuki Ikezoe - Bug 1357295 - Allow all numeric values for SMIL. r=birtles
02:44db48xFirefox only restored the tabs in one of the open windows :(
02:53pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/2a7890259981 - Nazm Can Altnova - servo: Merge #16819 - stylo: Propagate quirks mode information from Gecko to Servo (from canaltinova:quirk-mode); r=bholley,emilio
02:55pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b2c21526308b - Nazm Can Altnova - Bug 1360488 - Part 1: stylo: Add ServoCSSParsingEnvironment and pass this instead of URLExtraData r=bholley
02:55pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/27ea73043eaa - Nazm Can Altnova - Bug 1360488 - Part 2: stylo: Propagate quirks mode information from Gecko to Servo r=bholley
03:43pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/112aee7ec2e5 - Hiroyuki Ikezoe - Bug 1360488 - Update reftest expectations. r=me
04:57pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/101baa39a455 - Daro Here - servo: Merge #16849 - Link & minor proposal (from kant:patch-1); r=emilio
06:00pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1a87940c0773 - Xidorn Quan - servo: Merge #16853 - Fix serialization of font-feature-settings (from upsuper:font-feature-settings-serialization); r=emilio
06:20pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=90301&endID=90302 - 11 changesets (bug 1361900)
06:45pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/cf287e42cf70 - Wes Kocher - Backed out changeset 3397cb95fb95 (bug 1362047) for xpcshell timeouts in test_ext_i18n.js a=backout
07:35Aryxxidorn: hi, can you update the test expectations after 16853 landed, by any chance? https://treeherder.mozilla.org/logviewer.html#?job_id=98953087&repo=autoland
07:50xidornAryx: probably in five hours...
07:58Aryxok, will look into it
08:04pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/9a37487fac60 - Sebastian Hengst - Bug 1341102 - Update stylo reftest expectations. r=me
08:19pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/55ec58fcd793 - Do Gottwald - Bug 1364661 - Remove _fillTrailingGap. r=florian
12:49zombiehow do i confirm i got the *debug* artifact build? MOZ_DEBUG doesn't seem to be sticking
14:58pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/57900c0fcdee - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-304 - a=hsts-update
14:58pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/99a29fdd23cb - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-304 - a=hpkp-update
15:02pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr45/rev/98f7b1e12986 - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-388 - a=hsts-update
15:02pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr45/rev/8ecfd333f2d9 - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-388 - a=hpkp-update
15:03pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/19ed4a2472c7 - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-302 - a=hsts-update
15:03pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/83b67c630f53 - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-302 - a=hpkp-update
15:38smaugbotond: do I recall correctly that we have async scrolling using scrollbars? How does that work? Scrolling in Google spreadsheet is rather bad using scrollbars, is there anything we could improve there, like coalesce some events (but which events?)?
16:01pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=31817&endID=31818 - 129 changesets - merge autoland to mozilla-central. r=merge a=merge
16:04pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=31818&endID=31819 - 115 changesets - merge mozilla-inbound to mozilla-central. r=merge a=merge
16:07pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/pushloghtml?startID=42647&endID=42648 - 118 changesets - merge mozilla-inbound to mozilla-central. r=merge a=merge
16:09pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=90302&endID=90303 - 138 changesets - merge mozilla-inbound to mozilla-central. r=merge a=merge
17:47botond|homesmaug: We have async scrolling using scrollbars, on Nightly only for now. Unfortunately, it doesn't work well for Google Sheets because they implement scrolling themselves (I think to snap the scroll position to cell boundaries).
17:52smaugbotond|home: right. What there causes it to not work well?
17:52* smaug doesn't know what async scrolling means with scrollbars
17:53botond|homesmaug: It means we don't wait for the main thread to process the mouse events and repaint before updating the scroll position visually.
17:54botond|homesmaug: I think what Google Sheets does is the scrollbars just scroll a blank scrollable element or something that's hidden
17:54smaugyeah, something like that
17:54smaugso they need some events to actually scroll
17:54smaugI guess scroll events
17:54botond|homesmaug: And then they listen for scroll events on that and cause the actual spreadshseet to scroll in response
17:55smaugright. But could we possibly sent fewer scroll events? Like coalesce some scrolling
17:56smaugbotond|home: could you point to the code which does the scrolling in this case?
17:56botond|homesmaug: Possibly - I'm not sure how we decide right now how often to send scroll events.
17:56botond|homesmaug: Is sending too many scroll events the problem, though?
17:56smaugscroll events are triggered by refresh driver ticks
17:57smaugbotond|home: it possibly is.
17:57botond|homesmaug: It sounds to me like the problem is the site circumventing async scrolling. If we could get them to not do that, it would work better.
17:57smaugwheel scrolling became a lot better once we started to coalesce events
17:57botond|homesmaug: Like, if we implemented the new scroll snapping spec, and got them to use it.
17:57botond|homesmaug: (to achieve the snapping to cell boundaries, instead of doing it themselves)
17:58smaugI assume they want to do their own scrolling
17:58smaugsimilar to xul:tree
17:58smaugto be able to handle very large data sets
17:58smaugthough, I'm not sure if spreadsheet can handle millions of items, as xul:tree can
17:59botond|homesmaug: ah, so snapping to cell boundaries isn't the only reason
18:00smaugbotond|home: but if you can link to the code doing scrolling in this case, and I could try some hacks there
18:00botond|homesmaug: they could use the displayport API, once we implement it, to render a subset of the spreadsheet
18:00smaug(or I could try to find the relevant code myself :) )
18:00botond|homesmaug: i'm not really sure what code you're looking for
18:00botond|homesmaug: the code that handles the mouse events to scroll the hidden scrollframe?
18:00smaugbotond|home: I assume we do something special with scrolling when async scrollbar scrolling is enabled?
18:01botond|homesmaug: ok, i see. that would be http://searchfox.org/mozilla-central/source/gfx/layers/apz/src/AsyncPanZoomController.cpp#950
18:02smaugok, thanks
18:02botond|homesmaug: which happens on the compositor thread. the following line then causes us to send the new scroll position to the main thread
18:03botond|homesmaug: which is then processed here: http://searchfox.org/mozilla-central/source/gfx/layers/apz/util/APZCCallbackHelper.cpp#113
18:03botond|homesmaug: but i'm not sure if the async scrolling is even active on that page
18:04botond|homesmaug: i think we might fall back to the main-thread codepath due to what they're doing
18:04smaugah, right
18:04smaugperhaps I need to look at normal scrollbar dragging
18:05botond|homesmaug: which is around here: http://searchfox.org/mozilla-central/source/layout/xul/nsSliderFrame.cpp#576
18:05smaugyup
18:05smaugthat I'm familiar with :)
18:06botond|homesmaug: (this is bug where we had to disable the async-drag codepath on Google Sheets: bug 1328658)
18:07botond|homesmaug: (although it's not clear to me whether the bug and fix there affect all platforms and all spreadsheets)
18:28pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3f985817021e - Dan Banner - Bug 1348362 - Cleanup chrome://global/skin/icons - Move some shared files to be Linux-only, as they are only used on Linux. r=dao
18:28pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/7da161abdad5 - Dan Banner - Bug 1348362 - Cleanup chrome://global/skin/icons - Move shared files to be Windows-only where they are only used on Windows. r=dao
18:28pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/30122bff45fc - Dan Banner - Bug 1348362 - Cleanup chrome://global/skin/icons - Remove unused files. r=dao
19:07pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/0dd2080274ab - Nazm Can Altnova - servo: Merge #16856 - stylo: -moz-image-region shouldn't parse unitless lengths in quirks mode (from canaltinova:moz-image-region); r=nox
19:08Standard8Aryx (or any other sheriff): Can you backout bug 1348362 - looks like we upset devtools :-(
19:08Aryxdoing it atm
19:08Standard8(autoland)
19:09Standard8ok thanks
19:09Standard8I think I know what happened
19:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/ffa19f646066 - Sebastian Hengst - Backed out changeset 30122bff45fc (bug 1348362)
19:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/27046998f10a - Sebastian Hengst - Backed out changeset 7da161abdad5 (bug 1348362)
19:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3a52a1397ef6 - Sebastian Hengst - Backed out changeset 3f985817021e (bug 1348362) for failing mochitests caps/tests/mochitest/test_bug292789.html and browser/base/content/test/static/browser_parsable_css.js. r=backout
19:18John-GaltStandard8: If it makes you feel any better, devtools has upset me several times recently (mostly relating to e10s shims)
19:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c9060b0b93ce - Thomas Nguyen - Bug 1322523 - Add telemetry to capture the length of long Safe Browsing V4 prefixes r=francois
19:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/02c060b287ff - Tomislav Jovanovic - Bug 1362047 - Fix default value for content script run_at, add tests r=mixedpuppy
19:25pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/20127bd6337b - Garvan Keeley - Bug 1363966: Cleanup network geo provider: removed unneeded listener function wrapper and the call to non-existent listener.locationUpdatePending(); r=jdm
19:32jyaany sheriff around ?
19:32Aryxjya: hi
19:32jyaAryx: can you backout something in central directly ?
19:32jyathe change broke the Internet (Youtube)
19:33Aryxyes, what bug/changesets?
19:33jyabug 1361984
19:34jyacommit bbea5fa747270debfa40b10ea49392b6124f5085
19:34jyaor I can push a fix instead
19:37Aryxlet me check
19:39pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/e66dedabe582 - Sebastian Hengst - Backed out changeset bbea5fa74727 (bug 1361984) on request from jya. r=backout a=backout
19:39jyaAryx: thank you
19:39Aryxyou are welcome
19:39jyaAryx: do you know when is the next Nightly build ?
19:59pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/77dbf5613f90 - Ryan VanderMeulen - Bug 1364433 - Add MOZ_CRASHREPORTER ifdefs to DeviceManagerDx.cpp to fix --disable-crashreporter bustage. r=dvander
20:14pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/19f0b1e8f287 - Nazm Can Altnova - Bug 1358710 - Unprefix -moz-linear-gradient / -moz-radial-gradient in unit tests r=dholbert
20:24pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b0b4e3c3f89d - Simon Fraser - bug 1324922 stop balrog updates before funsize does its thing r=catlee,jlund
20:36pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/25ddfb854eec - Sebastian Hengst - Backed out changeset 20127bd6337b (bug 1363966) for crashing e.g. in browser/base/content/test/permissions/browser_temporary_permissions.js. r=backout
22:19pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/62d05055505d - Sebastian Hengst - Backed out changeset 19f0b1e8f287 (bug 1358710) for failing reftest aja-linear-2.html on OS X with e10s. r=backout
15 May 2017
No messages
   
Last message: 69 days and 22 hours ago