mozilla :: #developers

11 Sep 2017
00:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/e3c293ceedf3 - Andrew Swan - Bug 1353194 Remove a bunch of tests of the old startup update check r=kmag
00:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/246b6aae8157 - Andrew Swan - Bug 1353194 Streamline the startup extension compatibility check r=kmag
00:28pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/48a86fd5097d - Zibi Braniecki - Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
01:24pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/529bfc306853 - gasolin - Bug 1396734 - Set onboarding-notification-body font weight to normal to avoid font bluring on windows;r=rexboy
01:36pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/fc6d97762cdb - gasolin - Bug 1392959 - send action=email when UITour called with email option;r=rexboy
01:47sajattackHi I'm looking for a bug to work on
01:53araihave you tried http://www.joshmatthews.net/bugsahoy/ ?
01:54sajattackyes, I found 1126144 but it looks like it might've already been completed
01:54sajattackI'm also looking at 1383562
01:56araiabout bug 1126144, it's not yet fixed. there's work-in-progress patch
01:57arai(it's 2-years-old bug, so it might be nice to check if it's valid at first
01:57sajattackyeah, it looked like there was a test already written for it
01:58araiis it already in tree?
01:58sajattackon line 14 of browser_cmd_cookie.html
01:58sajattackthere is a domain of .mochi.test
01:58sajattackthe test case is a domain prefixed with "."
01:58araihttps://dxr.mozilla.org/mozilla-central/source/devtools/client/commandline/test/browser_cmd_cookie.html
01:59sajattackyes
01:59araiis the issue reproducible?
02:00araithere's steps to reproduce in comment #0 there
02:00sajattackI'm running a build right now to check
02:00araigreat :)
02:00araiif the issue is no more reproducible, it would be nice to comment that. they could close the bug
02:01sajattackI probably should've used artifact mode, this build is taking a while
02:02araiyou can also use nightly to confirm the bug
02:02sajattackoh cool
02:03sajattackthanks for the tip
02:08sajattacknow I need to find a site that sets a cookie with a . domain
02:15pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/5310033cd68c - Phil Ringnalda - Backed out 2 changesets (bug 1353194) for leaving unreferenced files
02:26db48xroc: ping?
02:26rochi
02:26db48xroc: hey, is this an rr bug or a gdb bug:
02:26db48x(rr) watch -l gInstance
02:26db48xA syntax error in expression, near `) 0x00007fd746aff898'.
02:27rocgdb
02:27gandalfhopang: thanks for helping me! I think that you accidentally removed the NI from yourself actually :)
02:27rocis the current language Rust?
02:27db48xno
02:27db48xC++
02:27rocok well it's probably still gdb :-)
02:27db48xheh
02:27rocrr isn't involved in expression parsing at all
02:27db48xmakes sense
02:27gandalfhopang: aaand you readded yourself. :)
02:28hopanggandalf: That is one of the most stupid mistakes I've ever made, I am more than happy to help :P
02:29gandalfhopang: cancelling NI because of a suboptimal bugzilla UX is one of the most stupid mistakes you've ever made? That's very impressive! :)
02:30db48xroc: incidentally, can you offer any advise for debugging malloc?
02:30db48xadvice
02:31rocwhat do you mean by "debugging malloc"?
02:31db48xI'm thinking that someone overstepped their bounds on the heap, and later malloc handed out some memory that was already in use
02:32rocdata watchpoints and reverse-continue
02:33db48xexactly. the problem is that I don't actually know anything about the code
02:33rocif you're having trouble getting gdb to accept your watch command, compute the address (e.g. `p/x &foobar`) and then `watch -l *(long*)addr`
02:34db48xyes, that's what I ultimately did
02:34rocyou need to narrow down the location of memory you think is corrupted
02:34rocI don't know how to help with that
02:34db48xok :)
02:34roconce you have that, then working backwards to the corruptor is easy
02:35db48xI had hoped that you'd already done this, and you would know something about how libc works, and maybe even had some automation
02:36rocif you want automation for detecting heap overflows then ASAN/valgrind are the way to go
02:36db48xyea
02:36rocwe could build a tool that lets you run valgrind-style analysis during a n rr replay
02:37njnroc: still talking about that, I see :)
02:37rocI have a lot of the infrastructure for that already built
02:37db48x:)
02:37rocbut I can't afford to give it away :-(
02:38njnroc: you know that sewardj wrote valgrind because he was waiting for somebody to write an open-source version of Purify, but nobody was doing it, so he did it himself
02:39db48xI think what I want is a minimal tool that just knows about libc's malloc, and can tell me why the current call to malloc allocated the address that it did
02:39db48xso that I know what to watch
02:39rocnjn: sure
02:40rocnjn: I've done a lot of work on rr over the last 18 months that's all open
02:40rocthat nobody paid me to do
02:41njnroc: not criticising, sorry it came across that way
02:42db48xI guess I'll either have to brave the (expected) storm of noise from valgrind, or try again to understand malloc
02:42rocnjn: I wasn't sure what you meant really :-)
02:43njnroc: I guess the moral of the story is that if you don't give it away, there's a chance someone else will
02:43db48xroc: what's your business model?
02:44sajattackare pbro or jdm in the house?
02:45rocdb48x: I don't really want to talk about that out here :-)
02:45db48x:)
02:46db48xI bet you're making a super-rr to license to big enterprise customers
02:46rocnjn: fair. If I became aware that someone was going to release their own binary instrumentation framework based on rr I guess I'd release ours first :-)
02:46njnheh
02:46pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/252516ee4b1e - James Cheng - Bug 1398072 - Fix an obvious leak in Cleakey CDM. r=cpearce
02:47rocso, get busy I guess! :-)
02:47db48xor you're making the uber of debugging
02:49db48xI require comestibles; bbl
03:24sajattackI'm getting a whole bunch of undefined reference errors trying to build a5f163da8a9b
03:25sajattackhas anyone else experienced thid?
03:25sajattack*this
03:26pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/2a70f67c7c65 - Andrew Swan - Bug 1353194 Remove a bunch of tests of the old startup update check r=kmag
03:26pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/005cddf9e020 - Andrew Swan - Bug 1353194 Streamline the startup extension compatibility check r=kmag
03:27araiI haven't built but apparently there's no issue on automation
03:27araiare you using some custom mozconfig?
03:27sajattackno
03:27araican you post output to http://pastebin.mozilla.org/ ?
03:28sajattackhttps://pastebin.mozilla.org/9032096
03:29araihave you built before?
03:29sajattackyep
03:29araiwith different revision?
03:29sajattackyeah, not sure which
03:30araiany chance removing objdir solves?
03:30sajattackI just did hg pull, hg update and clobber since then
03:30araioh
03:30araithen that's not the case
03:31sajattackand mach build of course
03:32sajattackshould I remove obj-x86_64-pc-linux-gnu?
03:32araiclobber does it
03:32John-GaltMight be worth trying to run mach bootstrap
03:33sajattackok
03:33sajattackmaybe rerun clobber too?
03:33John-GaltAll of the stuff in that pastebin is related to CSS/layout. Might be related to the Stylo switchover
03:33John-GaltCouldn't hurt
03:33pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/5b3b0c446caa - James Cheng - Bug 1397344 - Use Decay to ensure StoreCopyPassByXXX stores the value by copy not by reference. r=gerald
03:52pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/38e3ac4eee42 - steveck-chung - Bug 1341569 - Add the form created time in handler and telemetry probe for form filling duration. r=benjamin+7044,MattN
03:57pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c9fe4ec27ca3 - Jared Wein - Bug 1380150 - Prevent subresource loads from showing the progress indicator on the tab. r=Gijs
04:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1cc09280f38c - Xidorn Quan - Bug 1324682 - Remove annotation of this bug. r=xidorn
04:19pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/5ea257c32084 - Makoto Kato - Bug 1263503 - memory leak of filename into layout/printing/nsPrintEngine.cpp. r=mantaroh
04:26pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d3b77b29b531 - Gerald Squelart - Bug 1378722 - Disable D3D11 video decoding for igd10umd{32,64}.dll 9.17.10.2884 - r=kentuckyfriedtakahe
04:26kentuckyfriedtakahe\o/
04:26gerald:-)
04:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/2e429e3f2b3f - Xidorn Quan - Bug 1324691 followup - Remove the last condition on crashtest of this bug. r=xidorn
05:15sajattackgot my build going
05:29pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b64aee9198d - Christoph Kerschbaumer - Bug 1397653 - Update tests within docshell/ to comply with new toplevel data: URI navigation policy. r=smaug
05:43pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/4aac84ba2f8e - Glenn Watson - servo: Merge #18443 - Update WR (various small optimizations and bug fixes) (from glennw:update-wr-opts-fixes); r=jdm
05:59pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/pushloghtml?startID=50872&endID=50873 - 12 changesets (bug 1398659)
06:00pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/42306e3867ae - Xidorn Quan - Bug 1323649 followup - Re-enable one reftest. r=xidorn
06:06sajattackis anyone available to review this? https://bugzilla.mozilla.org/show_bug.cgi?id=1398623#c4
06:13globsajattack: i see xidorn helped. note you should set the review flag to "?" when you need a review, not "+"
06:15sajattackok thanks glob
06:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ce80185031 - Lars T Hansen - Bug 1146817 - Improve implementation of non-access-atomic safe-for-races accesses. r=sstangl
06:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b55231e6628 - Lars T Hansen - Bug 1206770 - Add --cpu-count with correct documentation, make --thread-count an alias of --cpu-count. r=luke
06:46pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/a2ed5fdd3fc3 - Jing-wei Wu - Bug 1394404 - Part 1: Update AnimatedProgressBar's progress value to 100 before hiding it. r=walkingice
06:46pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1f1893590a1d - Jing-wei Wu - Bug 1394404 - Part 2: Keep AnimatedProgressBar has same height in both BrowserApp and CustomTabsActivity. r=walkingice
06:48sajattackthanks for all your help xidorn
06:48xidornsajattack: np. thanks for your contribution
06:48pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/109e5bafd7a3 - sajattack - Bug 1398623 - Remove several unused variables in nsSprocketLayout::PopulateBoxSizes r=xidorn
06:50sajattackso now we wait for trybots?
06:53sajattackxidorn: or are we all done?
06:54xidornsajattack: for this case, I think it's all done
06:55sajattackcool beans
06:55xidornsajattack: that looks like a straightforward enough change, so I land it directly
06:55sajattackinb4 everything breaks
06:55xidornsajattack: for trickier cases, a try push would be preferred before landing, though
06:57sajattackxidorn: how do I close the bug?
06:57xidornsajattack: it would be closed automatically when the patch gets merged into mozilla-central
06:58sajattackok
06:58xidornsajattack: that normally happens several hours to one day after landing
07:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/adcfea5cd531 - Makoto Kato - Bug 1394758 - Part 1. non-editable text node should be treated as WSType::special, not WSType::text. r=masayuki
07:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c65dfa68df8d - Makoto Kato - Bug 1394758 - Part 2. WSRunObject::InsertBreak should convert space to NBSP when current position is first text run object. r=masayuki
07:37pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/86465f8cfaf3 - Masayuki Nakano - Bug 1395876 - Initialize TSF modules after we create first normal window r=m_kato
07:45pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/8c9d50f961f5 - Sebastian Hengst - Backed out changeset 109e5bafd7a3 (bug 1398623) for asserting during a11y's e.g. accessible/tests/mochitest/states/test_expandable.xul. r=backout
07:49njnall-hands now in Austin? wow
07:51m_katoseriously
08:00freddyboh.
08:01freddybis this about the earthquake last week?
08:02padenotdo we know of a bug that says that web.whatsapp.com is basically unusable in nightly ?
08:02heycampadenot: as in slow?
08:02padenotheycam, yeah
08:02heycampadenot: I have noticed that often if I switch to that tab, it can take multiple seconds with the tab spinner showing
08:02heycamfiled a bug for that
08:02padenotheycam, a quick profile points to a svg painting issue ?
08:03heycampadenot: yes, that's what Bas saw too
08:03* heycam finds the bug
08:03padenotwhen I type in the box to compose a message, every character takes 2-3s to show up
08:03heycamhttps://bugzilla.mozilla.org/show_bug.cgi?id=1396479
08:03padenotbasically the main thread is crushed
08:04heycampadenot: I don't see that
08:04heycampadenot: FWIW that tab switching slowness I see on my Thinkpad P50 in Linux, but not here on my hidpi mac
08:04padenotI've been seeing this for a few days on this 2016 macbook pro
08:04padenotfirefox nightly
08:05padenot(up to date build)
08:05heycammy mac is on 2017-09-09
08:05* heycam updates sees what happens
08:06heycambtw it's surreal to see the nightly updater run lately, the thing with the silver sync looking icon. haven't seen that for years.
08:06padenotyeah
08:07heycamyeah typing messages still seems fine for me
08:10pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/13bf76b84d85 - Sylvestre Ledru - Bug 1397457 - Update mach to download clang-format 5.0 - Remove the deprecated comment r=trivial DONTBUILD
08:19padenotheycam, yeah I don't think we're seeing the same thing, I'll open a new bug
08:20heycampadenot: ok
08:24pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/7f5ae5ff1181 - Simon Fraser - Bug 1342392 Move partial update generation in-tree r=dustin,jlorenzo
08:31pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0bcdc7482e - Simon Fraser - Bug 1342392 Rename of docker image for partials generation CLOSED TREE
08:38pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c0a373e16a6 - Sebastian Hengst - Backed out 2 changesets (bug 1342392) for adding .orig file and flake lint failures. r=backout on a CLOSED TREE
08:50padenotheycam, https://bugzilla.mozilla.org/show_bug.cgi?id=1398697
08:51* heycam ccs
08:58pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/01bf0c29331e - Simon Fraser - Bug 1342392 Move partial update generation in-tree r=dustin,jlorenzo
09:15pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/56e721e30cee - Emilio Cobos lvarez - Bug 1398581: Ensure a first-letter doesn't incorrectly inherit from a first-line. r=heycam
09:17pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=32472&endID=32473 - 39 changesets (bugs 1380150, 18434, 1395287, 1385630, 1353194 and 14 other bugs)
09:19pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=32473&endID=32474 - 10 changesets - merge mozilla-inbound to mozilla-central. r=merge a=merge
09:20pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/pushloghtml?startID=50879&endID=50880 - 11 changesets - merge mozilla-central to autoland. r=merge a=merge
09:20pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/064df3f608f5 - Fernando Jimnez Moreno - servo: Merge #18206 - stylo: store specified value of grid layout repeat() function (from ferjm:bug1382369.grid.repeat.function); r=wafflespeanut
09:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=94796&endID=94797 - 41 changesets - merge mozilla-central to mozilla-inbound. r=merge a=merge
09:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d509047f7935 - Jan Henning - Bug 1271998 - Part 0 - Clean up imports. r=JanH
09:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/fe02dfd16dc3 - Jan Henning - Bug 1271998 - Part 1 - Provide a ScrollView with a more efficient fadingEdge implementation. r=jwu
09:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c8aa9b29b278 - Jan Henning - Bug 1271998 - Part 2 - Make our URL bar scrollable. r=jwu
09:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/953adb3e5e83 - Jan Henning - Bug 1271998 - Part 3 - Scroll the URL to focus the origin for overlength URLs. r=jwu
09:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/ecae1c71816b - Jan Henning - Bug 1271998 - Part 4 - Use a touch delegate to increase the clickable area of the URL bar. r=jwu
09:30pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/8be3c451ff86 - Fernando Jimenez Moreno - Bug 1382369 - stylo: store specified value of grid layout repeat() function. Tests. r=mats
10:12pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/0f9e4072dbf8 - Nevin Chen - Bug 1396465 - Make onboarding images smaller. r=jwu
10:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/4e34fdb8b3ff - Andreas Tolfsen - Bug 1398450 - Fix prefs test regression. r=jgraham
10:27pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/629ebf9fa725 - Emilio Cobos lvarez - servo: Merge #18429 - style: Remove a few uses of ComputedValueAsSpecified (from emilio:cvas-die); r=nox
10:53pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3316ee67aa - Bob Owen - Bug 1274746: Use previous custom scale value when switching from Shrink To Fit in Print Preview. r=mconley
11:08pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/4edf631edd32 - Andrea Marchesini - Bug 1398635 - IPCBlobInputStream must release the remoteStream when the pipe inputStream wraps it in order to avoid double close(), r=smaug
11:43pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/994883c61ef5 - tigercosmos - servo: Merge #18372 - TEST: fix and add case of po-observe.any.js (from tigercosmos:userTimingApi); r=ferjm
11:49pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/cdd9f6610d88 - Julian_Chu - Bug 1355735 - Add util to pick name for default browser r=jwu
11:59pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c064f7375341 - Andi-Bogdan Postelnicu - Bug 1398712 - update Coverity modelling file in order to support NS_PRECONDITION. r=sylvestre
12:00pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/dcaa0dad1d1e - L10n Bumper Bot - no bug - Bumping Fennec l10n changesets r=release a=l10n-bump
12:50pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/171282de032d - Nicolas Silva - Bug 1398134 - Fix warning in BindingUtils.h. r=bkelly
13:06pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/3b924184c333 - Daniel Stenberg - Bug 1359624 - Disable nsAuthSambaNTLM module on OSX. r=mayhemer
13:06pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/52e22eaebe72 - Chih-Yi Leu - Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems r=mstange
13:10pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/227388c78b76 - Eden Chuang - Bug 1387149 - Remove outdated comment from Codegen.py. r=bz
13:10pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/de6c153ec533 - Samael Wang - Bug 1364364 - Part 1: Why are we declaring private virtual functions? r=smaug
13:10pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/074475da0f2c - Samael Wang - Bug 1364364 - Part 2: Extract a part of EvictExpiredContentViewerForEntry to a new function FindTransactionForBFCache, and implement RemoveDynEntriesForEntry on top of it. r=smaug
13:10pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/21ee8f318a47 - Samael Wang - Bug 1364364 - Part 3: Clear dynamic subframe entries in RemoveFromBFCacheSync/Async. r=smaug
13:10pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c5a737bbfdeb - Samael Wang - Bug 1364364 - Part 4: Add test case. r=smaug
13:10pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c394b06dc30c - Samael Wang - Bug 1364364 - Part 5.1: Rename frame/iframe.html of to-be-modifed test cases. r=smaug
13:11pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/809036cfd7d9 - Samael Wang - Bug 1364364 - Part 5.2: Remove browser.sessionhistory.cache_subframes and fix test cases relying on it. r=smaug
13:11pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c517d8071dfb - Samael Wang - Bug 1364364 - Part 6: Re-connect nsDocViewerFocusListener in nsDocumentViewer::Open. r=smaug
13:11pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/100136657a8b - Fischer.json - Bug 1394731 - The onboarding tour nav item's icon doesn't change to the proper colored icon while mouse hovering together, r=rexboy
13:11pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/f13d106fc678 - Franziskus Kiefer - Bug 1397833 - don't assert on custom TLS key-exchange groups, r=keeler
13:40pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/8b48ae67b5ce - Marco Bonardo - Bug 1398114 - Intermittent failure in browser_privatebrowsing_placesTitleNoUpdate.js. r=standard8
13:41johannhjwatt: ping
13:42jwattjohannh: pong
13:43johannhjwatt: hey, I'm reviewing a patch that adds a new SVG icon and it's pretty unoptimized, there was a tool we used for optimizing/flattening the paths, right? Where can I point them to?
13:43jwattjohannh: shorlander would be able to tell you
13:44jwattas I understand it it's an Illustrator plugin and some scripts
13:44globjohannh: fwiw i've used svgo on personal projects
13:45johannhjwatt: glob: ok, I'll try running svgo on the image and ask shorlander, thank you!
13:47freddybdidn't we have a sticker that literally says not to ask shorlander? :-)
13:49pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?startID=7733&endID=7734 - 11 changesets (bugs 1387678, 1393940, 1383499, 1391430, 1396570 and 6 other bugs)
13:51johannhjwatt glob: shorlander uses svgo, too
13:51johannhthe magic of open source
13:52pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/65d965324c8c - Andi-Bogdan Postelnicu - Bug 1398767 - Reformat modelling file according to Mozilla coding style. r=sylvestre
14:27* db48x facepalms
14:28db48xif you don't configure with --enable-jemalloc, then it doesn't build with jemalloc (which is fine)
14:28db48xbut unless you say --disable-jemalloc, MOZ_MEMORY is still set to 1, and various things think you do have jemalloc
14:29pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c6ec5f35710a - Chris H-C - bug 1396836 - Tidy up about:telemetry search r=Dexter
14:34djvj_mstange: hey, can you take a look at the patch for bug 1375669 and roughly confirm that it's fixing a real problem. It does seem like IonCache => Ion entry marking is missing and necessary, but I've been away from the codebase enough to maybe not be aware of some other mechanism by which this gets done
14:37pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f09b2b387751 - Mike de Boer - Bug 1374749 - Animate the panelviews differently to make it look as if the view to show is pushing the previous view out of the panel. r=jaws
14:38pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ef55343a4e9 - Ryan VanderMeulen - Bug 1398810 - Update pdf.js to version 1.9.554. r=bdahl
14:40pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/67fb712adac1 - Fischer.json - Bug 1394730 - Should clean up UITour highlight while navigating to another tour, r=rexboy
14:40mstangedjvj: you may have been away from the codebase but it doesn't look like anybody else touched the code in the meantime, either :)
14:40mstangedjvj: Jon Coppeard seems like a good person to request review from
14:40djvjmstange: ok switching review
14:40mstangedjvj: thanks
14:50pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3be0f512422b - Sebastian Hengst - Backed out changeset c6ec5f35710a (bug 1396836) for eslint failures in aboutTelemetry.js. r=backout
14:53nemogaaaaah hate hate hate that ctrl-w on linux - all it does is lose me work - I install addons or modify jar to strip it out, but in a clean session can still bite me
14:54nemoer. ctrl-q
14:54pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab8c75e0d422 - Jan de Mooij - Bug 1398140 - Remove Ion helper thread pausing mechanism. r=luke
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/014826d39b2f - Nevin Chen - Bug 1394356 - Temporary remove add to home screen for Android O. r=jwu, a=lizzard
14:54nemoctrl-w is the one I'm hitting when I ctrl-q
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/715dcb4d80a6 - Ethan - Bug 1396468 - Spoof navigator.oscpu as 'Windows NT 6.1; Win64; x64' when resisting fingerprinting is enabled. r=ehsan, a=gchang
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/d65474a88a77 - Shawn Huang - Bug 1396300 - Use fallible allocation in GetAsStream. r=bkelly, a=gchang
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/6b935e676fe9 - Shane Caraveo - Bug 1380597 - Ensure the url can be loaded by the extension. r=kmag, a=lizzard
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/89e197ce9f96 - Andrea Marchesini - Bug 1397702 - StorageObserver should use nsTObserverArray for the sink in order to support removal when iterating. r=mccr8, a=jcristau
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/719dcb390127 - Andreas Pehrson - Bug 1360334 - Improve error handling. r=padenot, a=jcristau
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/7e38724bec08 - Michael Kaply - Bug 1378461 - Report other search engine names. r=mak, data-r=rweiss, a=gchang
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/6e0e2f09610e - Rob Wu - Bug 1388266 - Ignore error about non-existing _locale and localization directory. r=kmag, a=gchang
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/8dcbff75d8f1 - steveck-chung - Bug 1377006 - Part 1: Add disable highlight option in main action button. r=johannh, a=gchang
14:54pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/47dcb670f8ca - steveck-chung - Bug 1377006 - Part 2: Add disableHighlight option in formautofill doorhanger. r=lchang, r=MattN, a=gchang
14:56pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/2c284ff4354a - Christoph Kerschbaumer - Bug 1398574 - Update tests within websockets/ to comply with new toplevel data: URI navigation policy. r=jgraham,valentin
15:23pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/d5a9ae0983b8 - Emilio Cobos lvarez - Bug 1398581: Address followup comments. r=me
15:23pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/a0075a30bc7f - Emilio Cobos lvarez - Bug 1398581: Crashtest. r=me
15:24froydnjnemo: it baffles me that this is fixed on windows, but not on linux (can't remember on mac)
15:25nemofroydnj: it appears this is deliberate
15:25nemothey think linux users expect it or something
15:25nemoI don't know of anyone who does this on purpose
15:25nemofroydnj: another fun thing for me personally. w3m uses ctrl-q for close tab - so my finger muscle memory is totally screwed up
15:26nemothankfully w3m has the good sense to not make the key right next to the "close tab" a "close app"
15:26nemoctrl-w just toggles wrapping
15:26nemofroydnj: when this has come up before people have just said "but, everything just gets restored when you reopen so it isn't a problem?"
15:26pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/435bc55b9c14 - Alexander Surkov - Bug 1379808 - Intermittent browser_test_zoom_text.js failure, wrong height and y, r=eeejay
15:27nemofroydnj: which is of course not true of more complicated JS apps, nor of private tabs
15:28nemofroydnj: there's an addon that adds a prompt, IMO that should be default (or removing it)
15:30pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/d285843321b5 - Andrea Marchesini - Bug 1397645 - Optimize IPCBlobInputStream slicing with the introduction of nsICloneableInputStreamWithRange, r=asuth
15:30pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/47982714b7b6 - Andrea Marchesini - Bug 1397645 - Propagation of the IPCBlobInputStream slicing to the parent process, r=asuth
15:34pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/002ebb2eb2b7 - Matt Brubeck - servo: Merge #18431 - Use SmallBitVec to optimize size of PropertyDeclarationBlock (from mbrubeck:pdb-size); r=SimonSapin
15:34pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b9c7d951bf57 - Servo VCS Sync - No bug - Revendor rust dependencies
15:37pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3b7add087f2b - Ricky Chien - Bug 1397729 - Strings inside cookies dialog are not found when searched r=mconley
15:38pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c33c05b5d47d - Mike de Boer - Bug 1397754 - Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. r=Gijs
15:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?startID=7735&endID=7736 - 14 changesets (bugs 1394356, 1361336, 1387058, 1392930, 1372040 and 1 other bug)
15:55pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3f4c7db71dc2 - J. Ryan Stinnett - Bug 1398297 - Reload RDM when disabling touch. r=gl
16:05RyanVMaklotz: I wonder if we need https://dxr.mozilla.org/mozilla-central/source/dom/plugins/test/mochitest/mochitest.ini#90 anymore
16:06pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc1f526a6152 - Myk Melez - Bug 1398345 - find llvm-symbolizer, get memory size on Mac; r=ahal
16:08RyanVMkitcambridge: is https://bugzilla.mozilla.org/show_bug.cgi?id=1350665#c1 still true?
16:13kitcambridgeRyanVM: it should be, but I'm afk now, will double-check in about 20 minutes. validation is enabled through beta (https://bugzilla.mozilla.org/show_bug.cgi?id=1385127) but iirc requesting repair is nightly only
16:13RyanVMkitcambridge: good enough - thanks
16:14pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1a31654a23d3 - Kartikaya Gupta - Bug 1388433 - Remove unnecessary warning as the codepath is handled in an acceptable manner. r=mattwoodrow
16:18pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/27cf5225d7e0 - Andrew Swan - Bug 1398326 Fix display of default extension icon in permission prompts r=walkingice
16:18pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/2eeabcda5e4c - Jon Coppeard - Bug 1396156 - Define MOZ_DEV_EDITION for js/src. r=ted
16:18pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/84323938eaeb - Jon Coppeard - Bug 1396156 - Fix unused private field error when building AutoAssertNoGC as Beta. r=sfink
16:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/336effc1fe44 - Aastha Gupta - Bug 1336207 - Add tooltip to say what "ev" means in the Inspector. r=miker
16:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b224e79a2f3 - Greg Mierzwinski - Bug 1394989 - Prevent test_nsIProcess.js from running on linux64-ccov. r=Aryx
16:34sfosterjimm: you doing ok down there?
16:34jimmsfoster: yep, a little rain and a littlke wind, that's about it.
16:35sfostergood to hear
16:35pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/a31657380189 - Tom Schuster - Bug 1317394 - Make DataView getters throw for detached array buffers in Nightly. r=anba
16:35pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea4ebbcd0022 - Tom Schuster - Bug 1385278 - Move the rest of IonCaches.h to Assembler-shared.h. r=jandem
16:35pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/a4c4f7507a05 - Ryan VanderMeulen - Bug 1377618 - Update Firefox 56 to NSS_3_32_1_RTM. r=kaie, a=gchang
16:35pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/cec5d3fc21b1 - Andrea Marchesini - Bug 1381748 - Cleanup FetchConsumer workflow - part 1 - no mBody. r=catalinb, a=lizzard
16:35pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/32d8da2721a2 - Andrea Marchesini - Bug 1381748 - Cleanup FetchConsumer workflow - part 2 - cleanup RegisterWorkerHolder. r=catalinb, a=lizzard
16:35pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/335fe07a77ed - Andrea Marchesini - Bug 1381748 - Cleanup FetchConsumer workflow - part 3 - shutdown workflow. r=catalinb, a=lizzard
16:42Aryxmikedeboer: hi, https://treeherder.mozilla.org/logviewer.html#?job_id=130089658&repo=autoland looks like a frequent intermittent on macOS from 1374749
16:42Aryxwill back it out (passed on debug for that push and failed on opt, later pushes fail both)
16:43mikedeboerAryx: ok, thanks for the heads up
16:45pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/307b5682dec3 - Sebastian Hengst - Backed out changeset f09b2b387751 (bug 1374749) for frequently failing browser-chrome's browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_popup_resize.js on macOS. r=backout
16:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/113da8d46aa4 - Ryan VanderMeulen - Bug 1377618 - Update ESR52 to NSS_3_28_6_RTM. r=kaie, a=gchang
16:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/58a574502ca9 - Samuel Vargas - Bug 1376399 - Hard crash in FF 54 and Nightly 56 on Windows 7. r=jgilbert, a=jcristau
16:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/24db61862c54 - Kris Maglione - Bug 1396570 - Null check getter/setter when JSPROP_GETTER/JSPROP_SETTER is set. r=bholley, f=jandem, a=jcristau
16:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/1a02f11c6efe - Makoto Kato - Bug 1380292 - Don't turn on object resizer, inline table editor and etc when element isn't into editor. r=masayuki, a=jcristau
16:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-esr52/rev/002686d9536f - Andreas Pehrson - Bug 1360334 - Improve error handling. r=padenot, a=jcristau
16:47pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/a57eaa7832b2 - Jing-wei Wu - Bug 1398655 - Remove unused color resources in colors.xml. r=nechen
16:50pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b86983c73434 - Jan Odvarko - Bug 1396811 - Add new telemetry probe collecting the current theme; r=chutten,liuche,ochameau
16:51djvjmstange: do you think it'd be possible to capture one these profiler report crashes with RR?
16:51Aryxsurkov: hi, eslint failure. can you push a follow which moves the curly brace up? https://treeherder.mozilla.org/logviewer.html#?job_id=130095578&repo=mozilla-inbound
16:51djvjmstange: my latest theory is that the profiler stack walker is running into some rare case where it's returning an address into either a trampoline or non-jitcode
16:51mstangedjvj: it's probably going to be very hard
16:52mstangedjvj: unless you have STR so you can trigger it quickly
16:52djvjmstange: I've tried to repro this several times with little luck
16:52surkovlooking
16:52djvjon the laptop, on linux
16:52mstangedjvj: https://github.com/mozilla/rr/issues/1930 means that you have to run rr with syscall buffering disabled, and doing so has very high perf overhead
16:52djvjmstange: ok..
16:53djvjmstange: maybe if I browsed the same pages.. do you remember roughly what was being browsed when you ran into these?
16:53djvjI should ask ehsan as well..
16:53Aryxsurko