mozilla :: #developers

11 Aug 2017
00:19mchangWhose the current sherriff on duty?
00:19KWiersomchang: hi
00:19mchangKWierso: heyo! Do you know when the next m-i to m-c merge is going to happen? Seems like it's been extra long or im delusional :)
00:20KWiersoboth fulltime sheriffs took pto in the last day, so guess it didn't really get done
00:20KWiersohaven't even caught up enough to look much at inbound yet
00:20mchangKWierso: ahh ok, no worries then, PTO is more ipmortant :)
00:20mchangthanks!
00:20KWiersomchang: there's a chance it'll be in the next hour
00:20KWiersonot a great chance, but a chance
00:21mchangKWierso: all good, ill just eat dinner and push later haha
00:26pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/d60f3724f1a7 - Aki Sasaki - bug 1389260 - split by max # of locales per chunk. fix nightly l10n. r=bustage DONTBUILD
00:26pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/bb64c2d8c456 - Ricky Chien - Bug 1388745 - Make "find more search engines" label highlightable r=mconley
00:29pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/29353fb6613b - Eric Rahm - Bug 1382001 - Part 1: Handle gperf-like preamble in make_dafsa. r=froydnj
00:29pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd6770fadff3 - Eric Rahm - Bug 1382001 - Part 2: Use a DAFSA for kSTSPreloadList. r=keeler
00:37pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=32308&endID=32309 - 62 changesets (bugs 1388457, 1388368, 1388234, 1375382, 1387750 and 17 other bugs)
00:44pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/58f678547059 - ZER0 - Bug 1381542 - renamed "devtools/shared/event-emitter" in "devtools/shared/old-event-emitter"; r=ochameau
00:47KWiersoerahm: eslint issues
00:48erahmKWierso: :( I wish eslint would just do whatever it cares about and leave me alone
00:49erahmKWierso: I can fix real quick
00:49KWiersogo for it
00:51pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fe47b777980 - Eric Rahm - Bug 1382001 - Part 3: Fix eslint. r=me
00:51MossopI mean. We could add an eslint --fix step somewhere somehow. It wouldn't cover all cases though and would probably be hard to do
00:52erahmMossop: yeah I mean I just don't care, all I'm going to do is nudge some characters so eslint quits yelling at me
00:53erahmDid we ever get a precommit hook setup? that'd make me happy
00:53MossopYes
00:53MossopLet me find the docs
00:53erahmbut it didn't yell at me :(
00:53MossopYou have to install it on your own repo to work
00:54erahmKWierso: if I break things again just back me out
00:54KWiersocan do
00:54erahmMossop: ah, I just want it to work. I don't think it should be optional if I'm just going to burn the tree
00:55MossopThat might be a harder sell since it would require having node on the hg servers
00:56Mossoperahm: The plan is to make mach bootstrap or something set you up with them so most people will have them installed
00:56erahmMossop: no I want it locally, just have bootstrap do it
00:56erahmMossop: ah exactly :)
00:56Mossophttps://bugzilla.mozilla.org/show_bug.cgi?id=1295833
00:56MossopJust another thing waiting on someone to actually do the work :(
00:57erahmc'est la vie
00:59pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/98bfeb44625e - ffxbld - No bug, Automated HSTS preload list update from host bld-linux64-spot-301 - a=hsts-update
00:59pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/73cf0bfc6958 - ffxbld - No bug, Automated HPKP preload list update from host bld-linux64-spot-301 - a=hpkp-update
01:00pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/bb88ccb10454 - ffxbld - No bug, Automated blocklist update from host bld-linux64-spot-301 - a=blocklist-update
01:00pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a92b98a965 - Ben Kelly - Bug 1389184 Avoid crashing in worker MemoryReporter if the GlobalScope is nullptr. r=asuth
01:00erahmah crud, that's going to race with my changes
01:01erahmKWierso: can you back me out before I cause a merge headache later
01:03pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/b89852598b1f - Wes Kocher - Backed out 3 changesets (bug 1382001) at developer's request a=backout
01:05pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=93629&endID=93630 - 17 changesets (bug 1128959)
01:05Mossoperahm: In the meantime here is how to set up the hooks for the python and JS linters https://gecko.readthedocs.io/en/latest/tools/lint/usage.html#using-a-vcs-hook
01:06erahmMossop: nice, I'll give that a shot before I try to re-land tomorrow
01:08KWiersoerahm: fwiw, you had another eslint issue after your followup
01:09erahmYeah figures. I don't do enough js to internalize our lint rules :(
01:15pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=32310&endID=32311 - 115 changesets - Merge inbound to m-c a=merge
01:23pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/45e8dfa1d016 - Wes Kocher - Backed out changeset 58f678547059 (bug 1381542) for conflicting with the incoming m-c merge a=backout
01:24pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=93631&endID=93632 - 69 changesets - Merge m-c to inbound, a=merge
01:26pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/pushloghtml?startID=48509&endID=48510 - 121 changesets - Merge m-c to autoland, a=merge
01:47pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/e7ab0d70997c - Makoto Kato - Bug 1388971 - Remove unused GetCurrentDictionary calls. r=Ehsan
01:49pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/6544c0f5a489 - ZER0 - Bug 1381542 - renamed "devtools/shared/event-emitter" in "devtools/shared/old-event-emitter"; r=ochameau
01:51philorhaHa, something got backed out over a test I wrote
01:53pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/dba7d26192d7 - Brian Birtles - servo: Merge #18036 - Reject easings with trailing content in Servo_ParseEasing (from birtles:reject-easing-lists); r=hiro
01:54pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/a4839ba8b065 - Brian Birtles - Bug 1385141 - Update test expectations for web-animations/interfaces/KeyframeEffect/constructor.html; r=hiro
01:56pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/eba5c78cfe2c - sotaro - Bug 1387922 - Add log of start or fwd Transaction to on screen timing r=nical
02:04pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/a88ed8010517 - Karl Tomlinson - bug 1388656 size to actual used length in nsTArray::SetCapacity() optimization r=padenot
02:04pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/aef648113c68 - Karl Tomlinson - bug 1388656 remove unused SAMPLE_RATE SetInt32Parameter case r=padenot
02:04pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/111a7a257807 - Karl Tomlinson - bug 1388656 re-initialize the Reverb only once when the ConvolverNode buffer changes r=padenot
02:05pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/cd8681109e96 - Karl Tomlinson - bug 1388656 keep response buffer on graph thread only long enough to initialize the Reverb r=padenot
02:20pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/01b5b211063c - Xidorn Quan - Bug 1389041 - Move the iframes out from display tree in test_value_computation.html. r=heycam
02:25pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/ea0c21ef7e3c - Evan Tseng - Bug 1386160 - Add separators for each level 1 header to match the Photon visual spec. r=jaws
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/cff0baa2b08d - Hiroyuki Ikezoe - Bug 1379516 - Get dom.animations.offscreen-throttling preference value just once at startup. r=birtles
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b0abe749660b - Hiroyuki Ikezoe - Bug 1379516 - Add isStyledByServo(). r=birtles
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/2bc896ae1668 - Hiroyuki Ikezoe - Bug 1379516 - Skip offscreen throttling tests on stylo. r=birtles
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/511aca5eb28b - Hiroyuki Ikezoe - Bug 1379516 - Update the test where an orphaned element is attached to a document. r=birtles
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/bd7ce9e76553 - Hiroyuki Ikezoe - Bug 1379516 - Add descriptions for re-attaching orphaned animation case for stylo. r=birtles
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/89a0a21e64c4 - Hiroyuki Ikezoe - Bug 1379516 - Mark animation timerline marker for stylo. r=birtles
03:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/6433c832637f - Hiroyuki Ikezoe - Bug 1379516 - A test case that checks animations on the compositor keeps running on the compositor when unrelated style attribute is changed. r=birtles
03:09heycamhmm, anyone else having trouble loading mozreview right now?
03:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=93635&endID=93636 - 12 changesets (bug 1351148)
03:21pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/520ff4a9eea3 - Phil Ringnalda - Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
03:45ajacan anyone point me to latest Photon mockups?
03:45philorwonder whether the bogosity of https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/scroll-anchoring/anchoring-with-bounds-clamping.html would be obvious if I actually understood anything
03:46* aja is seeing new large spacing to left of url bar and to right of search...on inbound.
03:50pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f86c7450946b - Andrew Halberstadt - Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
03:54ajanevermind about spacing...looks planned (as per april mockup pix i found)
04:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/2d42558598f3 - Boris Zbarsky - Bug 1388626. Restyle ::-moz-xul-anonymous-block as needed with stylo. r=heycam
04:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/dc3333e3ff2b - Boris Zbarsky - Bug 1384602 part 1. When coalescing lazy frame construction reframes for stylo, do it even across comments. r=emilio
04:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/924d16d996e2 - Boris Zbarsky - Bug 1384602 part 2. Convert inserts to appends on table rows if possible, because the insert codepath is rather buggy. r=heycam
04:24pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/b039b6974405 - Andrew Swan - Bug 1359558 Part 1: Move webextension theme test to test_webextension.js r=kmag
04:24pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/652c9d3a4f0d - Andrew Swan - Bug 1359558 Part 2 Pass appropriate bootstrap reasons when temporarily installing an addon on top of an existing one r=kmag
04:24pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/80293ee27bc5 - Andrew Swan - Bug 1359558 Part 3 Add a test for extension newtab overrides with temporary addon installation r=bsilverberg
04:35pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/9ecc6b515324 - Matthew Noorenberghe - Bug 1388078 - Form Autofill: Delay adding the AOM upgrade listener until the XPI DB is loaded. r=rhelmer
04:43pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa9361b1968 - Mason Chang - Bug 1372602 Make child widgets not visible if the window around it isn't visible on OS X. r=mstange
05:15pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/316d69355fce - Boris Zbarsky - servo: Merge #18041 - Stylo's atom generation needs to deal with wrapper anon boxes (from bzbarsky:add-wrapper-anon-boxes); r=heycam
05:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f631cb50bf53 - Boris Zbarsky - Bug 1388625 part 1. During a stylo restyle, update the style of the trailing anonymous colgroup of a table, if any. r=heycam
05:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/e9fc7911b14f - Boris Zbarsky - Bug 1388625 part 2. During a stylo restyle, update the style of the anonymous cols in a colgroup, if any. r=heycam
05:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d1460a3a9ab1 - Boris Zbarsky - Bug 1388625 part 3. Add nsIFrame flags we will use in stylo post-traversal to keep track of wrapper anonymous boxes. r=heycam
05:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/76ba910b21ee - Boris Zbarsky - Bug 1388625 part 4. Add a concept of wrapper anon boxes to nsCSSAnonBoxes. r=heycam
05:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/fb891d5aa58f - Boris Zbarsky - Bug 1388625 part 5. Implement wrapper anonymous box restyling in ServoRestyleManager. r=heycam
05:23pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1bb53448ce5a - Boris Zbarsky - Bug 1388625 part 6. Flag the in-flow frames of kids of various wrapper frames during frame construction, so we know to restyle the wrapper frames. r=heycam
05:27pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/f74094603063 - Mark Hammond - Bug 1386171 - log urls for synced tabs at trace level. r=eoger
05:53aswananybody else having problems with artifact builds on mac?
05:54aswanit looks like Services.appinfo.version is 56.0a1 which causes all the system addons with min version of 57.0a1 to be disabled
06:02pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/69f808119fa3 - Henrik Skupin - Bug 1254136 - Fix double registration for sessionstore-windows-restored. r=automatedtester
06:03pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/e6f14ea1dbe3 - Henrik Skupin - Bug 1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin. r=automatedtester
06:03pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/77865d6f19c1 - Henrik Skupin - Bug 1388627 - close_chrome_window always operates in chrome context. r=automatedtester
06:08hsivonenis there a mach command for upgrading mach-installed mercurial? neither re-running bootstrap nor re-running mercurial-setup seems to do it
06:09heycamit's a bit of a problem that when these announcements come out to upgrade my mercurial/git, that I won't be able to get updated versions until several days later when my distro / package manager has them available
06:09heycamand by then I might have forgotten to do the upgrade...
06:09pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/63ebcdc4d3ab - Boris Zbarsky - Bug 1385656. Fix the interaction of RecoverLetterFrames and ::first-line. r=heycam
06:12hsivonenheycam: my conclusion from a previous CVE round was that it's not safe to rely on Ubuntu for timely hg patching
06:12heycamhsivonen: hmm
06:12hsivonenUbuntu does have a new git package for me today. I haven't yet checked if it addresses the CVEs that I expect
06:12heycam(and yeah I'm on Mint, so approximately Ubuntu)
06:13heycamI updated, upgraded, checked the changelog.Debian.gz, didn't see anything relevant for either mercurial or git :(
06:14hsivonenheycam: today's git update in Ubuntu addresses (according to Ubuntu's advisory) the CVE that gps's dev-platform alert was about
06:15heycamhsivonen: oh yeah so it does, thanks
06:16hsivonenanyway, it looks like the incantation for upgrading mach-installed hg is sudo pip install --upgrade mercurial
06:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/e0975a1eefb2 - Luke Chang - Bug 1385196 - [Form Autofill] Enable the feature based on locale and geoip. r=MattN
06:17pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/5f8a0a826ad1 - Matthew Noorenberghe - Bug 1385196 - [Form Autofill] Test: Enable the feature based on locale and geoip. r=lchang
06:17hsivonenand, indeed, no advisory for hg from Ubuntu this time, either
06:18hsivonenI'm guessing the reason is that mercurial is in universe
06:19bagdergit is fixed in debian unstable
06:20bagderseems it is fixed in all living debian branches
06:21bagderbut mercurial is not
06:26pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/5b706cd241cb - Henri Sivonen - Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r=smaug
06:44gastonfixed mercurial was released upstream
06:49pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/126a73fcf3a5 - Cameron McCormack - servo: Merge #18037 - style: Split collected @font-face / @counter-style rules per origin (from heycam:split-cascade-font-counter); r=emilio
06:56pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/224c22ab5f5f - Aryeh Gregor - Bug 1389207 - Document named getter should not return <embed>s by id; r=mystor
07:05Aryxwhimboo: hi, backout for 1254136 incoming: https://treeherder.mozilla.org/logviewer.html#?job_id=122479656&repo=autoland
07:07pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/4a9fa2c0c14f - Sebastian Hengst - Backed out changeset 69f808119fa3 (bug 1254136) for failing marionette-headless&#39; test_cli_arguments.py TestCommandLineArguments.test_start_in_safe_mode on OS X and in marionette on Linux opt. r=backout
07:07whimbooAryx: k, strange that try didn&#39;t show any issues again
07:08pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/eb8472ddb6f9 - cku - Bug 1389068 - Add comment for GetPreEffectsVisualOverflow. r=louis
07:10Aryxstone: hi, mochitest failure for 1351148 https://treeherder.mozilla.org/logviewer.html#?job_id=122462188&repo=mozilla-inbound
07:11aygWhat happens if I push a commit to inbound that conflicts with something on autoland?
07:11aygWill the sheriffs back it out and ask me to resolve it?
07:12aygIs there any good way to avoid this other than waiting for autoland to merge to central, or landing via MozReview so it goes on autoland?
07:12Aryxeither try to merge it manually or back it out and ask you to try again
07:12Aryxsafest is to land via autoland
07:13aygBut I can&#39;t do that directly, only via MozReview, right? And then I need to get MozReview to agree that my patches are reviewed etc.?
07:13pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/a08211592563 - Gian-Carlo Pascutto - Bug 1389078 - Remove (unneeded) usage of internal libc header. r=jld
07:14pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/7581c0c154de - Zibi Braniecki - Bug 1377911 - Move the override chrome entries from language manifests to product manifests. r=Pike
07:14stoneAryx: let me check the failure.
07:14pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/6c2389558858 - Boris Zbarsky - Bug 1388877. Fix insertions under a ::first-line in stylo. r=heycam
07:16Aryxayg: from http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html you can submit &quot;if a) The commit has been reviewed by someone with L3 access, or b) The commit has been submitted (pushed to MozReview) by someone with L3 access.&quot;
07:17aygHmm, okay.
07:21pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=93637&endID=93638 - 12 changesets (bug 1351148)
07:23dietrichanyone know of getUserMedia problems in latest nightly?
07:24Aryxstone: thank you
07:26dietrichlooks like gUM fails to create stream or error when audio only
07:31pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?startID=93638&endID=93639 - 21 changesets (bugs 1380081, 1386369, 1365309)
07:38gcpfrancois_: http://alerts.telemetry.mozilla.org/index.html#/detectors/1/metrics/244/alerts/?from=2017-08-02&to=2017-08-02
07:38gcpoh, wrong francois_ it seems
07:43pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/806a941c8580 - Lars T Hansen - Bug 1379814 - Clean up task selection logic, implement master task concept. r=luke
07:43aygDoes anyone know why document.all appears to be undefined in these tests, despite the fact that it works if I type it in the console or jsfiddle? http://w3c-test.org/html/dom/interfaces.html
07:43aygIs there some magic going on here?
07:46bz_sleepayg: yes
07:46bz_sleepayg: The test is wrong; there&#39;s a longstanding bug on it
07:47bz_sleepayg: https://html.spec.whatwg.org/#dom-document-all see the &quot;has several unusual behaviors&quot; bits
07:47ayghttps://github.com/w3c/web-platform-tests/issues/4207
07:47aygHmm, that should be readily fixable.
07:48aygDoesn&#39;t seem like this is testable by idlharness, then.
07:48bz_sleepayg: and in terms of impl, http://searchfox.org/mozilla-central/rev/4b79f3b23aebb4080ea85e94351fd4046116a957/js/public/Class.h#805-806 and http://searchfox.org/mozilla-central/source/__GENERATED__/dom/bindings/HTMLAllCollectionBinding.cpp#1047
07:49bz_sleepand all the resulting insanity
07:49bz_sleep(jit support, etc, etc)
07:50aygI guess I&#39;ll special-case it in idlharness.js.
07:50aygAlthough it&#39;s sort of lame to add special cases there.
07:50aygSeems easier than adding hooks and putting the logic in the interface test file.
08:03pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/3a1ec0cb0728 - Francois Marier - Bug 1387612 - Show Safe Browsing timeouts in Marionette logs. r=whimboo
08:08aygbz_sleep: https://github.com/w3c/web-platform-tests/pull/6820
08:18pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/8fad085b6143 - Ethan Lin - Bug 1388662 - Correct canvas transform in layers-free mode. r=mtseng
08:20pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a7bd8419732 - Florian Quze - Bug 1372518 - the identity block shouldn&#39;t flicker when loading a secure internal page in a new window, r=johannh.
08:24jorgkaryx: Hi, are you there?
08:27Aryxyes
08:27Aryxok, i see the email
08:30Aryxlth: hi, assertion failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=806a941c858051eceb8076b056fb278dcc259647&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
08:30jorgkYes, please land this and change the a=
08:32lthAryx: ok, i&#39;ll have to investigate that further. Can you backout?
08:32Aryxok
08:33jorgkaryx: Not sure what the OK is for, the backout or my bustage fix for M-C
08:34aygIs autoland not working? When attempting a try push on ReviewBoard: &quot;An error occurred: Autoland returned an error message during communications.&quot;
08:35pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/c4eb424ae518 - Sebastian Hengst - Backed out changeset 806a941c8580 (bug 1379814) for asserting at HelperThreads.cpp:997, e.g. in chrome tests on OS X. r=backout on a CLOSED TREE
08:35Sylvestreayg, I guess we have an infra issue, mozreview is telling me &quot;[Errno 12] Cannot allocate memory&quot;
08:40hsivonenwhat&#39;s the right way to land a follow-up to autoland?
08:41hsivonenthat is, are there special steps I need to take to avoid making mozreview confused about an earlier patch with the bug number alreaday having landed?
08:41Aryxjorgk: so why is m-c not broken?
08:44jorgkaryx: good question, but it happened before that something got landed that broke C-C but not M-C
08:46jorgkaryx: bug 1345771 had the same issue
08:48pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/518e73ca3d42 - Sebastian Hengst - Backed out changeset 5b706cd241cb (bug 483155) for Valgrind failure on Linux x64 opt. r=backout
08:50Aryxjorgk: please get a review
08:50jorgkaryx: from whom? I don&#39;t even know that cause this.
08:54pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/048ed01b19e0 - Henri Sivonen - Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r=smaug
08:56Aryxit&#39;s in Graphics, so from a Graphics peer?
08:57pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/67963f1a665a - Sylvestre Ledru - bug 1320656 - When exists, add -Wno-noexcept-type to the js build flags until we have a proper fix r=glandium
08:58jorgkaryx: Yes, done.
08:58jorgkBye.
08:59pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/ded54fea4c6b - Do Gottwald - Bug 1388509 - Fix tab-icon-overlay alignment on pinned tabs. r=daleharvey
09:04pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/2cf4290c2eef - Andreas Tolfsen - Bug 1388424 - Read capabilities off top-level object. r=whimboo
09:20GijsAryx: you around?
09:20AryxGijs: yes
09:20GijsAryx: https://bugzilla.mozilla.org/show_bug.cgi?id=1388753#c11
09:20GijsAryx: I&#39;m assuming I&#39;m OK to reland this somehow?
09:20GijsI would really like this to make today&#39;s nightly if possible.
09:21Gijsafaict the second time I landed it it was green on autoland
09:21Gijsbut somehow merging m-c back to autoland backed out my csets
09:22* Gijs assumes this was unintentional given lack of needinfo and not backing it out of autoland itself
09:27aygjgraham: Do you know why this is an ERROR in Firefox and not Chrome? html/infrastructure/common-dom-interfaces/collections/domstringlist.html It&#39;s fired by an IndexedDB operation, which I think is somehow caught by the document error handler.
09:28aygI saw it in one other place too.
09:28AryxGijs: looks like your change got reverted? https://hg.mozilla.org/integration/autoland/file/tip/browser/components/customizableui/PanelMultiView.jsm#l340
09:28GijsAryx: yes, that&#39;s my point.
09:28aygEither IndexedDB is firing errors in a way it shouldn&#39;t be, or the harness is catching them in a way it shouldn&#39;t be.
09:28GijsAryx: the merge reverted my changes even after I landed a second time
09:28ayg(I would expect this error to be treated as handled, since an onerror handler is specified, and not catchable by the error handler.)
09:28GijsI don&#39;t really understand why
09:29Aryxneither do i
09:29GijsRight, then I guess I&#39;ll just land again
09:29Gijsassuming autoland lets me
09:29* Gijs had to re-push
09:30pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/bd9ea3879cde - Gijs Kruitbosch - Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
09:31AryxGijs: i can also check the previous history and land it with the merge
09:32GijsAryx: either wfm
09:32GijsAryx: I&#39;ve relanded on autoland just in case - I need to step out for a while, will probably be back around 1-2pm
09:33pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/52e5d83fadfa - Gijs Kruitbosch - Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer
09:33GijsAryx: thanks! :)
09:42jgrahamayg: Not sure, it does look like it ought to work
09:45glandiumttaubert: why is it not possible to open nss phabricator urls without logging in?
09:46ttaubertglandium: seems to be a problem only when I create them. works fine for franziskus. our instance is weird :(
09:46glandiumO_o
09:47glandiumI guess I should create an account
09:48glandium&quot;Your account has been created, but needs to be approved by an administrator.&quot;
09:48glandiumttaubert: are you an administrator?
09:48ttaubertglandium: no :(
09:49ttaubertglandium: the patch basically just sets curve = 0, not worth the hassle :)
09:49glandiumttaubert: it&#39;s weird though... I see no reason it should complain. Especially on big endian only
09:51ttaubertglandium: well if we bail out here https://searchfox.org/nss/source/cpputil/databuffer.h#106
09:51ttaubertthen curve would indeed be uninitialized
09:51ttaubertit&#39;s probably not smart enough to infert enough information about len() ?
09:52glandiumttaubert: mmm but then why doesn&#39;t it complain on little endia?
09:52ttaubertthat&#39;s a good question
09:52ttaubertit should :)
09:53glandiumttaubert: other fun problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871700
09:53glandiumI think it is related to the -maes added to freebl
09:54ttauberthmmm yeah, the recent gcm patches
09:54ttaubertfranziskus: ^^
09:54ttaubertI actually thought we didn&#39;t introduce new constraints
09:55ttaubertwe have runtime checks for those things, maybe we got it wrong
09:55pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=32311&endID=32312 - 111 changesets (bugs 1388946, 1371395, 1383009, 1370682, 1389113 and 52 other bugs)
09:55glandiumttaubert: -mpclmul and -maes are passed to all files, they presumably allow the compiler to use those instructions
09:56glandiumttaubert: yeah, that&#39;s most likely it
09:57ttaubertglandium: https://searchfox.org/nss/source/lib/freebl/blinit.c#68 (the runtime checks)
09:57glandiumttaubert: gcc doesn&#39;t care
09:57glandiumit&#39;s told it, itself can use those instructions
09:58ttaubertoh hmm
09:58pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/94efd7ef04b2 - Gijs Kruitbosch - Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
09:58ttaubertfor other things not just the GCM code you mean?
09:58pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/64f5e3f40f0e - Gijs Kruitbosch - Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer a=reland stuff lost during last merge
09:59glandiumttaubert: for everything built with -mpclmul -maes, which is everything in lib/freebl
09:59ttaubertglandium: I guess... that makes sense. hmm
10:01glandiumI don&#39;t remember the gcc flag that says what&#39;s enabled and what&#39;s not
10:05Aryxwhimboo: hi, backout for ato&#39;s 1388424 incoming https://treeherder.mozilla.org/logviewer.html#?job_id=122515538&repo=autoland
10:06glandiumttaubert: yeah, -maes implies -msse and -msse2, which allows gcc to use those instruction sets
10:07glandiumlet me open a bug
10:11pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/d3cb33a38211 - Sebastian Hengst - Backed out changeset 2cf4290c2eef (bug 1388424) for failing marionette&#39;s test_quit_restart.py TestQuitRestart.test_force_clean_restart. r=backout
10:12whimbooAryx: k
10:13pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/22734f3d4b60 - Jonathan Kew - Bug 1387912 - Add missing #include to dom/canvas/ImageBitmap.h, to avoid build fragility (unified-compilation dependency. r=jrmuizel
10:25pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/16f4c4efa148 - Sebastian Hengst - Backed out changeset 6c2389558858 (bug 1388877) for asserting at ServoRestyleManager.cpp:1450 in stylo reftests and crashtests. r=backout
10:26jorgkaryx: Could you land https://hg.mozilla.org/integration/mozilla-inbound/rev/22734f3d4b603253f6e9ba1b4ff9bd36e4a73712 on M-C, that fixes the bustage
10:28glandiumAryx: do the C oranges ring a bell? https://treeherder.mozilla.org/#/jobs?repo=try&revision=f01411eecf4b8211a06457c0979401d9037a9648
10:31pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/95536a26dee7 - Michal Novotny - Bug 1369051 - Assertion failure: !entry || !entry->IsFresh() in CacheIndex::UpdateIndex, r=honzab
10:35Aryxglandium: no. https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee386bc2bf9a3361ca389b4161ffef99f0fa610f is from the same parent and has the crashtest green on opt
10:39pulsebotCheck-in: https://hg.mozilla.org/mozilla-central/rev/65826179c86e - Jonathan Kew - Bug 1387912 - Add missing #include to dom/canvas/ImageBitmap.h, to avoid build fragility (unified-compilation dependency. r=jrmuizel a=stability
10:40Aryxjorgk: done
10:40jorgkaryx: thanks!!
10:44pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/0aca62e914cf - Gabor Krizsanits - Bug 1376895 - Make preloaded browser use pre-existing content process. r=mconley
10:55pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/42cf6375ccfd - Masatoshi Kimura - Bug 1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal(). r=bz
10:56pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/fc357f0e9f40 - Masatoshi Kimura - Bug 865664 - Remove deprecated nsIDOMWindowUtils.getOuterWindowWithId. r=bz
11:33pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/79a29b14cc26 - Anthony Ramine - servo: Merge #18035 - Animate basic shapes (from servo:animate-basic-shapes); r=emilio
11:34gastonhttp://www.club.cc.cmu.edu/~cmccabe/blog_the_bad_build_system_drinking_game.html sometimes.....
11:34pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/27db3f759f7a - Ed Lee - Bug 1335057 - Fix intermittent bug1058164.js test timed out by conditionally waiting. r=mconley
11:36pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/8732792de20d - Lennart Grahl - Bug 979417 - Implement EOR when receiving and explicit EOR when sending on data channels (including DCEP). r=drno,jesup
12:05Aryxgaston++
12:13Gijs_awayAryx: thanks for making those bugs make nightly! :)
12:16pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/15af7a521401 - Hiroyuki Ikezoe - Bug 1389440 - Replace pseudo style with the one having animations before generating elements corresponding to content propery. r=emilio
12:24pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/4236c7131a55 - Hiroyuki Ikezoe - Bug 1389450 - Use a valid value for -moz-force-broken-image test. r=daisuke
12:33pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1d92b08b65a5 - Xidorn Quan - servo: Merge #18042 - Make nsStylePosition::mGridTemplate{Columns,Rows} a UniquePtr (from upsuper:grid-template); r=canaltinova
12:34pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/02097a6c83f4 - Xidorn Quan - Bug 1388255 - Make nsStylePosition::mGridTemplate{Columns,Rows} a UniquePtr. r=canaltinova,dholbert
12:35pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/372308629f8d - Xidorn Quan - Bug 1388241 - Assert that all style structs are under 504 bytes. r=bz
12:36pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/c73f64ef71d2 - Hiroyuki Ikezoe - Bug 1341102 - Update wpt expectations. r=me
12:40Aryxgabor: hi, these issafetorun assertions on 1376895, regression from that patch? https://treeherder.mozilla.org/logviewer.html#?job_id=122546338&repo=mozilla-inbound
12:44pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea704d8cd779 - Nicolas B. Pierron - Bug 1388014 part 1 - IonMonkey: Devirtualize MResumePoint::getOperand function calls. r=jandem
12:44pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/68444a862226 - Nicolas B. Pierron - Bug 1388014 part 2 - IonMonkey: Simplify RValueAllocation hash function. r=jandem
12:47pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/f7e05dffb1ab - Do Gottwald - Bug 1388628 - Disable reusing the selected tab for session restore. r=mikedeboer a=sylvestre
12:48pulsebotCheck-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd299dd19d6 - Sebastian Hengst - Backed out changeset 0aca62e914cf (bug 1376895) for asserting IsSafeToRun(), at dist\include\mozilla/SchedulerGroup.h:81 e.g. in mochitest dom/events/test/test_bug336682_1.html on Windows 10 x64. r=backout
13:09pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/f6d3f258b043 - ffxbld - Automatic version bump. CLOSED TREE NO BUG a=release
13:09pulsebotCheck-in: https://hg.mozilla.org/releases/mozilla-beta/rev/7f3005046367 - ffxbld - No bug - Tagging 2638feb177dd9104a3887fae2ce05931a6b41d6c with FIREFOX_56_0b2_BUILD1, FIREFOX_56_0b2_RELEASE a=release CLOSED TREE
13:16bz_sleepReview requests should only be reopened if your changes have not landed or have
13:16bz_sleepbeen backed out - file new bugs for follow-up work.
13:16* bz_sleep hates mozreview
13:16bz_sleepThese changes _were_ backed out.
13:21pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/97dae871389b - Mike Hommey - Bug 1389436 - Explicitly instantiate gfxFont::GetShapedWord<uint8_t> for its use in gfxTextRun.cpp. r=jfkthame
13:22pulsebotCheck-in: https://hg.mozilla.org/integration/autoland/rev/1058b3aaa601 - Boris Zbarsky - Bug 1388877. Fix insertions under a ::first-line in stylo. r=heycam
13:22kanrunew nightly looks weird :/
13:24kanruoh, there are Flexible Space before and after my search bar
13:29fhartmannThe new Firefox Nightly is using an absurd amount of energy on my machine
13:29fhartmannhttps://irccloud.mozilla.com/file/3UfDMebx/51%25%20battery%20left%2C%20but%20only%201hr%20remaining
13:29jgrahamkanru: Yeah, I hope that&#39;s a bug and not something w