mozilla :: #activity-stream

5 Jan 2017
00:12as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1924
05:04as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1907
15:59as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1925
19:48as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1923
20:23as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1926
20:23as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1926
20:28as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/1927
22:19Mardakursula: any thoughts on how to get experiment data into PlacesProvider to do a different query?
22:20ursulaMardak: i think all the experiments are regular prefs now
22:20ursulashould be able to just look up the pref
22:20jkerim^: yep
22:21Mardakthe pref contains the value?
22:21jkerimMardak: we can set the experiment pref value to wahtever we want, i think for the msot part we use booleans
22:21jkerimso you could just say
22:23jkerimprefs.get('extensions.@activity-streams.experiments.topSitesQuery)
22:23jkerimor wahtever the key name of hte experiment is
22:24Mardaknod
22:24Mardakhttps://github.com/mozilla/activity-stream/blob/master/experiments_how_to.md
22:25jkerimwell this example shows looking it up from teh provider directly
22:32jkerimwhich actually behind teh scenes is looking up the pref
22:32jkerimbut you can also just look at the pref directly
22:37dmosejkerim: got a few mins to vidyo about how we do prefs for sentry stuff?
22:37jkerimdmose: yep
22:37jkerimyour room?
22:37dmosesure
22:37jkerimhere
6 Jan 2017
No messages
   
Last message: 11 days and 19 hours ago