mozilla :: #activity-stream

21 Apr 2017
07:22as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2457
14:22mconleydmose: interesting idea. I suspect once we've closed this first batch, something like that ought to be considered to see what else is being experienced in the wild.
14:36dmosemconley: just running it for a few mins, i saw tons from the awesomebar xbl
14:36mconleydmose: yep
17:55Mardakwhat's the plan for pocket strings and localization? there's one that's "Trending Stories by" which won't be liked by l10n as it's assuming something is placed at the end
19:30k88hudsonMardak: hm, yeah that one is tricky
19:30k88hudsonsince it's got an image
19:31k88hudsonmaybe we could move the HTML for the image into the string
19:31k88hudsonis anyone around that could review a config-related patch?
19:33as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2459
19:36as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2462
19:37as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2459
19:37as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2459
19:37k88hudsonoops sorry for the spam
19:59as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2457
20:00k88hudsondmose: Haha ok I found out what the issue was for the pref branch
20:00k88hudsondmose: it was missing a trailing "."
20:15r1ckyk88hudson: not sure if it was on purpose for now, but the pocket experiment has both control and variant set to true
20:15r1ckyso it is always on
20:30as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2427
20:33k88hudsonr1cky: oops, ok
20:33k88hudsonthanks
20:33r1ckyk88hudson: haha. it's a nice trick for dev though. never though of doing that
20:46ursulahas anyone seen this error in their browser console: Tried to get weighted highlights but there was no baselineRecommender
20:46ursulaon a first-run
21:03as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2464
21:04ursulaahh Mardak i made the pref thing into it's own PR
21:04ursulawant me to close and fold into the search one?
21:04ursulanvm
21:04ursulaLOL
21:05Mardak:)
21:05Mardakyou just wanted to be the 1000th closed PR! ;) :p https://github.com/mozilla/activity-stream/pulls?q=is%3Apr+is%3Aclosed
21:06ursula
21:06ursulai swear i had no idea
22 Apr 2017
No messages
   
Last message: 8 days and 10 hours ago