mozilla :: #activity-stream

18 May 2017
07:37as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2611
16:16Mardakk88hudson: should i take out SearchFeed too then?
16:16k88hudsonMardak: sure, if we don't need it for anything else
16:16k88hudsonawesome find!!
16:49dmoseMardak++
16:49Mardaki was pleasantly surprised at how well/simply it worked ;)
16:49Mardakalso avoids our hacky sending fake ContentSearch messages :p
16:50dmose:-)
16:58as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2612
17:16Mardakk88hudson: with Search.jsx not needing to connect to any Search state, is it preferable to connect(() => {})(component) vs passing a dispatch prop from Base.jsx?
17:25Mardakoh i guess just a plain connect()(Search) works too
18:02k88hudsonMardak: yes that's the right way
18:02k88hudsonMardak: at least, that's what most ppl do
19 May 2017
No messages
   
Last message: 40 days and 1 hour ago