mozilla :: #activity-stream

18 Apr 2017
13:57ursuladmose: do you think i should wait for us to have that meeting on telemetry before reviewing your patch? it might cause some changes to happen to telemetry sender
14:51ursuladmose: i'll do an initial review and then we can add to it if anything changes from the meeting actually
14:55as-github-botdmose: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2433
14:55as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2427
15:47dmoseursula: depends when the meeting is; i'd vote for getting this landed once its ready, and do any changes from there in a followon if appropriate
15:48dmoseursula: thanks for the review; excellent comments. i'll respond to them in a little while.,
15:50ursuladmose: sounds good :)
15:51dmosealso, i liked the monkey emojis
15:51ursulai couldn't resist
15:51dmoseclearly, i shoiuld put those in the tests themselves to test our i18n support
15:51ursulai agree
15:54dmoseursula: how do you type those in? copy paste?
15:54ursula: monkey :
15:54dmose
15:54ursulahttps://www.webpagefx.com/tools/emoji-cheat-sheet/
15:54dmosewoah, cool
15:55dmosemaybe our search widget wants to support that
15:55dmosenot that people would use it very often or anything
15:55ursulait would be a fun easter egg
15:55* dmose just bets there's an npm package...
15:57dmoseor, really, the awesomebar
16:58as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2436
17:14Mardakk88hudson: do we want to have travis run with node 6.9.1+ for eslint-plugin-mozilla?
18:23ursulaMardak: i pushed a new version for the search stuff, but i want to land a change in central for ContentSearch.jsm first so we don't have to call ContentSearch.init() like i did in my first patch
18:24ursulaso after the review is passed let's hold off on merging it or else it won't work
19:12as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2438
19:23dmoseursula: are you around to pair a bit on how to use generateQI with classes?
19:24ursuladmose: sure, but i'm not sure i'll be of much help
19:24dmoseursula: heh. my room?
19:24ursulayup, be there in a min
19:42ursulahttps://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierLib.js#50
19:48dmoseursula: you know i wonder if that prototype thing could be related to the fact that we're transpiling from JSMs to CommonJS modules
19:48ursulaoh! that's entirely possible
19:49ursuladidn't think of that
19:49dmosesince the code will actually be executed in a CommonJS context because of the way unit-entry works
19:49ursulak88hudson: might be able to provide more insight about that bit
19:49* dmose grins
20:07dmosek88hudson: are you around?
20:12ursulananj: https://mozilla-releng.net/trychooser/
20:13nanjursula: thnx
20:40as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2433
21:39k88hudsondmose: hey what's up
21:40k88hudsonMardak: yeah i'm ok with that
21:40k88hudsonMardak: writing for <6 is a PITA anyway
21:41k88hudsonand eslint in firefox is definitely on 6.something
21:42as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2438
21:48as-github-botdmose: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2433
21:51ursuladmose: thanks for all that telemetry work! excited to start using it
22:01as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2440
22:22dmoseursula: thanks for the good reviews!
19 Apr 2017
No messages
   
Last message: 9 days and 18 hours ago