mozilla :: #activity-stream

17 Mar 2017
15:29emtwonanj: ursula k88hudson jkerim ramen?
15:30emtworamen > pizza ?
15:30jkerimhttps://secure.static.tumblr.com/507214d61de89550d941665a77a4a831/rmushrj/y9iokva8u/tumblr_static_tumblr_static__640.jpg
15:30k88hudsonemtwo: sure
15:30nanjyep, ramen rules
15:30emtwoalso we have a 12:45 meeting so lets leave in a few min?
15:30jkerimso it is souped, so let it be noodled
15:31ursulai'm down for ramen today
15:32nanjtrue, so let's form the squd then march on
15:32jkerim\o/
15:32nanjursula:
16:14dmoseok, the new pushed-to-pine stuff is already catching things in the bootstrapped add-on
16:15dmoseit's failing the m-c eslint :-)
16:45dmosehttps://public.etherpad-mozilla.org/p/as-retrospectives
17:32as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2266
17:35as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2266
18:09as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2265
18:19dmoseexcitingly, no perf regressions in the (no-op, but still :-) most recent pine build: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=3945f2297b99&newProject=pine&newRevision=bc5fff53646952aad7049f86e0340f919a8b5719&framework=1
18:34ckarlofhey can anyone here help ekr on how to load local JSON in an add-on?
19:24as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2268
19:30jkerimckarlof: yep
19:31jkerimsent him a pm
19:32k88hudsondmose: nice!!
19:32k88hudsondmose: i tried running the SearchFeed tests on my patch btw
19:33k88hudsondmose: looks like the only changes needed will be related to the messages stuff, which is going to have to be different anway
19:33k88hudson*anyway
19:35k88hudsonbut mostly we'll be able to reuse the tests
19:48as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2270
19:58dmosek88hudson: sweet!
19:59k88hudsondmose: let me know what you think of the import/global overriding strategies
20:05dmosek88hudson: on #2249?
20:05k88hudsonyeah
20:05dmosek88hudson: somehow i was assuming you were going to need to change some stuff after our discussion yesterday. is that assumption incorrect?
20:06k88hudsondmose: well, I took a look at the compatibility of the existing tests and i don't think there's actually changes needed
20:06k88hudsondmose: i could interally rename actionSubscribers back to feeds
20:07k88hudson*internally
20:07dmosek88hudson: i guess i would suggest doing that just keep the code more easily readable for the folks coming to the bootstrapped add-on later....
20:07k88hudsondmose: ok cool, I can do that
20:07dmosek88hudson: thanks
20:10k88hudsondmose: ok, done
20:13dmosek88hudson: ok!
20:13* dmose starts poking
21:14as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2263
21:19dmosejkerim: https://github.com/WICG/longtasks
21:37ckarlofjkerim: thanks (re: add-on question)
22:35as-github-botdmose: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2263
18 Mar 2017
No messages
   
Last message: 41 days and 8 hours ago