mozilla :: #activity-stream

17 Apr 2017
14:59as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2431
15:03as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2431
16:44as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2304
16:52k88hudsondmose: hey, where is the right place to enable test-specific prefs do you think
16:52k88hudsonto turn off the feeds
16:53dmosek88hudson: hmm, good questions
16:53dmosek88hudson: do you mean where in our code?
16:53dmoseshould the pref-reading be handled?
16:53k88hudsonk88hudson: no, i have that done
16:53k88hudsoni just need to flip it to false for the mochi tests
16:53dmoseso there's a place to do that
16:53k88hudsonto fix those pine failures
16:54dmoselook through the mozilla-centreal-patches
16:54dmoseone of them patches a file in "testing"
16:54dmosek88hudson: btw, i'm assuming we want to use browser.newtabpage.activity-stream as the pref branch for all our new prefs (as was used in bootstrap.js)
16:54k88hudsonyep i think that's right
16:55dmoseok, great
16:55k88hudsondmose: i don't see testing anywhere hmm
16:55k88hudsonlet me keep looking
16:55dmosehang on
16:55dmoseoh, hah
16:55dmosethose changes landed in mozilla-central already
16:55dmoseand don't need patching
16:55k88hudsonwhich changes?
16:57dmosethe ones to the testing dir, i think
16:57dmosebut i can't find them at the moment
16:57dmosemaybe Mardak knows where they are
16:57dmoseotherwise i'll poke around some more after hte meetings
16:58k88hudsondmose: ok cool
17:10as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2433
17:12ursuladmose: i'll start the review for your patch today after meetings - how much of it was ported from our current telemetry sender, just so i know where it's coming from?
17:16dmoseursula: all of the code was a straight port, i wrote the unit tests from scratch.
17:17ursulasweet thanks dmose
17:17dmosesure thing; thank you!
17:18dmoseursula: i ignored the old jpm integration tests, that may or may not have been the right decision
17:18ursulai guess we'll find out
17:18dmose:-)
17:19dmosewell, i'm happy to hear opinions on that as part of the review, if you've got any in particular
17:59dmosewe're requiring 100% coverage or travis blows up?
17:59dmoseinteresting
18:01dmoseexcitingly, the coverage tool is quoting bogus uncovered line numbers
18:01dmosemaybe it's using numbers from the transpiled JSM rather than the source?
18:18tspurwayhttps://bugzilla.mozilla.org/buglist.cgi?resolution=---&query_format=advanced&component=Activity%20Streams%3A%20General&list_id=13540553
18:26ursuladmose: if you go under logs > coverage > system-addon > report-html and open up index.html in a browser it should show you which lines were uncovered
18:27ursulathe coverage results within the terminal shows bogus lines but the html page will show you the right uncovered lines
18:28dmoseursula: ok, thanks
19:00ursulaMardak: do you have a min to pair on the search stuff?
19:24as-github-botnchapman: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2435
19:24as-github-bottspurway: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2435
19:24as-github-botaaronrbenson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2435
19:24as-github-botpdehaan: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2435
19:24as-github-botSoftvision-VladBacia: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2435
19:24as-github-botjennchaulk: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2435
20:01as-github-botdmose: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2434
20:13dmoseugh, our globals strategy is having issues
20:13dmoseit doesn't cope with async tests
20:13dmoseso the spies on the global end up being shared between async tests
20:13dmosewhich makes the call counts have issues
20:14dmosemaybe lunch will help
20:15ursulaMardak: i filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1357174 so we don't have to do ContentSearch.init() in our feed.... i'm gonna land it directly in mc
20:15ursulacan you review?
20:40pdehaangreetings activity streamers! is there a target Firefox version for activity stream landing? 55? 57? <other>?
20:47as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2436
21:07mconleyjkerim: https://mikeconley.github.io/ohnoreflow/
21:08jkerimmconley: oh its nightly only eh
21:08jkerimalso tahts funny
21:08jkerimit wont install in release
21:08jkerimand instead of saying incompatible or unsigned&#39;
21:08jkerimit says the bundle is corrupted
21:08mconleyjkerim: heh, wonderful
21:08mconleyjkerim: yeah, unsigned add-on, Nightly or Dev Edition is where you can use it
21:09jkerimoh its an addon
21:09jkerimis ita hybrid?
21:09mconleyand you need the Reflow API WebExtension experiment thing
21:09mconleyit&#39;s like, a two-parter
21:09mconleyhttps://mikeconley.github.io/reflow-api/ gives you the API that the WebExtension needs
21:09jkerimright, an addon side to expose a web extension api
21:09jkerimand a web extension to consume it
21:09mconleyyeppers
21:09jkerimyou can deploy those together as a single bundle
21:49mconleyk88hudson: gfrirtsche or gsvelto
23:33dmoseMardak: you around?
18 Apr 2017
No messages
   
Last message: 100 days and 21 hours ago