mozilla :: #activity-stream

16 Mar 2017
02:30dmosek88hudson: yo
15:36emtwohttps://sql.telemetry.mozilla.org/dashboard/firefox-ios-metrics-summary
15:36emtwohttps://sql.telemetry.mozilla.org/dashboard/android-activity-stream-proof-of-concept-
15:37emtwohttps://sql.telemetry.mozilla.org/dashboard/android-activity-stream-interactions
16:38dmosek88hudson: what's up?
16:38k88hudsondmose: I was going to ask about switching the karma tast to nightly, but I figured it could wait for a follow-up if necessary
16:38k88hudson*task
16:40dmosek88hudson: sure, a followup is fine
17:00as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2234
17:35as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2259
18:12as-github-botdmose: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2234
18:44jkerimi just realized if we dont have a set deadline anymore then we dont have that fixed number of MVP bugs to draw from anymore, right?
18:44jkerimi guess ill ask tspurway when he gets back
19:03r1ckyjkerim: what's the new deadline? ASAP?
19:03r1ckyor yesterday?
19:03jkerimthe new deadline is when it lands in mc with topsites and highlights and metadata without regressing talos'
19:04* r1cky lols
19:30jkerimk88hudson: ping
19:30k88hudsonjkerim: whats up
19:30jkerimi dont understand what this is:
19:30jkerimhttps://github.com/mozilla/activity-stream/blob/master/content-test/lib/getRelativeTime.test.js#L24-L29
19:30as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2260
19:30jkerimbut its failing for me
19:31r1ckyjkerim: i am pretty sure it's because of the time zone change
19:31r1ckybut it doesnt happen on travis
19:31r1ckyno idea
19:31k88hudsonjkerim: it's supposed to show "1d" if the top site is one day ago
19:31r1ckythe 5d one fails right now
19:32jkerimyeah exactly
19:32r1ckymaybe until tomorrow then our time zone change will be in the past
19:32jkerim expected 4 to equal '5'
19:32r1ckytime zones are hard!
19:32r1ckyand off by one errors
19:32jkerimokay so i didnt break it
19:32k88hudsonjkerim: interesting
19:33jkerimor did i.
19:33k88hudsonjkerim: i guess moment() isn't accounting for the time zone or something? idk
19:33k88hudsontime change* that is
19:33jkerimnope fails on master
19:33jkerimphew
19:56as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2240
19:56as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2240
19:57jkerimk88hudson: if you dont have time dontw orry about it but if you can just take a look and make sure i didnt horribly wreck anything
19:57k88hudsonjkerim: ok im just finishing up something but i can take a look a bit later
19:58jkerimawesdome thnx :D
20:06jkerimtwo rows of top sites with high res icons and screenshots:
20:06jkerimhttps://irccloud.mozilla.com/file/ehNZ4858/Screenshot%202017-03-16%2016.02.46.png
20:18as-github-botemtwo: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2262
20:33as-github-botdmose: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2263
20:40rhelmerhm. so bug 1347482 might be because of the security checks we have for navigator.mozAddonManager ... going to get some folks to look into it.
20:54rhelmerer, sorry that's pageshot not activity stream :( nm :)
17 Mar 2017
No messages
   
Last message: 9 days and 14 hours ago