mozilla :: #activity-stream

15 May 2017
16:20as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2595
17:01as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2595
17:16as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2597
17:59as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2599
18:08jkerimr1cky: https://github.com/mozilla/activity-stream/issues/2596
18:08jkerimwho decided this
18:08jkerimare ou suggesting this
18:08jkerimor did it come from design via trello?
18:08k88hudsonhttps://public.etherpad-mozilla.org/p/as-triage
18:08r1ckyjkerim: no. it was mentioned at some point last week by aaron_, etc
18:08r1ckyin one of our meetings. cant remember which
18:08jkerimr1cky: so design wants us to do it
18:09r1ckyjkerim: yep.
18:09jkerimokey doke
18:12jkerimk88hudson: https://github.com/mozilla/activity-stream/issues/2592
18:22as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2599
19:02as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2597
19:45k88hudsonMardak: ok, so it looks like the reason the sass files were throwing weird errors and creating extra css files is because partials are supposed to have filenames starting with underscores http://sass-lang.com/guide#topic-4
19:46Mardakoh
19:46k88hudsonMardak: so I guess I could alternatively rename all the files, what do you think
19:47Mardakhow were you triggering these extra files where?
19:50k88hudsonso, if you don't have any external variables
19:50k88hudsonit will generate a second css file that corresponds to the file you're editing
19:50k88hudsonif you do have external variables/mixins it throws an error every time you change the file
19:50Mardakoutput to oh i see it now
19:51Mardakso we would have TopSites/_TopSites.scss ?
19:51k88hudsonyeah
19:51Mardakthe import should stay the same?
19:52k88hudsonwell, @import 'TopSites/_TopSites'
19:53k88hudsonit seems like a really weird constraint
19:54Mardakk88hudson: leaving the import as @import './components/TopSites/TopSites'; seems to work fine
19:54k88hudsonoh really?
19:55Mardakmatches their @import 'reset' example too
19:55k88hudsonoh yeah you're right
19:56k88hudsonweird
19:56Mardakk88hudson: ok sounds good! just a rename then
19:56k88hudsonMardak: cool
19:56k88hudsonit'd be nice if we had a lint rule or something to enforce that
20:28as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2602
20:37as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2602
16 May 2017
No messages
   
Last message: 9 days and 18 hours ago