mozilla :: #activity-stream

15 Feb 2017
15:28as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2177
18:07as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2176
18:26jkerimursula k88hudson Mardak is there a url i can enter into my browser that takes me to activity stream?
18:26jkerimlike if i explicitly enter about:newtab i get tiles
18:26jkerimis there some url i can enter to explicitly get activity stream?
18:27ursulaLike out in the wild?
18:27k88hudsonjkerim: resource://activity-streams/data/content/activity-streams.html
18:28jkerimk88hudson: thnx!
18:28k88hudsonnp!
18:44ursulak88hudson: i left a comment on the PR: https://github.com/mozilla/activity-stream/pull/2176#issuecomment-280100143 wanna update it before i start review?
18:45k88hudsonhuh, how did i miss those
18:45k88hudsonursula: sure
18:46ursulathere's a lot of references to share
18:50k88hudsonursula: ok should be good
18:50ursulasweet thanks k88hudson
18:50k88hudsonoh crap
18:50k88hudsonmissed the images
18:51ursulawould you be able to update the docs too?
18:51ursulathere's some events in there that reference share
18:51ursulai dunno we could keep it in but meh
18:52k88hudsonhmm
18:54k88hudsoni almost want to kind of leave those
18:54k88hudsonsince they kind of have to do with the back end as well
18:54k88hudsonand for like, back referencing data
18:54ursulayeah leave them in there
18:54k88hudsonthat already exists
18:54ursulagood call
18:54k88hudsonok
19:01as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2177
19:06nanjemtwo: hey, could you take a look at this one? https://github.com/mozilla/splice/pull/372
19:08nanjwe wanted to deploy this to stage today so that we could do some further tests there
19:09Mardakshield bug https://bugzilla.mozilla.org/show_bug.cgi?id=1308656
19:12emtwonanj: sure
19:13nanjemtwo: thank you!
19:14nanjemtwo: also, since 6a68 is out of office, i just increased the size of the "raw" field
19:14emtwonanj: ok cool, we can decrease it later then?
19:14nanjit should be enough for now
19:15nanjit's a variable length string, so it won't waste any space
19:18nanjemtwo: i've already checked the current 'raw' field in the payload, it's quite big, like several kilobytes. i'd ask them to only include the useful fields. otherwise, it'll quickly fill up our database
19:20ursulahttps://hg.mozilla.org/try/rev/fceb50e21e84808d87a363c1a894c68b31251b44
19:20ursulahttps://treeherder.mozilla.org/#/jobs?repo=try&revision=fceb50e21e84808d87a363c1a894c68b31251b44
19:21ursulatspurway: are you free to come back to don mills?
19:22tspurwayi am in the UX meeting
19:23tspurwaycan i help over irc?
19:23ursulawe just got mike cooper for sdk stuff on vidyo just wanted to know if you wanted to come back
19:23ursulait's ok no worries!
19:25as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2178
19:29Mardakhttps://public.etherpad-mozilla.org/p/as-sdk
19:35jkerimursula k88hudson quick question
19:35jkerimhttps://github.com/mozilla/activity-stream/blob/master/addon/ActivityStreams.js#L410
19:35jkerimwe should be able to use a pref to store this rather than simple storage, correct?
19:35k88hudsonjkerim: yes
19:35jkerimso i can do that and then deprecate simple storage, yes?
19:36k88hudsonsorry just in a meeting
19:36k88hudsonbut most likely yes
19:36jkerimperfect
19:36jkerimno more of this:
19:36jkerimhttps://gist.github.com/jaredkerim/dc3274d286f8cdf408992a9679782856
19:38tspurwayursula, k88hudson, mardak, dmose: if you folks are still talking to mike, id like to hear about how much effort it was to move away from the SDK
19:38tspurwayand whether we could extrapolate a meaningful amount of effort for our project from that
19:38Mardakfirst thing he said was basically lots of work ahead for us
19:38k88hudsonyep
19:38tspurwayhaha
19:38tspurwayawesome!
19:39tspurwayi suspect AS is a larger project
19:39tspurwayi also suspect we used more of the SDK
19:39k88hudsonyes, he said their use of it is pretty light overall
19:39k88hudsonat least of SDK features
19:40k88hudsonand mostly add-on side instead of content side
19:43as-github-botk88hudson: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2176
19:46Mardakhttps://github.com/mozilla/normandy/tree/master/recipe-client-addon
20:01as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2180
20:01as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2180
20:20emtwo@pdehaan I reassigned review of https://github.com/mozilla/ping-centre/pull/48 to you. If you don't mind taking a final quick look at it? :)
20:26ursulajkerim: the experiment provider also uses simple storage
20:26ursula:(
20:27jkerimalso for a single bool
20:27jkerimwhich shoudl probably also be a pref
20:27ursulamhm
20:27jkerimthnx ill add it to the ticket
21:00as-github-botMardak: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2177
21:14as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2177
21:30ursulaMardak: unfortunately when i don't explicitly do pref === false and just do !pref, then the tests in ExperimentProvider.test.js fail
21:30ursula:(
21:31as-github-botncloudioj: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2182
21:32Mardakursula: as in other tests get experiments disabled because the package.json default isn't getting set to true?
21:36Mardaki suppose we could also flip the pref to be disableExperiments ;)
21:38as-github-botrlr: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2182
21:47Mardakursula: quick test seems to work with setting activateExperiments to true in the top level `beforeEach`
21:48Mardakalthough there might be a better place to put these default prefs.. if not automatically reading in package.json prefs.. ?
22:29dmoseMardak: hmmm.... http://mozilla-version-control-tools.readthedocs.io/en/latest/headless-repositories.html
22:30Mardakwhat about it?
23:12dmoseMardak: it makes me wonder if the multi-headed approach is a good idea
23:13dmoseMardak: since that's what we're proposing to do. In particular, I don't want to cause problems on the hg server.
23:19Mardakdmose: ah i see. well sounds like problems from having many thousands of heads. even if we we're creating 100 heads each week, it seems like we should be okay by the time we're done with pine branch?
16 Feb 2017
No messages
   
Last message: 127 days and 16 hours ago