mozilla :: #activity-stream

13 Feb 2017
17:49nchapmandmose: what's the question about about:home?
17:58ursula^ we can chat about it in the product meeting
18:05dmoseRunning a little bit behind; be there in about 10 minutes
18:05dmoseSorry!
18:07nanjursula: jkerim: just found another weird value
18:07nanj"value":[0],"page":"NEW_TAB","source":"PLACES_STATS_FEED","
18:12nanjand the "event":"countMetadataURLs"
18:29ursulahttps://dxr.mozilla.org/mozilla-central/source/browser/base/content/contentSearchUI.js#302 keyboard events of the drop down searchbox in about:newtab
18:33amleeRestore Session Button - https://mozilla.invisionapp.com/share/HSAE60JNZ#/screens/218336118
19:33tspurwayhttps://cdn-enterprise.discourse.org/imgur/uploads/default/original/3X/9/8/98fcd2e49f0ebdb4f487f73f58e14ccbd98382b1.gif
19:37Mardakursula: https://hg.mozilla.org/try/rev/b0ed23505e6961e2214616dc5ea844d16976376d
19:42nanjtspurway: this is the patch that fixes the issue found in stage https://github.com/mozilla/infernyx/pull/60
19:44tspurwayr+
19:46nanjtspurway: ty! deploying to stage now
19:49Mardakursula, dmose, k88hudson: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9d5a3f33d9b8696a28ff39a1f25d7e516bb6420&selectedJob=76421750
19:51Mardakursula, dmose, k88hudson: https://public.etherpad-mozilla.org/p/as-mc-failures
19:53nanjjkerim: bug was filed here https://github.com/mozilla/activity-stream/issues/2166
19:54nanji've confirmed with ursula that the floating point value issue should not be in prod
19:55nanjit only happened once on Jan. 5th in stage, we no longer used the ratio since then
19:58Mardakdmose: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=25a94c1047e7&newProject=try&newRevision=d9d5a3f33d9b&framework=1&showOnlyImportant=0
19:59floddoes the MVP label mean that an issue needs to be fixed before it ships in Firefox?
20:00dmoseflod: yes
20:00flodgreat :-)
20:00flodwhile the localized version works pretty fine, I confess that I'm really struggling with it (lack of focus on search bar when you open a new tab is killing me)
20:00flod(found an issue marked as MVP, hence the question)
20:08dmoseflod: yeah, that's definitely part of the a11y work
20:12jkerimdmose Mardak ursula k88hudson r1cky when i run my activity stream test suite locally on master i have two failing tests, one for places provider syncing and one for tab tracker, they both say they timeout
20:13jkerimis this expected?
20:15as-github-botursula: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2167
20:16dmosejkerim: we're speculating that those are racey
20:16dmoseand tabtracker is pretty racey itself
20:17jkerimso youve seen them fail too?
20:17Mardakhttps://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=25a94c1047e7&newProject=try&newRevision=b0ed23505e69&framework=1
20:17dmosejkerim: ursula and k88 have
20:18jkerimokey doke thnx dmose
20:19dmosethe speculation is also that these are more likely bugs in the tests themselves, rather than the code under test
20:27r1ckyjkerim: i just ran the tests and got a bunch of timeouts too
20:32dmoseMardak: you might want to ask Osmose which particular talos tests made them decide to bail out on the SDK
20:32Mardakk88hudson: if you aren't on firefox-dev list, probably should get added https://mail.mozilla.org/pipermail/firefox-dev/2017-February/005033.html
20:32dmoseMardak: (shield, that is)
20:32Mardakdmose: nod. sounds good
20:32dmoseif he doesn't know, he would know who does
20:33MardakRyanVM asking about switching activity stream to WebExtensions
20:34k88hudsonMardak: thanks
21:00as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2167
21:03as-github-botjkerim: Hey! Someone just assigned you a PR for review: https://github.com/mozilla/activity-stream/pull/2169
14 Feb 2017
No messages
   
Last message: 105 days and 5 hours ago